RefController: Refactor ref menu to its own class

This commit is contained in:
Pieter de Bie
2008-11-01 23:16:41 +01:00
parent a9dad9dd31
commit 058fbcff58
5 changed files with 84 additions and 30 deletions
+3 -19
View File
@@ -8,17 +8,7 @@
#import "PBRefController.h"
#import "PBGitRevisionCell.h"
@interface RefMenuItem : NSMenuItem
{
PBGitRef *ref;
PBGitCommit *commit;
}
@property (retain) PBGitCommit *commit;
@property (retain) PBGitRef *ref;
@end
@implementation RefMenuItem
@synthesize ref, commit;
@end
#import "PBRefMenuItem.h"
@implementation PBRefController
@@ -27,7 +17,7 @@
[commitList registerForDraggedTypes:[NSArray arrayWithObject:@"PBGitRef"]];
}
- (void) removeRef:(RefMenuItem *) sender
- (void) removeRef:(PBRefMenuItem *) sender
{
int ret = 1;
[historyController.repository outputForArguments:[NSArray arrayWithObjects:@"update-ref", @"-d", [[sender ref] ref], nil] retValue: &ret];
@@ -42,13 +32,7 @@
- (NSArray *) menuItemsForRef:(PBGitRef *)ref commit:(PBGitCommit *)commit
{
RefMenuItem *item = [[RefMenuItem alloc] initWithTitle:@"Remove"
action:@selector(removeRef:)
keyEquivalent: @""];
[item setTarget: self];
[item setRef: ref];
[item setCommit:commit];
return [NSArray arrayWithObject: item];
return [PBRefMenuItem defaultMenuItemsForRef:ref commit:commit target:self];
}
# pragma mark Tableview delegate methods