mirror of
https://github.com/kennethreitz-archive/gitx.git
synced 2026-06-05 23:40:18 +00:00
Remove completely wrong TODO comment.
A deletion execution dialog should block the UI until it's complete if there could potentionally be state change occurring which has different outcome for pre-deletion or post-deletion finite state. A middle ground solution would be to use a modal sheet attached to a specific document which then only blocks this particular document.
This commit is contained in:
+1
-2
@@ -40,8 +40,7 @@
|
||||
NSString *ref_desc = [NSString stringWithFormat:@"%@ %@", [[sender ref] type], [[sender ref] shortName]];
|
||||
NSString *question = [NSString stringWithFormat:@"Are you sure you want to remove the %@?", ref_desc];
|
||||
int choice = NSRunAlertPanel([NSString stringWithFormat:@"Delete %@?", ref_desc], question, @"Delete", @"Cancel", nil);
|
||||
// TODO: Use a non-modal alert here, so we don't block all the GitX windows
|
||||
|
||||
|
||||
if(choice) {
|
||||
int ret = 1;
|
||||
[historyController.repository outputForArguments:[NSArray arrayWithObjects:@"update-ref", @"-d", [[sender ref] ref], nil] retValue: &ret];
|
||||
|
||||
Reference in New Issue
Block a user