From 1ade0f0620271d752ec1192f4e506b9f0e38584d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Berg?= Date: Sun, 8 Nov 2009 16:28:50 +0100 Subject: [PATCH] Remove completely wrong TODO comment. A deletion execution dialog should block the UI until it's complete if there could potentionally be state change occurring which has different outcome for pre-deletion or post-deletion finite state. A middle ground solution would be to use a modal sheet attached to a specific document which then only blocks this particular document. --- PBRefController.m | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/PBRefController.m b/PBRefController.m index 084d5be..58f65dc 100644 --- a/PBRefController.m +++ b/PBRefController.m @@ -40,8 +40,7 @@ NSString *ref_desc = [NSString stringWithFormat:@"%@ %@", [[sender ref] type], [[sender ref] shortName]]; NSString *question = [NSString stringWithFormat:@"Are you sure you want to remove the %@?", ref_desc]; int choice = NSRunAlertPanel([NSString stringWithFormat:@"Delete %@?", ref_desc], question, @"Delete", @"Cancel", nil); - // TODO: Use a non-modal alert here, so we don't block all the GitX windows - + if(choice) { int ret = 1; [historyController.repository outputForArguments:[NSArray arrayWithObjects:@"update-ref", @"-d", [[sender ref] ref], nil] retValue: &ret];