From 2676a20291208d273d53a3166c157ee2b3c9bfd0 Mon Sep 17 00:00:00 2001 From: Pieter de Bie Date: Wed, 24 Sep 2008 01:25:30 +0200 Subject: [PATCH] Fix some compiler warnings --- PBEasyPipe.h | 5 +++++ PBEasyPipe.m | 1 + PBGitCommitController.m | 2 ++ PBGitRepository.h | 3 ++- 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/PBEasyPipe.h b/PBEasyPipe.h index 4679cf7..8b15646 100644 --- a/PBEasyPipe.h +++ b/PBEasyPipe.h @@ -22,5 +22,10 @@ withArgs:(NSArray *) args inDir:(NSString *) dir retValue:(int *) ret; ++ (NSString*) outputForCommand:(NSString *) cmd + withArgs:(NSArray *) args + inDir:(NSString *) dir + inputString:(NSString *)input + retValue:(int *) ret; @end diff --git a/PBEasyPipe.m b/PBEasyPipe.m index af6c467..54af5b3 100644 --- a/PBEasyPipe.m +++ b/PBEasyPipe.m @@ -63,6 +63,7 @@ return string; } +// TODO: Refactor this to use the function above + (NSString*) outputForCommand:(NSString *) cmd withArgs:(NSArray *) args inDir:(NSString *) dir diff --git a/PBGitCommitController.m b/PBGitCommitController.m index 7a57bd6..d77d0f6 100644 --- a/PBGitCommitController.m +++ b/PBGitCommitController.m @@ -117,6 +117,8 @@ } NSLog(@"Success! New commit: %@", commit); + [commitMessageView setString:@""]; + [self refresh:self]; } - (void) cellClicked:(NSCell*) sender diff --git a/PBGitRepository.h b/PBGitRepository.h index e8b33d5..273b477 100644 --- a/PBGitRepository.h +++ b/PBGitRepository.h @@ -23,7 +23,8 @@ extern NSString* PBGitRepositoryErrorDomain; - (NSFileHandle*) handleForArguments:(NSArray*) args; - (NSFileHandle *) handleInWorkDirForArguments:(NSArray *)args; - (NSString*) outputForCommand:(NSString*) cmd; -- (NSString*) outputForCommand:(NSString *)str retValue:(int *)ret; +- (NSString *)outputForCommand:(NSString *)str retValue:(int *)ret; +- (NSString *)outputForArguments:(NSArray *)arguments inputString:(NSString *)input retValue:(int *)ret; - (NSString*) outputForArguments:(NSArray*) args; - (NSString*) outputForArguments:(NSArray*) args retValue:(int *)ret; - (NSString *)outputInWorkdirForArguments:(NSArray*) arguments;