diff --git a/GLFileView.m b/GLFileView.m index 90b05ec..b1d2da9 100644 --- a/GLFileView.m +++ b/GLFileView.m @@ -78,7 +78,7 @@ [script callWebScriptMethod:@"showFile" withArguments:[NSArray arrayWithObject:fileTxt]]; } -#ifdef DEBUG +#if 0 NSString *dom=[[[[view mainFrame] DOMDocument] documentElement] outerHTML]; NSString *tmpFile=@"~/tmp/test.html"; [dom writeToFile:[tmpFile stringByExpandingTildeInPath] atomically:true encoding:NSUTF8StringEncoding error:nil]; @@ -151,6 +151,13 @@ [self showFile]; } +- (void)closeView +{ + [historyController.treeController removeObserver:self forKeyPath:@"selection"]; + + [super closeView]; +} + - (NSString *) parseHTML:(NSString *)txt { txt=[txt stringByReplacingOccurrencesOfString:@"&" withString:@"&"]; diff --git a/GitX.xcodeproj/project.pbxproj b/GitX.xcodeproj/project.pbxproj index 65ea4fa..eab6697 100644 --- a/GitX.xcodeproj/project.pbxproj +++ b/GitX.xcodeproj/project.pbxproj @@ -1158,7 +1158,14 @@ isa = PBXProject; buildConfigurationList = 26FC0A880875C7B200E6366F /* Build configuration list for PBXProject "GitX" */; compatibilityVersion = "Xcode 3.1"; + developmentRegion = English; hasScannedForEncodings = 1; + knownRegions = ( + English, + Japanese, + French, + German, + ); mainGroup = 29B97314FDCFA39411CA2CEA /* GitTest */; projectDirPath = ""; projectRoot = ""; diff --git a/PBGitHistoryController.h b/PBGitHistoryController.h index 9eb81e9..93bfea0 100644 --- a/PBGitHistoryController.h +++ b/PBGitHistoryController.h @@ -18,6 +18,7 @@ @class PBRefController; @class QLPreviewPanel; @class PBCommitList; +@class GLFileView; @class PBGitSHA; @class PBHistorySearchController; @@ -34,6 +35,7 @@ IBOutlet PBWebHistoryController *webHistoryController; QLPreviewPanel* previewPanel; IBOutlet PBHistorySearchController *searchController; + IBOutlet GLFileView *fileView; IBOutlet PBGitGradientBarView *upperToolbarView; IBOutlet NSButton *mergeButton; diff --git a/PBGitHistoryController.m b/PBGitHistoryController.m index dd024d9..4146aeb 100644 --- a/PBGitHistoryController.m +++ b/PBGitHistoryController.m @@ -23,6 +23,7 @@ #import "PBHistorySearchController.h" #define QLPreviewPanel NSClassFromString(@"QLPreviewPanel") #import "PBQLTextView.h" +#import "GLFileView.h" #define kHistorySelectedDetailIndexKey @"PBHistorySelectedDetailIndex" @@ -493,6 +494,7 @@ } [webHistoryController closeView]; + [fileView closeView]; [super closeView]; } diff --git a/PBGitHistoryView.xib b/PBGitHistoryView.xib index 350a02f..ab66632 100644 --- a/PBGitHistoryView.xib +++ b/PBGitHistoryView.xib @@ -2,9 +2,9 @@ 1050 - 10F569 - 788 - 1038.29 + 10H574 + 804 + 1038.35 461.00 YES @@ -15,8 +15,8 @@ YES - 788 - 788 + 804 + 804 @@ -29,13 +29,8 @@ com.apple.WebKitIBPlugin - YES - - YES - - - YES - + PluginDependencyRecalculationVersion + YES @@ -496,7 +491,7 @@ - d 'de' MMMM 'de' yyyy HH:mm + MMMM d, yyyy h:mm a NO @@ -1982,13 +1977,23 @@ 487 + + + fileView + + + + 488 + YES 0 - + + YES + @@ -2890,7 +2895,7 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.WebKitIBPlugin - {{2069, 399}, {955, 434}} + {{1559, 241}, {955, 434}} com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -2928,7 +2933,7 @@ - 487 + 488 @@ -3267,6 +3272,7 @@ commitController commitList fileBrowser + fileView historySplitView localRemoteBranchesFilterItem mergeButton @@ -3288,6 +3294,7 @@ NSArrayController PBCommitList NSOutlineView + GLFileView PBCollapsibleSplitView NSButton NSButton @@ -3312,6 +3319,7 @@ commitController commitList fileBrowser + fileView historySplitView localRemoteBranchesFilterItem mergeButton @@ -3348,6 +3356,10 @@ fileBrowser NSOutlineView + + fileView + GLFileView + historySplitView PBCollapsibleSplitView