From a03401dd51cccd5c8ea191016f7cc149143fb7bd Mon Sep 17 00:00:00 2001 From: Pieter de Bie Date: Sat, 20 Jun 2009 21:58:34 +0100 Subject: [PATCH] CommitController: Don't turn of off automatic rearranging In a6b7c0c2a6 (GitCommitController: Also use dictionary lookup for untracked files), we started using a dictionary when updating the index to avoid O(n^2) lookups and make the code cleaner at the same time. Before that change we temporarily stopped tracking the index, so that the controller wasn't fired with hundreds of KVO notifications. in a6b7c0c2a6, we removed the re-tracked, but accidentally kept the untracking portion, which meant that some index changes would not propagate to the controllers. --- PBGitCommitController.m | 1 - 1 file changed, 1 deletion(-) diff --git a/PBGitCommitController.m b/PBGitCommitController.m index d74e2a5..5b29f68 100644 --- a/PBGitCommitController.m +++ b/PBGitCommitController.m @@ -195,7 +195,6 @@ - (void) readOtherFiles:(NSNotification *)notification; { - [unstagedFilesController setAutomaticallyRearrangesObjects:NO]; NSArray *lines = [self linesFromNotification:notification]; NSMutableDictionary *dictionary = [[NSMutableDictionary alloc] initWithCapacity:[lines count]]; // We fake this files status as good as possible.