From bee02b18cf5d8167635deadba78b516aefd42c96 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Berg?= Date: Mon, 5 Apr 2010 22:51:33 +0200 Subject: [PATCH] Add a check for hasPrefix:@"refs/" to isSimpleRef logic in PBGitRevSpecifier. --- PBGitRevSpecifier.m | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/PBGitRevSpecifier.m b/PBGitRevSpecifier.m index 840e8d9..671de10 100644 --- a/PBGitRevSpecifier.m +++ b/PBGitRevSpecifier.m @@ -21,18 +21,23 @@ parameters = params; description = descrip; - if (([parameters count] > 1) || ([parameters count] == 0)) - isSimpleRef = NO; - else { - NSString *param = [parameters objectAtIndex:0]; + if (([parameters count] > 1) || ([parameters count] == 0)) { + isSimpleRef = NO; + } else { + NSString *param = [parameters objectAtIndex:0]; if ([param hasPrefix:@"-"] || [param rangeOfCharacterFromSet:[NSCharacterSet characterSetWithCharactersInString:@"^@{}~:"]].location != NSNotFound || - [param rangeOfString:@".."].location != NSNotFound) - isSimpleRef = NO; - else - isSimpleRef = YES; + [param rangeOfString:@".."].location != NSNotFound) { + isSimpleRef = NO; + } else { + if ([param hasPrefix:@"refs/"]) { + isSimpleRef = YES; + } else { + isSimpleRef = NO; + } + } } - + // NSLog(@"paramters = %@, isSimpleRef = %@", parameters, (isSimpleRef ? @"YES" : @"NO")); return self; }