mirror of
https://github.com/kennethreitz/dive-into-python3.git
synced 2026-06-05 23:10:17 +00:00
check for non-integerness before range
This commit is contained in:
+2
-2
@@ -28,10 +28,10 @@ from_roman_table = {}
|
||||
|
||||
def to_roman(n):
|
||||
'''convert integer to Roman numeral'''
|
||||
if not (0 < n < 5000):
|
||||
raise OutOfRangeError('number out of range (must be 1..4999)')
|
||||
if int(n) != n:
|
||||
raise NotIntegerError('non-integers can not be converted')
|
||||
if not (0 < n < 5000):
|
||||
raise OutOfRangeError('number out of range (must be 1..4999)')
|
||||
return to_roman_table[n]
|
||||
|
||||
def from_roman(s):
|
||||
|
||||
+2
-2
@@ -38,10 +38,10 @@ roman_numeral_pattern = re.compile('''
|
||||
|
||||
def to_roman(n):
|
||||
'''convert integer to Roman numeral'''
|
||||
if not (0 < n < 5000):
|
||||
raise OutOfRangeError('number out of range (must be 1..4999)')
|
||||
if not isinstance(n, int):
|
||||
raise NotIntegerError('non-integers can not be converted')
|
||||
if not (0 < n < 5000):
|
||||
raise OutOfRangeError('number out of range (must be 1..4999)')
|
||||
|
||||
result = ''
|
||||
for numeral, integer in roman_numeral_map:
|
||||
|
||||
Reference in New Issue
Block a user