kennethreitz/dive-into-python3
1
0
Fork 0
mirror of https://github.com/kennethreitz/dive-into-python3.git synced 2026-06-05 23:10:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

check for non-integerness before range

Browse Source
This commit is contained in:
Mark Pilgrim
2010-09-16 21:44:12 -04:00
parent dc45dd3265
commit 76a14e4290
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
refactoring.html
+2 -2
View File
@@ -240,10 +240,10 @@ FAILED (errors=3)</samp></pre>
def to_roman(n):
'''convert integer to Roman numeral'''
<a> if not (0 &lt; n &lt; 5000): <span class=u>&#x2461;</span></a>
raise OutOfRangeError('number out of range (must be 1..4999)')
if not isinstance(n, int):
raise NotIntegerError('non-integers can not be converted')
<a> if not (0 &lt; n &lt; 5000): <span class=u>&#x2461;</span></a>
raise OutOfRangeError('number out of range (must be 1..4999)')
result = ''
for numeral, integer in roman_numeral_map: