From 312b9ca6debb65a6766c4e06dd28daf5ffb1aefb Mon Sep 17 00:00:00 2001 From: Kevin Grinberg Date: Mon, 9 Mar 2020 10:42:44 -0400 Subject: [PATCH] Fix old Django version detection --- CHANGELOG.md | 2 +- bin/steps/pip-install | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7617a30..64263b4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ # Master - Correct ftp to https in vendored file -- Warn for Django 1.11 approaching EOL, provide link to roadmap +- Warn for Django 1.11 approaching EOL, provide link to roadmap [fixed detection] -------------------------------------------------------------------------------- diff --git a/bin/steps/pip-install b/bin/steps/pip-install index 403c3e7..481ffc6 100755 --- a/bin/steps/pip-install +++ b/bin/steps/pip-install @@ -38,10 +38,10 @@ if [ ! "$SKIP_PIP_INSTALL" ]; then mcount "failure.none-version" fi - if grep -q 'django==1.*' requirements.txt; then + if grep -qi '^django==1.*' requirements.txt; then puts-warn "Your Django version is nearing the end of its community support." puts-warn "Upgrade to continue to receive security updates and for the best experience with Django." - puts-warn "For more information, check out https://www.djangoproject.com/weblog/2015/jun/25/roadmap/" + puts-warn "For more information, check out https://www.djangoproject.com/download/#supported-versions" fi if [ ! -f "$BUILD_DIR/.heroku/python/bin/pip" ]; then