From 783c2e2329c19af77a93c7612f4c4988bb80f8f0 Mon Sep 17 00:00:00 2001
From: Casey Faist <caseylfaist@gmail.com>
Date: Tue, 10 Sep 2019 18:35:54 -0700
Subject: [PATCH] ensure and add comments to base python formulas

---
 builds/runtimes/python2 | 35 +++++++++++++++++++++++++++++++++++
 builds/runtimes/python3 |  9 ++++-----
 2 files changed, 39 insertions(+), 5 deletions(-)
 create mode 100644 builds/runtimes/python2

diff --git a/builds/runtimes/python2 b/builds/runtimes/python2
new file mode 100644
index 0000000..5794991
--- /dev/null
+++ b/builds/runtimes/python2
@@ -0,0 +1,35 @@
+#!/usr/bin/env bash
+# Build Path: /app/.heroku/python/
+
+OUT_PREFIX=$1
+BIN_DIR="$(cd "$(dirname "$0")"/../.. || exit; pwd)/bin"
+export BIN_DIR
+
+# Orient ourselves and build download link
+dep_formula=${0#$WORKSPACE_DIR/} # this is the original script, e.g. pypy-5.3.1
+BASE=${dep_formula##*/} # this gives us relative path
+python_version=${BASE^} # this gives us only the filename with version number
+version_number=$(echo "$python_version" | cut -d- -f2) # this returns just X.X.X
+dep_url=https://python.org/ftp/python/${version_number}/${python_version}.tgz
+
+# shellcheck source=bin/utils
+source "$BIN_DIR/steps/sqlite3"
+
+sqlite3_version
+echo "Setting up SQLite3 Headers for $SQLITE3_VERSION"
+sqlite3_install "$OUT_PREFIX" "$SQLITE3_VERSION" 1
+
+echo "Building Python 3..."
+echo "Pulling from source: ${dep_url}"
+
+curl -L "${dep_url}" | tar xz -C "${OUT_PREFIX}"
+mv "${OUT_PREFIX}/${python_version}" src
+cd src
+
+./configure --prefix=$OUT_PREFIX  --enable-unicode=ucs4 --with-ensurepip=no
+make
+make install
+
+# Remove unneeded test directories, similar to the official Docker Python images:
+# https://github.com/docker-library/python
+find "${OUT_PREFIX}" \( -type d -a \( -name test -o -name tests \) \) -exec rm -rf '{}' +
diff --git a/builds/runtimes/python3 b/builds/runtimes/python3
index af93881..79f4421 100755
--- a/builds/runtimes/python3
+++ b/builds/runtimes/python3
@@ -9,12 +9,11 @@ OUT_PREFIX=$1
 BIN_DIR="$(cd "$(dirname "$0")"/../.. || exit; pwd)/bin"
 export BIN_DIR
 
+# Orient ourselves and build download link
 dep_formula=${0#$WORKSPACE_DIR/} # this is the original script, e.g. pypy-5.3.1
-dep_name=$(basename $BASH_SOURCE) # this is us
-
-BASE=${dep_formula##*/}
-python_version=${BASE^}
-version_number=$(echo "$python_version" | cut -d- -f2)
+BASE=${dep_formula##*/} # this gives us relative path
+python_version=${BASE^} # this gives us only the filename with version number
+version_number=$(echo "$python_version" | cut -d- -f2) # this returns just X.X.X
 dep_url=https://python.org/ftp/python/${version_number}/${python_version}.tgz
 
 # shellcheck source=bin/utils