kennethreitz/heroku-buildpack-python
1
0
Fork 0
mirror of https://github.com/kennethreitz/heroku-buildpack-python.git synced 2026-06-05 23:10:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename confusing PYPY_* variables (#1044)

Browse Source 
Since these variables refer to the latest version of PyPy, compared to
the similarly named `PYPY27` and `PYPY36` variables (ie same name except
without the underscore) which refer to the major/minor version only.

The similar names caused me to use the wrong one locally whilst working
on another PR, which was caught by tests but demonstrates why we should
rename them.

Closes @W-7935256@.

[skip changelog]
This commit is contained in:
Ed Morley
2020-08-11 19:31:53 +01:00
committed by GitHub
parent ac29db32f8
commit cba3201ac2
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/steps/python
+4 -4
View File
@@ -64,15 +64,15 @@ if curl --output /dev/null --silent --head --fail "$VENDORED_PYTHON"; then
fi
if [[ "$PYTHON_VERSION" == $PYPY27* ]]; then
# security update note
if [ "$PYTHON_VERSION" != "$PYPY_27" ]; then
puts-warn "$SECURITY_UPDATE_PYPY" "$PYPY_27"
if [ "$PYTHON_VERSION" != "$LATEST_PYPY_27" ]; then
puts-warn "$SECURITY_UPDATE_PYPY" "$LATEST_PYPY_27"
echo " Learn More: https://devcenter.heroku.com/articles/python-runtimes"
fi
fi
if [[ "$PYTHON_VERSION" == $PYPY36* ]]; then
# security update note
if [ "$PYTHON_VERSION" != "$PYPY_36" ]; then
puts-warn "$SECURITY_UPDATE_PYPY" "$PYPY_36"
if [ "$PYTHON_VERSION" != "$LATEST_PYPY_36" ]; then
puts-warn "$SECURITY_UPDATE_PYPY" "$LATEST_PYPY_36"
echo " Learn More: https://devcenter.heroku.com/articles/python-runtimes"
fi
fi