From 0c701de466955e9d52a56a46dda30ddd8c096358 Mon Sep 17 00:00:00 2001 From: Claudio Jolowicz Date: Thu, 22 Aug 2019 13:17:03 +0200 Subject: [PATCH 1/5] Fix typo in command to log pip-diff failure The pip-diff tool from vendor/pip-pop is used to determine stale requirements. When pip-diff encounters an unexpected failure, a count is logged using mcount from heroku/buildpack-stdlib. Due to a typo, mount(8) was invoked instead of mcount, with an invalid argument. --- bin/steps/pip-uninstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/steps/pip-uninstall b/bin/steps/pip-uninstall index 682b2c9..2e1ad8d 100755 --- a/bin/steps/pip-uninstall +++ b/bin/steps/pip-uninstall @@ -13,7 +13,7 @@ if [ ! "$SKIP_PIP_INSTALL" ]; then if ! pip-diff --stale requirements-declared.txt requirements.txt --exclude setuptools pip wheel > .heroku/python/requirements-stale.txt; then - mount "failure.bad-requirements" + mcount "failure.bad-requirements" fi rm -fr requirements-declared.txt From 3fef7caf500b2b945827affd7cac704590d61946 Mon Sep 17 00:00:00 2001 From: schneems Date: Fri, 27 Sep 2019 16:09:19 -0500 Subject: [PATCH 2/5] [changelog skip] Ensure PRs include a Changelog entry The goal of this PR is to add a github action that checks for the presence of a changelog entry. It is better to add entries as a PR is merged instead of having to remember what was merged and generate a changelog at release time. By automating this check, it's one less thing the maintainer has to remember, and it's one less thing a change might be blocked on i.e. "Looks good, but please add a changelog entry". Let me know if you have any questions and Happy Friday! --- .github/workflows/check_changelog.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/workflows/check_changelog.yml diff --git a/.github/workflows/check_changelog.yml b/.github/workflows/check_changelog.yml new file mode 100644 index 0000000..8c8dfcc --- /dev/null +++ b/.github/workflows/check_changelog.yml @@ -0,0 +1,12 @@ +name: Check Changelog + +on: [pull_request] + +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v1 + - name: Check that CHANGELOG is touched + run: | + cat $GITHUB_EVENT_PATH | jq .pull_request.title | grep -i '[((changelog skip)|(ci skip))]' || git diff remotes/origin/${{ github.base_ref }} --name-only | grep CHANGELOG.md From 6e4b43fa1dde25ec9187701cd218ebaee89d965c Mon Sep 17 00:00:00 2001 From: Casey Faist Date: Fri, 27 Sep 2019 14:09:30 -0700 Subject: [PATCH 3/5] add changelog update to retrigger tests --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 76e6fd3..c620740 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ # Master +Typo fixes + -------------------------------------------------------------------------------- # 156 (2019-09-12) From 15ecb76950d7fe60ddaefaf942630fc5e523917a Mon Sep 17 00:00:00 2001 From: Casey Faist Date: Mon, 30 Sep 2019 11:00:27 -0700 Subject: [PATCH 4/5] revert pin bionic packages for heroku-18 --- builds/heroku-18.Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builds/heroku-18.Dockerfile b/builds/heroku-18.Dockerfile index 6428fa6..6288ac0 100644 --- a/builds/heroku-18.Dockerfile +++ b/builds/heroku-18.Dockerfile @@ -7,7 +7,7 @@ ENV WORKSPACE_DIR="/app/builds" \ DEBIAN_FRONTEND=noninteractive \ STACK="heroku-18" -RUN apt-get update && apt-get install --no-install-recommends -y python-pip-whl=9.0.1-2 python-pip=9.0.1-2 python-setuptools python-wheel && rm -rf /var/lib/apt/lists/* +RUN apt-get update && apt-get install -y python-pip && rm -rf /var/lib/apt/lists/* COPY requirements.txt /app/ RUN pip install --disable-pip-version-check --no-cache-dir -r /app/requirements.txt From b2b12d0355ec86160c008802f4f882d506018746 Mon Sep 17 00:00:00 2001 From: Casey Faist Date: Mon, 30 Sep 2019 11:01:49 -0700 Subject: [PATCH 5/5] add changelog update --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 76e6fd3..b26961e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ # Master +- Unpin Heroku-18 binary build deps + -------------------------------------------------------------------------------- # 156 (2019-09-12)