mirror of
https://github.com/kennethreitz/heroku-buildpack-python.git
synced 2026-06-05 23:10:16 +00:00
Update the Python 3.4.10 build script to use the correct Python version (#1048)
The existing Python 3.4.10 archive actually contained Python 3.7.2, since the version in the source URL was not updated when the file was created in #813. The build formula now uses the shared build script approach like all of the other build scripts, which ensures the version can never get out of sync (since it's extracted from the formula filename). The build for Heroku-18 failed to compile `_ssl` properly (even though the build exited zero) since Python 3.4.10 is old enough it doesn't work well with libssl1.1. Installing `libssl1.0-dev` in the build image locally resolved the issue - however we don't want to use that in the future for newer Python, so I've not updated the `heroku-18.Dockerfile`. In addition, with the rebuilt archives the tests now pass on Cedar-14, so no longer need to be marked as failing. Closes @W-7947035@.
This commit is contained in:
+2
-17
@@ -54,29 +54,14 @@ testPython3_4() {
|
||||
assertCaptured $LATEST_34
|
||||
assertNotCaptured "security update"
|
||||
assertCaptured "Installing pip 19.1.1, setuptools 43.0.0 and wheel 0.33.6"
|
||||
# if cedar 14 and legacy binaries, fail. if cedar 14 and staging, succeed.
|
||||
if [[ ! -n $USE_STAGING_BINARIES ]] && [[ $STACK == "cedar-14" ]]; then
|
||||
assertCapturedError
|
||||
# if heroku 18 and legacy binaries, succeed. if heroku 18 and staging, fail.
|
||||
elif [[ -n $USE_STAGING_BINARIES ]] && [[ $STACK == "heroku-18" ]]; then
|
||||
assertCapturedError
|
||||
else
|
||||
# all else succeed
|
||||
assertCapturedSuccess
|
||||
fi
|
||||
assertCapturedSuccess
|
||||
}
|
||||
|
||||
testPython3_4_warn() {
|
||||
compile "python3_4_warn"
|
||||
assertCaptured "python-3.4.9"
|
||||
assertCaptured "security update!"
|
||||
# if heroku 18 and legacy binaries, succeed. if heroku 18 and staging, fail.
|
||||
if [[ -n $USE_STAGING_BINARIES ]] && [[ $STACK == "heroku-18" ]]; then
|
||||
assertCapturedError
|
||||
else
|
||||
# all else succeed
|
||||
assertCapturedSuccess
|
||||
fi
|
||||
assertCapturedSuccess
|
||||
}
|
||||
|
||||
testPython3_4_fail() {
|
||||
|
||||
Reference in New Issue
Block a user