Fix the security update version check message for PyPy (#1040)

Previously if an app was using an older version of PyPy, the buildpack
would show a confusing "Could not find that version" message (even
though the version was found), when it really meant to warn about there
being a newer release available.

It looks like the version check messages were perhaps copied and pasted
from something else, but the message wording not updated at the time.

I've also added tests since there were none for this feature.

Fixes #1004.
Closes @W-7918745@.
This commit is contained in:
Ed Morley
2020-08-11 19:15:16 +01:00
committed by GitHub
parent bc7e34dbad
commit f508bd538d
9 changed files with 28 additions and 6 deletions
+1 -1
View File
@@ -1 +1 @@
pypy2.7-7.2.0
pypy2.7-7.3.1
View File
+1
View File
@@ -0,0 +1 @@
pypy2.7-7.2.0
+1 -1
View File
@@ -1 +1 @@
pypy3.6-7.2.0
pypy3.6-7.3.1
View File
+1
View File
@@ -0,0 +1 @@
pypy3.6-7.2.0
+20 -2
View File
@@ -197,24 +197,42 @@ testPython3_8_fail() {
testPypy3_6() {
compile "pypy3_6"
assertCaptured "Installing pypy"
assertNotCaptured "security update"
assertCaptured "$PYPY_36"
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
assertCapturedSuccess
}
testPypy3_6_warn() {
compile "pypy3_6_warn"
if [[ $STACK = "cedar-14" ]]; then
assertCapturedError
else
assertCaptured "Installing pypy"
assertCaptured "security update!"
assertCaptured "$PYPY_36"
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
assertCapturedSuccess
fi
}
testPypy2_7() {
compile "pypy2_7"
assertCaptured "Installing pypy"
assertNotCaptured "security update"
assertCaptured "$PYPY_27"
assertCaptured "Installing pip 20.1.1, setuptools 44.1.1 and wheel 0.34.2"
assertCapturedSuccess
}
testPypy2_7_warn() {
compile "pypy2_7_warn"
if [[ $STACK = "cedar-14" ]]; then
assertCapturedError
else
assertCaptured "Installing pypy"
assertCaptured "security update!"
assertCaptured "$PYPY_27"
assertCaptured "Installing pip 20.1.1, setuptools 44.1.1 and wheel 0.34.2"
assertCapturedSuccess
fi
}