4 Commits

Author	SHA1	Message	Date
Ed Morley	d9b1c73f63	Improve the Check Changelog GitHub action (#1009) ... It now: * uses the PR body rather than title for controlling whether to skip the check, to reduce PR title noise * supports `[skip changelog]` in addition to `[changelog skip]`, since I could never remember which way around the words should go * uses the GitHub `if` syntax with the `github` event context, which simplifies the implementation, means the action doesn't run steps like git checkout when it's going to be skipped anyway, and gives the status check the grey icon when skipped instead of the green check * renames the inner job from `build` to `check` The file has also been style-formatted using Prettier. See: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request Example failing (since no skip syntax used): https://github.com/heroku/heroku-buildpack-python/pull/1009/checks?check_run_id=906015118 Example skipped (since skip syntax used): https://github.com/heroku/heroku-buildpack-python/pull/1009/checks?check_run_id=906022522	2020-07-24 10:34:27 +01:00
Richard Schneeman	d3a60b21fe	[changelog skip] Fix PR edit check (#974) ... Previously when a PR title was edited, the "check for changelog" script would not fire. This means if someone edited it to add a "[changelog skip]" that the check would still show to be failing. This PR adds additional triggers for the check so that when the PR is edited, the check will re-run.	2020-05-12 09:57:33 -05:00
schneems	3096299184	[changelog skip] Fix Escaping in Changelog Script ... The previous PR had a bug where the REGEX for grep was not properly escaped. This PR fixes that issue.	2019-10-01 10:28:18 -05:00
schneems	3fef7caf50	[changelog skip] Ensure PRs include a Changelog entry ... The goal of this PR is to add a github action that checks for the presence of a changelog entry. It is better to add entries as a PR is merged instead of having to remember what was merged and generate a changelog at release time. By automating this check, it's one less thing the maintainer has to remember, and it's one less thing a change might be blocked on i.e. "Looks good, but please add a changelog entry". Let me know if you have any questions and Happy Friday!	2019-09-27 16:09:19 -05:00