df7f8f3507
Skip vendoring libffi/libmemcached on Heroku-16 ( #465 )
...
* Add a test for the cryptography (cffi) compile step
Since it's currently untested.
* Skip vendoring libffi/libmemcached on Heroku-16
Unlike for Cedar-14, Heroku-16 comes with these packages pre-installed:
https://github.com/heroku/stack-images/blob/5a341970cfc1f201014262ad64c3b3e47514f663/heroku-16/installed-packages.txt#L111
https://github.com/heroku/stack-images/blob/5a341970cfc1f201014262ad64c3b3e47514f663/heroku-16/installed-packages.txt#L172
As such the build scripts had already been made a no-op on Heroku-16:
https://github.com/heroku/heroku-buildpack-python/blob/fedae5ceda5a42f594012f911c3808dd5dc6fd9e/builds/libraries/vendor/libffi#L6-L9
https://github.com/heroku/heroku-buildpack-python/blob/fedae5ceda5a42f594012f911c3808dd5dc6fd9e/builds/libraries/vendor/libmemcache#L6-L9
...meaning the Heroku-16 archives for them on S3 contain zero files.
However until now, the buildpack was still unnecessarily downloading
and extracting these empty archives - and not just on the first compile
(like on cedar-14), but every compile since the directory check will
never succeed.
2017-09-08 11:27:46 -04:00
4212e06309
NLTK support: Fix passing of multiple corpora identifiers ( #460 )
...
* NLTK support: Update test to use multiple corpora
So that the incorrect handling of multiple IDs seen in #444 would
have been caught.
Also switches to some of the smaller corpora, to reduce time spent
downloading during tests (see sizes on http://www.nltk.org/nltk_data/ ).
* NLTK support: Fix passing of multiple corpora identifiers
As part of fixing the shellcheck warnigns in #438 , double quotes had
been placed around `$nltk_packages` passed to the `nltk.downloader`,
which causes multiple identifiers to be treated as though it were just
one identifier that contains spaces.
The docs for the shellcheck warning in question recommend using arrays
if the intended behaviour really is to split on spaces:
https://github.com/koalaman/shellcheck/wiki/SC2086#exceptions
As such, `readarray` has been used, which is present in bash >=4.
The `[*]` array form is used in the log message, to prevent shellcheck
warning SC2145, whereas `[@]` is used when passed to `nltk.downloader`
to ensure the array elements are unpacked as required.
Note: Both before and after this fix, using anything but unix line
endings in `nltk.txt` will also cause breakage.
2017-09-05 09:32:04 -04:00
c029e44dc8
Improve UX when clearing cache due to the stack changing ( #442 )
...
* Test that the cache is invalidated when the stack changes
* Improve UX when clearing cache due to the stack changing
Now outputs a message informing that the cache was cleared, and
clears the cache first to avoid a redundant message about removing
an old Python version.
2017-08-07 21:23:23 -04:00
kennethreitz
f74d4db8c5
Shellcheck Compliance ( #438 )
...
* fixed the bug for pypy-5.8.0
* enable shellcheck in makefile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* make compile script shellcheck compatible
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* let's see what this says
* fix pip installation
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck detect script
* shellcheck release
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck test-compile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck warnings/utils
* updated makefile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck collectstatic
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck cryptography
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck eggpath fixes
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck gdal
* shellcheck goes-libs
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck mercurial
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* nltk shellcheck
* shellcheck pip-install
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck pip-uninstall
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck pipenv
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck pylibmc
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* shellcheck python
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* update makefile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* final update to makefile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* fix tests
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* actually fix the tests
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* update pipenv-python-version
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* requested fixes
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* update spellcheck sources
* attempted fix for shell globbing
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* further attempted fix
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* switch nltk styling
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* no more need for temp app for installing pip
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* attempt at staged build for shellcheck
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* attempted fix of travis file
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* reorder travis file
* add shellcheck to install
* make things clearer in travis file
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* better travis file
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* attempt at better travis file
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* better travis file
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-08-03 17:36:23 -04:00
kennethreitz
2512694df9
Geos tests ( #437 )
...
* fixed the bug for pypy-5.8.0
* cleanup makefile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* allow builds to happen when capitalization is used
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* restore behavior
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* make makefile default to heroku-16
* test geos libraries
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-08-02 19:59:44 -04:00
cbb718bb8b
Fix pip uninstall by moving it prior to pip install ( #413 )
...
The pip-uninstall step stopped working when it was moved to after
the pip-install step in f27a84e#397 , however that
PR was reverted in #404 .
Adds a test to hopefully catch any future regressions :-)
Fixes #393 .
2017-06-14 17:15:52 -04:00
kennethreitz
db95cdd3f3
new pylibmc test ( #408 )
2017-06-05 13:47:48 -04:00
kennethreitz
65648fb7a8
fix tests
2017-03-16 12:44:36 -04:00
kennethreitz
45b0d18532
fix tests further
2017-03-16 12:29:07 -04:00
kennethreitz
c19f0f83ee
fix build
2017-03-15 23:54:59 -04:00
kennethreitz
c3849fb6d3
improvements
2017-03-14 13:36:14 -04:00
kennethreitz
e9108858fc
v100
2017-03-14 11:59:39 -04:00
kennethreitz
8bd209de13
further fix test
2017-03-14 11:28:50 -04:00
kennethreitz
58e9c84347
fix tests
2017-03-14 11:27:18 -04:00
kennethreitz
dcfff15151
cleanups
2017-03-14 11:23:28 -04:00
kennethreitz
9426dc8668
fix test
2017-03-14 10:54:38 -04:00
kennethreitz
858113cf76
tests for newlines
2017-03-14 10:49:49 -04:00
kennethreitz
0fadebf7d8
more tests
2017-03-10 12:37:11 -05:00
kennethreitz
0de749a6a2
updated tests
2017-03-10 11:22:07 -05:00
kennethreitz
09b7e44841
fix tests
2017-03-08 16:57:33 -05:00
kennethreitz
607dcfda07
no pipenv test (for now)
2017-03-08 08:31:09 -05:00
kennethreitz
26a0b9678f
no version checking yet
2017-03-07 12:09:09 -05:00
e58e5d2b74
more tests
2017-03-07 11:58:53 -05:00
kennethreitz
012cb8a4df
Added more tests
2017-02-01 15:09:49 -05:00
kennethreitz
fab60ae6ab
more tests
2017-01-24 23:16:36 -05:00
kennethreitz
cd52da6155
tell travis to run the tests
2017-01-24 23:16:36 -05:00
Ed Morley
kennethreitz