285ca2b73d
reword warning, add doc link
2018-09-05 16:21:42 -04:00
5e4667686a
add case for older python 3 install attempts
2018-09-05 16:21:42 -04:00
f9621add42
Update indentation levels and messaging
...
Fix indentation levels
more helpful messages about supported versions
2018-09-05 16:21:42 -04:00
221722fb27
setup libsqlite3-dev and sqlite3 binary to match stack's libsqlite3-0
...
With inspiration from @KevinBrolly, this patch uses the stack image
SQLite3 package but also still providing the dev headers and binary that
users may still be using today. The benefit is that we won't need to
rebuild all the python binaries for this to take affect. We can just
stop shipping SQLite3 from future binaries. In addition, we don't need
to worry about what version and when to update SQLite3 and maintaining
the packages ourselves.
This also includes updates to Python 2.7.15 and Python 3.6.6 so they can
rebuilt with the stack image dev headers instead of building our own
vendored SQLite3.
2018-07-26 16:49:23 -05:00
731876d6e8
Be clearer in our warnings about which Py3 we mean
2018-07-10 07:38:31 -05:00
179e6287b1
Prevent Python 3.7 from being unsupported
...
Python 3.7.0 is supported but not preferred given how new it is. As a
result, we don't want it to be the default, but we also don't want users
to be confused when upgrading to it.
Closes gh-728
2018-07-06 09:11:26 -05:00
57ec0c38ae
Fix shellcheck linting issues
2018-05-24 14:38:14 +01:00
f1e1df2fa1
Bump pipenv version
2018-05-24 11:37:01 +01:00
df6c8c78af
only need to build libmemcache dev for cedar-14 ( #690 )
2018-05-01 09:17:18 -04:00
kennethreitz
dd0aee7b06
update metrics
2018-04-20 10:16:27 -04:00
kennethreitz
a0275888a2
Pip frozen version ( #683 )
...
* freeze pip version, upon installation
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* use PIP_UPDATE environment variable
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* disable shell checking (for now)
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* --disable-pip-version-check
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-04-17 16:50:01 -04:00
kennethreitz
23400d7862
update pip installation method, to include setuptools
2018-03-20 13:20:49 -04:00
kennethreitz
877aa79e19
cleanup pip upgrade step
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-19 10:56:59 -04:00
c732097d17
Output pipenv version in steps ( #662 )
...
* Since pipenv is being pinned now, output pinned version in steps
Signed-off-by: Yury V. Zaytsev <yury.zaytsev@moneymeets.com >
* Update README.md example output to match new reality
Signed-off-by: Yury V. Zaytsev <yury.zaytsev@moneymeets.com >
* Update pipenv
2018-03-19 07:15:37 -04:00
kennethreitz
00947abe7a
collectstatic metrics ( #660 )
2018-03-14 13:06:56 -04:00
kennethreitz
d0c98aa577
Update pipenv
2018-03-14 06:57:52 -04:00
kennethreitz
ce30ca052e
pin to pipenv==11.6.1
2018-03-14 06:56:14 -04:00
kennethreitz
f9e54dc3f6
don't skip Pipenv installation if there are git deps ( #656 )
2018-03-13 22:02:29 -04:00
kennethreitz
7d975e74a9
default to user python path for collectstatic runs ( #655 )
...
* default to user python path for collectstatic runs
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* bugfixes
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* fix
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-13 20:59:11 -04:00
kennethreitz
5f8360cba8
Metrics ( #657 )
...
* metrics
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* using pipenv anyway
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* instrument bad failures
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* if not
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-13 20:56:40 -04:00
kennethreitz
05e3d8ccce
fix mercurial step
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-07 11:08:13 -05:00
kennethreitz
fd53d4e1b0
also skip pip install
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-07 10:57:31 -05:00
kennethreitz
329cd6eb7b
don't print extra information
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-07 10:56:49 -05:00
kennethreitz
b6f042b118
fix the problem
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-07 10:54:58 -05:00
kennethreitz
7cbca2f5c5
always use pipenv if it's there
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-07 10:54:09 -05:00
kennethreitz
fe302d8724
don't expect there to be a requirements.txt
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-07 10:51:48 -05:00
kennethreitz
a334672a1a
reorder things
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-07 10:48:22 -05:00
kennethreitz
7b26f0df44
set -e
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-07 10:38:56 -05:00
kennethreitz
96df073bdf
cleanup
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-06 16:06:12 -05:00
kennethreitz
c373e80c12
remove cryptogrpahy step, as they ship wheels now
...
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-06 16:05:19 -05:00
kennethreitz
97ac451a80
Pipenv uninstall, and other improvements ( #650 )
2018-03-06 15:44:50 -05:00
kennethreitz
df083fd3b8
Update pipenv-python-version to latest python 3.6 ( #644 )
...
* Update pipenv-python-version
* use latest versions in pipenv script
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* Update pipenv-python-version
* 3.6.4
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2018-03-02 18:38:21 -05:00
2e1638a1b0
Fix PYTHONPATH is not set when running collectstatic ( #637 )
...
* Fix PYTHONPATH is not set when running collectstatic
* update changelog
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* Update CHANGELOG.md
2018-03-02 09:04:00 -05:00
e15f68944a
feat: allow stack url overrides using BUILDPACK_VENDOR_URL env var ( #643 )
...
This is useful if you'd like to customize python binaries without forking the entire buildpack.
Similar functionality was implemented in https://github.com/heroku/heroku-buildpack-ruby/pull/238
2018-03-02 07:15:23 -05:00
9468ec2630
Add support for PIP_EXTRA_INDEX_URL ( #639 )
...
* Add support for PIP_EXTRA_INDEX_URL
* Add support for PIP_EXTRA_INDEX_URL for Pipenv
2018-02-17 05:58:40 -06:00
kennethreitz
500daaf6fc
Pipenv development dependencies (ci) ( #633 )
...
* initial stab at pipenv --dev support
* test installation output
* locale fix
* refactor
* fix typo
* fix typo
* ellipsis
* polish
2018-01-16 13:36:01 -05:00
kennethreitz
a2c3aaf817
Mcount pipenv and pip ( #492 )
...
* mcount pipenv
* more mcount for pip
* shellcheck compliance
* fix typo
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-12-18 12:49:11 -05:00
17dd42113f
Update default python to 3.6.3 ( #480 )
2017-11-21 19:11:45 -05:00
f767a73515
Fix #398 -- Set explict GDAL and GEOS location ( #478 )
...
Set GDAL and GEOS library locaiton explicitly in environment
variables:
* GDAL_LIBRARY_PATH "/app/.heroku/vendor/lib/libgdal.so"
* GEOS_LIBRARY_PATH "/app/.heroku/vendor/lib/libgeos_c.so"
Django has to settings with the same name. The setup now works as
described here:
https://devcenter.heroku.com/articles/postgis#geodjango-setup
2017-11-15 16:57:39 -05:00
kennethreitz
25c5762cb9
pipenv --deploy ( #476 )
...
* fixed the bug for pypy-5.8.0
* changelog
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* python 2.7.14
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* pipfile > requirements.txt
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* check for python_full_version too
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* 2.7.14
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* warn when using an older version of python
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* requirements for anaconda buildpack
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* remove hashes for conda buildpack
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* improvements to pipenv python version detection
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* echo not puts
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try this
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* learn more
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* there we go
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* cleanups
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* cleanups
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* cleanups
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* unsupported
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* consistiency
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* be more specific
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* capitalize Pipfile.lock
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* attempt to force color
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try this
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try this
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* interactive
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* interactive
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* diagnose
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try without -l
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* confirmed env working
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* just -c
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* use latest, to debug
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* no more bash
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try …
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* don't use the git version of pipenv
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* next version
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* 2.7.14
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* comment out force color bits
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* readme
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* more tests
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* more tests
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* ellipsis
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* pipenv --deploy
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* full version lockfile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-09-26 17:41:51 -04:00
kennethreitz
ff223597f3
Upgrades 🔝 ( #475 )
...
* fixed the bug for pypy-5.8.0
* changelog
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* python 2.7.14
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* pipfile > requirements.txt
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* check for python_full_version too
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* 2.7.14
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* warn when using an older version of python
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* requirements for anaconda buildpack
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* remove hashes for conda buildpack
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* improvements to pipenv python version detection
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* echo not puts
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try this
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* learn more
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* there we go
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* cleanups
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* cleanups
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* cleanups
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* unsupported
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* consistiency
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* be more specific
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* capitalize Pipfile.lock
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* attempt to force color
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try this
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try this
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* interactive
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* interactive
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* diagnose
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try without -l
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* confirmed env working
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* just -c
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* use latest, to debug
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* no more bash
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try …
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* don't use the git version of pipenv
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* next version
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* 2.7.14
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* comment out force color bits
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* readme
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* more tests
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* more tests
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* ellipsis
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-09-26 11:42:14 -04:00
kennethreitz
50950c59df
Pipenv improvements ( #474 )
...
* improvements to pipenv
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* capitalize
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-09-24 23:18:22 -04:00
kennethreitz
17f992a106
Improvements ( #471 )
...
* only do this on heroku-16
* history
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* code comment
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-09-08 12:02:03 -04:00
002780c2d9
Adding step to copy libjasper to vendor lib directory so that libgdal will load ( #449 )
2017-09-08 11:43:28 -04:00
df7f8f3507
Skip vendoring libffi/libmemcached on Heroku-16 ( #465 )
...
* Add a test for the cryptography (cffi) compile step
Since it's currently untested.
* Skip vendoring libffi/libmemcached on Heroku-16
Unlike for Cedar-14, Heroku-16 comes with these packages pre-installed:
https://github.com/heroku/stack-images/blob/5a341970cfc1f201014262ad64c3b3e47514f663/heroku-16/installed-packages.txt#L111
https://github.com/heroku/stack-images/blob/5a341970cfc1f201014262ad64c3b3e47514f663/heroku-16/installed-packages.txt#L172
As such the build scripts had already been made a no-op on Heroku-16:
https://github.com/heroku/heroku-buildpack-python/blob/fedae5ceda5a42f594012f911c3808dd5dc6fd9e/builds/libraries/vendor/libffi#L6-L9
https://github.com/heroku/heroku-buildpack-python/blob/fedae5ceda5a42f594012f911c3808dd5dc6fd9e/builds/libraries/vendor/libmemcache#L6-L9
...meaning the Heroku-16 archives for them on S3 contain zero files.
However until now, the buildpack was still unnecessarily downloading
and extracting these empty archives - and not just on the first compile
(like on cedar-14), but every compile since the directory check will
never succeed.
2017-09-08 11:27:46 -04:00
kennethreitz
d4b8c2aeda
Undo sub_env for pip install, it was a terrible idea ( #467 )
...
* fixed the bug for pypy-5.8.0
* update changelog
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* blacklist for old apps
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* only blacklist pythonhome/path
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* updated changelog
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* be more agressive with blacklisting
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* sub_env was a terrible idea
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* changelog update
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-09-05 11:11:59 -04:00
kennethreitz
f86e8079b6
Blacklist for old apps ( #466 )
...
* fixed the bug for pypy-5.8.0
* update changelog
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* blacklist for old apps
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* only blacklist pythonhome/path
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* updated changelog
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-09-05 10:44:08 -04:00
4212e06309
NLTK support: Fix passing of multiple corpora identifiers ( #460 )
...
* NLTK support: Update test to use multiple corpora
So that the incorrect handling of multiple IDs seen in #444 would
have been caught.
Also switches to some of the smaller corpora, to reduce time spent
downloading during tests (see sizes on http://www.nltk.org/nltk_data/ ).
* NLTK support: Fix passing of multiple corpora identifiers
As part of fixing the shellcheck warnigns in #438 , double quotes had
been placed around `$nltk_packages` passed to the `nltk.downloader`,
which causes multiple identifiers to be treated as though it were just
one identifier that contains spaces.
The docs for the shellcheck warning in question recommend using arrays
if the intended behaviour really is to split on spaces:
https://github.com/koalaman/shellcheck/wiki/SC2086#exceptions
As such, `readarray` has been used, which is present in bash >=4.
The `[*]` array form is used in the log message, to prevent shellcheck
warning SC2145, whereas `[@]` is used when passed to `nltk.downloader`
to ensure the array elements are unpacked as required.
Note: Both before and after this fix, using anything but unix line
endings in `nltk.txt` will also cause breakage.
2017-09-05 09:32:04 -04:00
kennethreitz
4723abb896
Pipenv Updates ( #458 )
...
* fixed the bug for pypy-5.8.0
* update pipenv support
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-08-31 13:18:26 -04:00
kennethreitz
155b5eecb9
Grep bug fix ( #456 )
...
* fixed the bug for pypy-5.8.0
* changelog entry
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* use std-lib sub-env
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* let's see if this cleans things up
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* try v7 of stdlib
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* use new sub_env
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* set_env
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* set_default_env
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* v8 of stdlib
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* v112
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* oops (merge bug)
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* final merge error resolve
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
* final final fix for merge conflict
Signed-off-by: Kenneth Reitz <me@kennethreitz.org >
2017-08-28 13:41:32 -04:00
Casey Faist
kennethreitz