Compare commits

...

107 Commits

Author SHA1 Message Date
Ed Morley a165deadfb Release v175 (#1032) 2020-08-05 09:12:16 +01:00
Ed Morley b64897a0b7 Fix inconsistent formatting in CHANGELOG.md (#1031)
- Switches releases to always using H2 (`##`) rather than a mixture of
  H1s (meaning multiple H1s in the same document) and H2s.
- Always refers to the versions as `vNNN` rather than sometimes without
  the `v` prefix.
- Other formatting and typo fixes.

@W-7905079@
2020-08-03 20:18:18 +01:00
Ed Morley fc6698e597 Update pip to 20.1.1 (#1030)
Updates pip from 20.0.2 to 20.1.1 for Python 2.7 and Python 3.5+:
https://pip.pypa.io/en/stable/news/#id40

The version used for Python 3.4 remains unchanged at 19.1.1, since it's
the last version of pip that supports it.

Pip has been updated to 20.1.1 rather than the recently released 20.2,
since the latter has a few regressions and even though these will be
fixed shortly in 20.2.1, we should let the changes soak for longer
before picking them up.

The `PIP_NO_PYTHON_VERSION_WARNING` environment variable has been set
(equivalent to passing `--no-python-version-warning`) to prevent the
Python 2.7 EOL warnings added in pip 20.1 from spamming the build log:
https://github.com/pypa/pip/blob/20.1.1/src/pip/_internal/cli/base_command.py#L139-L154

This was set via environment variable rather than CLI flag, since:
* otherwise we'd have to pass it to every pip invocation
* older pip (such as the 19.1.1 used by Python 3.4) doesn't support this
  option and would error out due to an unknown CLI flag being passed,
  unless we added conditional flags throughout.

The new pip wheel was uploaded to S3 using:

```
$ pip download --no-cache pip==20.1.1
Collecting pip==20.1.1
  Downloading pip-20.1.1-py2.py3-none-any.whl (1.5 MB)
  Saved ./pip-20.1.1-py2.py3-none-any.whl
Successfully downloaded pip

$ aws s3 sync . s3://lang-python/common/ --exclude "*" --include "*.whl" --acl public-read --dryrun
(dryrun) upload: ./pip-20.1.1-py2.py3-none-any.whl to s3://lang-python/common/pip-20.1.1-py2.py3-none-any.whl

$ aws s3 sync . s3://lang-python/common/ --exclude "*" --include "*.whl" --acl public-read
upload: ./pip-20.1.1-py2.py3-none-any.whl to s3://lang-python/common/pip-20.1.1-py2.py3-none-any.whl
```

Fixes #1005.
@W-7659489@
2020-08-03 19:45:41 +01:00
Ed Morley 6fa6feb75d Update setuptools (#1024)
Upgrades setuptools from 39.0.1 to:
- 44.1.1 for Python 2.7 (since it's the last supported version)
- 43.0.0 for Python 3.4 (since it's the last supported version)
- 47.1.1 for Python 3.5+ (since we can't use 47.2.0+ until #1006 fixed)

https://setuptools.readthedocs.io/en/latest/history.html#v47-1-1

Fixes #949.
Closes #973.
2020-08-03 18:36:01 +01:00
Ed Morley 81874dad47 Replace 'master' branch references with 'main' (#1029)
For #1028.
2020-08-03 17:31:08 +01:00
Ed Morley d74880b322 Release v174 (#1023) 2020-07-30 09:15:44 +01:00
Ed Morley 00e70fffc9 Correctly handle failed pip/setuptools/wheel installs (#1007)
They are now displayed in the build output (instead of being sent to
`/dev/null`) and fail the build early instead of failing later in
`bin/steps/pip-install`.

Fixes #1002.
2020-07-29 19:11:35 +01:00
Ed Morley 60f2fac8e1 Disable pip's version check + cache when installing pip/setuptools/wheel (#1007)
Since the version check is redundant given we control/choose the version.

The pip cache is redundant since we instead cache site-packages. The pip
cache also ends up in `/app` so isn't included in the build cache anyway.
2020-07-29 19:11:35 +01:00
Ed Morley 405c7651ea Install pip using itself rather than get-pip.py (#1007)
`get-pip.py` is no longer used, since:
- It uses `--force-reinstall`, which is unnecessary here and slows down
  repeat builds (given we call pip install every time now). Trying to
  work around this by using `get-pip.py` only for the initial install,
  and real pip for subsequent updates would mean we lose protection
  against cached broken installs, plus significantly increase the
  version combinations test matrix.
- It means downloading pip twice (once embedded in `get-pip.py`, and
  again during the install, since `get-pip.py` can't install the
  embedded version directly).
- We would still have to manage several versions of `get-pip.py`, to
  support older Pythons (once we upgrade to newer pip).

We don't use `ensurepip` since:
- not all of the previously generated Python runtimes on S3 include it.
- we would still have to upgrade pip/setuptools afterwards.
- the versions of pip/setuptools bundled with ensurepip differ greatly
  depending on Python version, and we could easily start using a CLI
  flag for the first pip install before upgrade that isn't supported on
  all versions, without even knowing it (unless we test against hundreds
  of Python archives).

Instead we install pip using itself in wheel form. See:
https://github.com/pypa/pip/issues/2351#issuecomment-69994524

The new pip wheel assets on S3 were generated using:

```
$ pip download --no-cache pip==19.1.1
Collecting pip==19.1.1
  Downloading pip-19.1.1-py2.py3-none-any.whl (1.4 MB)
  Saved ./pip-19.1.1-py2.py3-none-any.whl
Successfully downloaded pip

$ pip download --no-cache pip==20.0.2
Collecting pip==20.0.2
  Downloading pip-20.0.2-py2.py3-none-any.whl (1.4 MB)
  Saved ./pip-20.0.2-py2.py3-none-any.whl
Successfully downloaded pip

$ aws s3 sync . s3://lang-python/common/ --exclude "*" --include "*.whl" --acl public-read --dryrun
(dryrun) upload: ./pip-19.1.1-py2.py3-none-any.whl to s3://lang-python/common/pip-19.1.1-py2.py3-none-any.whl
(dryrun) upload: ./pip-20.0.2-py2.py3-none-any.whl to s3://lang-python/common/pip-20.0.2-py2.py3-none-any.whl

$ aws s3 sync . s3://lang-python/common/ --exclude "*" --include "*.whl" --acl public-read
upload: ./pip-19.1.1-py2.py3-none-any.whl to s3://lang-python/common/pip-19.1.1-py2.py3-none-any.whl
upload: ./pip-20.0.2-py2.py3-none-any.whl to s3://lang-python/common/pip-20.0.2-py2.py3-none-any.whl
```
2020-07-29 19:11:35 +01:00
Ed Morley 7279ddded8 Always check/adjust the installed versions of setuptools/wheel (#1007)
Previously the pip/setuptools/wheel install step was skipped so long
as Python hadn't just been clean installed (ie so long as not a new app,
emptied cache, Python upgrade, stack change) and pip was the expected
version.

This meant that setuptool/wheel could be the wrong version (or even just
not installed at all), and this would not be corrected.

Now, we now use pip itself to determine whether the installed packages
are up to date, since parsing pip's output is fragile (eg #1003) and
would be tedious given there would be three packages to check.

Unfortunately `get-pip.py` uses `--force-reinstall` which means
performing this step every time is not the no-op it would otherwise be,
but this will be resolved by switching away from `get-pip.py` in the
next commit.

Fixes #1000.
Fixes #1003.
Closes #999.
2020-07-29 19:11:35 +01:00
Ed Morley 0027f23065 Remove redundant site-packages cleanup steps (#1007)
Since `get-pip.py` / pip will automatically detect and remove old
pip/setuptools versions if needed, so removing them manually is both not
necessary and slows down the build in the case where the pip version
changed, but setuptools remained the same.
2020-07-29 19:11:35 +01:00
Ed Morley 2097eab028 Install an explicit version of wheel rather than latest (#1007)
Before:
- if `wheel` was not already installed, then `get-pip.py` would
  automatically install the latest version on PyPI, which is `0.34.2`
  (or `0.33.6` for Python 3.4).
- if `wheel` was already installed, then it was left unchanged
  regardless of the version installed.

Now:
- if `wheel` is not already installed, then the same versions will be
  installed as before, except these versions are pinned and will now not
  change unexpectedly after future `wheel` releases.
- if `wheel` is already installed, then it's upgraded/downgraded to the
  target version as needed.

Partly addresses #1000, though this change only helps builds where the
pip/setuptools/wheel install flow is triggered (currently only new apps
or ones where Python was purged or pip was not the correct version).

Since the wheel version is now known, it's output to the build log to
ease debugging and for parity with pip/setuptools.

The rest of #1000 will be fixed in later commits.
2020-07-29 19:11:35 +01:00
Ed Morley 46581612fc Install pip and setuptools in the same pip invocation (#1007)
`get-pip.py` installs setuptools itself (if it's not already installed):
https://pip.pypa.io/en/stable/installing/#installing-with-get-pip-py
https://github.com/pypa/get-pip/blob/eff16c878c7fd6b688b9b4c4267695cf1a0bf01b/templates/default.py#L152-L153

This means that previously the latest version of setuptools (currently
`49.2.0`) was being installed from PyPI, and then immediately after the
target version (currently `39.0.1`) installed over it.

This added time to the build unnecessarily.

The version of setuptools installed by `get-pip.py` can be overridden
by passing in a version as a normal requirements specifier.

Fixes #1001.
2020-07-29 19:11:35 +01:00
Ed Morley 31e8f48db8 Install setuptools from PyPI rather than a vendored copy (#1007)
Since:
* we'll be updating setuptools soon, and newer setuptools has dropped
  support for Python versions this buildpack needs to support. As such
  if we continued to vendor setuptools, we would need to vendor at
  least three different versions.
* we want to try and update setuptools more frequently than we have
  in the past, which will mean more repo bloat from binary churn.
* we're still pinning to a specific version, meaning vendoring doesn't
  have determinism benefits.
* setuptools is only fetched from PyPI for new installs (or where
  versions have changed), so this doesn't increase build time, load on
  PyPI, or reliance on PyPI in the common case.
* setuptools is already being inadvertently installed from PyPI prior to
  being installed from the vendored copy (see #1001), so we're in effect
  already using/depending on PyPI here.
* switching to storing setuptools on S3 wouldn't help reliability as
  much as it would appear at first glance, since the later `pip install`
  of customer dependencies will fail if PyPI is down anyway.
2020-07-29 19:11:35 +01:00
Ed Morley 47a8b4b3b9 Output the installed version of setuptools in the build log (#1007)
Since:
* "explicit is better than implicit"
* we'll soon be upgrading setuptools, and debugging breakage caused by
  upgrades will be easier if versions are visible in the build log
2020-07-29 19:11:35 +01:00
Ed Morley 4080587538 Move Pip version handling to bin/steps/python (#1007)
And use the `$PYTHON_VERSION` calculated in `bin/steps/python` instead
of re-implementing the Python version handling.
2020-07-29 19:11:35 +01:00
Ed Morley 157ce25694 Output the installed version of pip in the build log (#1007)
Since:
* "explicit is better than implicit"
* we'll soon be upgrading pip, and debugging breakage caused by upgrades
  will be easier if versions are visible in the build log

Closes #939.
2020-07-29 19:11:35 +01:00
Ed Morley e7c7dfdb26 Reduce the number of env vars exposed to subprocess (#1011)
The following env vars are no longer exposed to subprocesses run by the
buildpack (such as the `bin/pre_compile` and `bin/post_compile` hooks):

* `BPLOG_PREFIX`
* `CACHED_PYTHON_STACK`
* `DEFAULT_PYTHON_STACK`
* `DEFAULT_PYTHON_VERSION`
* `LATEST_27`
* `LATEST_34`
* `LATEST_35`
* `LATEST_36`
* `LATEST_37`
* `LATEST_38`
* `PIP_UPDATE`
* `PY27`
* `PY34`
* `PY35`
* `PY36`
* `PY37`
* `PYPY_27`
* `PYPY_36`
* `RECOMMENDED_PYTHON_VERSION`
* `WARNINGS_LOG`

There were previously no tests at all for the pre/post-compile hooks,
so I've added some now.

Fixes #1010.
2020-07-28 18:12:08 +01:00
Ed Morley aa8a0f43bb Travis: Reduce end to end testing time (#1022)
This change (along with #1021, which skips an unnecessary docker build)
reduces the wall clock time from ~22 minutes to ~6 minutes. Even with
the additional overhead from increased parallelism, the combined job
duration (~50 minutes) has not increased due to the other time savings.

Changes:

- for the unit tests, each stack is now tested in its own job and so
  tested in parallel
- the use of Travis stages has been removed, since by design it blocks
  later tasks on earlier stages having completed - reducing parallelism
  unnecessarily for this use case
- all jobs except for the Hatchet job now use Travis' `minimal` image,
  and no longer install redundant Ruby + bundler
- the `sudo: {required,false}` references have been removed, since
  Travis no longer supports its non-sudo container infrastructure so
  ignores that option

Fixes #1018.

[skip changelog]
2020-07-28 16:18:45 +01:00
Ed Morley 93a5b4021d Tests: Support running only a subset of the test suites (#1021)
Previously `make test` ran all unit test suites against all stacks, which
would take up to an hour locally. This could be sped up by using one of
the stack-specific targets (such as `make test-heroku-18`), however
there was still no way to only run one of the test suites.

Now `make test` can be controlled more precisely using optional `STACK`
and `TEST_CMD` arguments, eg:

`make test STACK=heroku-16 TEST_CMD=test/versions`

Travis has now been made to use this feature, which unblocks future
Travis speedups (such as splitting the jobs up further in #1018) and
means on Travis the correct Docker image is now used (see #958).

The `tests.sh` script has been removed since it's unused after #839 and
redundant given the make targets.

Fixes #958.
Fixes #1020.
2020-07-28 15:08:20 +01:00
Ed Morley f21e538fde Tests: Delete redundant detect(), compile() and release() (#1017)
Since they are all shadowed by functions with the same name later in
the file.

Fixes #1013.

[skip changelog]
2020-07-24 18:19:01 +01:00
Ed Morley a97da6382f Tests: Run detect/compile/release in a clean environment (#1016)
To prevent external environment variables from leaking into the tests,
which otherwise causes problems trying to write tests for #1011.

Several tests which were relying on this leak had to be fixed, so that
the env vars they were using are set using `ENV_DIR`, as happens in
production.

Fixes #1014.
Fixes #1015.
2020-07-24 18:10:11 +01:00
Ed Morley d9b1c73f63 Improve the Check Changelog GitHub action (#1009)
It now:
* uses the PR body rather than title for controlling whether to skip the
  check, to reduce PR title noise
* supports `[skip changelog]` in addition to `[changelog skip]`, since I
  could never remember which way around the words should go
* uses the GitHub `if` syntax with the `github` event context, which
  simplifies the implementation, means the action doesn't run steps like
  git checkout when it's going to be skipped anyway, and gives the
  status check the grey icon when skipped instead of the green check
* renames the inner job from `build` to `check`

The file has also been style-formatted using Prettier.

See:
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif
https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions
https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request

Example failing (since no skip syntax used):
https://github.com/heroku/heroku-buildpack-python/pull/1009/checks?check_run_id=906015118

Example skipped (since skip syntax used):
https://github.com/heroku/heroku-buildpack-python/pull/1009/checks?check_run_id=906022522
2020-07-24 10:34:27 +01:00
Ed Morley 7209bb4483 Remove get-pip.py reference from NOTICE (#1008)
Since `get-pip.py` is no longer distributed with the buildpack.

Leftover from #840.
2020-07-24 10:10:50 +01:00
Ed Morley 156b07ce2b Release v173 (#998) 2020-07-21 11:31:01 +01:00
Rust Saiargaliev e288ed5a9e Add support for CPython 3.8.5 (#996)
https://www.python.org/downloads/release/python-385/

Release contains a couple of security bugfixes.
Changelog: https://docs.python.org/release/3.8.5/whatsnew/changelog.html#changelog
2020-07-21 11:01:31 +01:00
Ed Morley 181e3395f9 Release v172 (#995) 2020-07-17 12:03:37 +01:00
Denis Cornehl 013ba6b1d9 Add support for Python 3.8.4 (#993) 2020-07-17 10:19:21 +01:00
Ed Morley bce5bf4869 Release v171 (#991) 2020-07-07 19:20:13 +01:00
Denis Cornehl 0fdb62faa9 Add support for Python 3.6.11 and 3.7.8 (#988) 2020-07-07 18:39:44 +01:00
dependabot[bot] 42507a3f9a Bump rake from 12.3.1 to 12.3.3 (#981)
Bumps [rake](https://github.com/ruby/rake) from 12.3.1 to 12.3.3.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](https://github.com/ruby/rake/compare/v12.3.1...v12.3.3)
2020-05-27 14:14:43 +01:00
dependabot[bot] f89ee6750e Bump activesupport from 6.0.2.2 to 6.0.3.1 (#980)
Bumps [activesupport](https://github.com/rails/rails) from 6.0.2.2 to 6.0.3.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.0.3.1/activesupport/CHANGELOG.md)
- [Commits](https://github.com/rails/rails/compare/v6.0.2.2...v6.0.3.1)
2020-05-27 13:42:59 +01:00
Ed Morley 122722f89e v170 (#978) 2020-05-19 15:33:30 +01:00
Ed Morley 8cb379f83b Add support for latest CPython and PyPy versions (#977)
Adds support for:
* CPython 2.7.18, 3.5.9, 3.7.7 and 3.8.3
* PyPy 2.7 and 3.6, version 7.3.1

The binaries will need generating and uploading before CI will pass.

Note: Whilst the build script for CPython 3.8.3 did already exist in the
repository, it appears to have been accidentally created in #920, which
predated the existence of that version of Python - so the binaries do
not exist on S3.

The Heroku-18 Docker image tag has also been unpinned, since the new
libssl version is now available at runtime in all environments, so we
don't need to force building against the older version of the headers.

Fixes W-7582174.
2020-05-19 14:16:59 +01:00
Richard Schneeman d3a60b21fe [changelog skip] Fix PR edit check (#974)
Previously when a PR title was edited, the "check for changelog" script would not fire. This means if someone edited it to add a "[changelog skip]" that the check would still show to be failing. This PR adds additional triggers for the check so that when the PR is edited, the check will re-run.
2020-05-12 09:57:33 -05:00
Richard Schneeman 7e80ea8fbe Update heroku hatchet so master can be specified (#970)
- https://github.com/heroku/hatchet/pull/80
- https://github.com/heroku/heroku-buildpack-python/pull/969#issuecomment-620057594
2020-04-27 15:55:16 -05:00
Joe Kutner c78ffd5ac4 Prevent Hatchet on forked PRs [changelog skip] (#966)
* Update travis conditional for hatchet to check for HEROKU_API_ env vars
[changelog skip]

* remove check to skip hatchet in travis in favor of better travis config
2020-04-27 09:15:38 -05:00
Richard Schneeman a06b536109 Add Hatchet Regression Tests (#969)
I went through all the tests in the Ruby buildpack and cataloged what I think can be generalized between languages to prevent regressions. This PR add tests for these cases:

* Test CI deploys run tests and use the cache [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/f488bd53c7ff0b78e17c2405166cbd4a3af75ee2/spec/hatchet/ci_spec.rb#L36)]
* Test cache for regular deploys is used on repeated deploys (This was already tested on the Python buildpack, I moved it) [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/e34c583c139911d059f5627bb25125707288f053/spec/hatchet/stack_spec.rb#L21-L25)]
    * Test modifying a requirement clears the cache appropriately (This was already tested on the Python buildpack, I moved it)
* Test deploying the getting started guide works [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/424a7245e2da86845a20d58a9482bcf2a00c3a8f/spec/hatchet/getting_started_spec.rb#L5)]
* Test that all paths set by the buildpack are absolute instead of relative [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/249d3c1a4e97068f8fd016f10fa0839709d95658/spec/hatchet/rails5_spec.rb#L68])
* Test upgrading stack invalidates the cache [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/f488bd53c7ff0b78e17c2405166cbd4a3af75ee2/spec/hatchet/stack_spec.rb#L3)]
* Test that builds fail when a bad version is specified [[reference test](https://github.com/heroku/heroku-buildpack-ruby/blob/249d3c1a4e97068f8fd016f10fa0839709d95658/spec/hatchet/ruby_spec.rb#L5)]


In addition to that I've also got a CNB test with `pack-build` with the getting started app, but since python isn't `cnb` capable yet I didn't add one.
2020-04-27 08:26:42 -05:00
Ed Morley dd646998d3 Fix changelog after rebase (#967)
The merge of #910 added three lines to the changelog rather than just one:
https://github.com/heroku/heroku-buildpack-python/commit/932cd257c98e9f56e878134f84a09d7d972bc46e

The original commit before rebase, was:
https://github.com/heroku/heroku-buildpack-python/pull/910/commits/d57d26b2e0348199228312950e55b42bc9de8147

I've also clarified the wording of it and the other unreleased change,
to reduce the chance for confusion as to what's changed, when customers
debug issues.
2020-04-24 10:32:38 +01:00
Ed Morley 484bd44a1e Remove unused libffi build script (#965)
The compile-time cryptography step that used to use the libffi archives
on S3 was removed in 2018:
https://github.com/heroku/heroku-buildpack-python/commit/c373e80c1285260e5adcbc855f54bbeb6999005c

...since the `cryptography` Python package now ships wheels.

The script is also incorrect, since similar to #964 it only skips builds
for Heroku-16, whereas all stacks since Cedar-14 include libffi-dev in
the build image, so don't need it built/uploaded for later vendoring.

Refs W-7485877.
2020-04-24 09:26:03 +01:00
Thomas Mollard 932cd257c9 fix runtime.txt generation when using pipenv (#910)
Co-authored-by: Casey <caseylfaist@gmail.com>
Co-authored-by: Joe Kutner <jpkutner@gmail.com>
2020-04-23 21:30:04 -05:00
Ed Morley 989351467f Prevent building libmemcached on stacks that don't vendor it (#964)
The `libmemcached` package is available in the base stack image for all
stacks newer than `cedar-14`, so at buildpack compile time the vendor
step is skipped for those stacks:
https://github.com/heroku/heroku-buildpack-python/blob/106f2997fa124852a2a35ee8bfa604ad20c47988/bin/steps/pylibmc#L12-L15

As such, it is not necessary to run the libmemcached bob-builder formula
on newer stacks. The conditional has been updated so it correctly handles
heroku-18 and also the upcoming heroku-20.

An exit code of 1 has been used, otherwise `bob upload` will build and
then upload a zero byte archive to S3, which will go unused.

(This is in comparison to bob formulas that are nested, where an exit
code of 0 is actually desirable, since it allows skipping steps.)

Refs W-7485877.

Co-authored-by: Joe Kutner <jpkutner@gmail.com>
2020-04-23 21:23:38 -05:00
Ed Morley d68a7c594c Remove unused Pipfile and Pipfile.lock (#960)
These aren't referenced anywhere in the repository, and contain older
versions of the dependencies than are declared in `requirements.txt`
(which itself is used).

Co-authored-by: Joe Kutner <jpkutner@gmail.com>
2020-04-23 20:40:35 -05:00
Joe Kutner 97f783ce96 Update travis config [changelog skip] (#963)
* Update travis config to only setup hatchet when running hatchet [changelog skip]

Fix a bug in the hatchet tests, and allow previous builds to finish before running the next test

* Add logging when skipping hatchet tests

Only skip hatchet tests on a forked PR

* Build on Travis only for master branch

* Upgrade from trusty to bionic on Travis
2020-04-23 19:55:05 -05:00
Joe Kutner 106f2997fa Add support for Python 3.8 latest version (#955)
* Add support for Python 3.8 latest version

If the pip lock file only specifies `3.8` and no bug fix version, it should use Python LATEST_38.

* Update CHANGELOG.md

* Update changelog

Co-authored-by: Johannes Hoppe <info@johanneshoppe.com>
Co-authored-by: Casey <caseylfaist@gmail.com>
2020-04-23 08:11:53 -05:00
Joe Kutner 373a656272 Update changelog for version 169 (#957) 2020-04-22 16:32:08 -05:00
Joe Kutner 0abc749aff Add a Hatchet test for python 3.8.2 (#956)
* Add a Hatchet test for python 3.8.2

* update changelog

* Update test to match build output

* Fix formatting and a syntax error in tests

* Fix syntax error in hatchet spec
2020-04-22 10:38:16 -05:00
Joe Kutner 60614232da Set Codeowners to languages (#953)
* Set languages as codeowners

* Update changelog
2020-04-21 17:39:56 -05:00
Joe Kutner edb7004a28 Update hatchet tests to support latest version of Python (#952)
* Update hatchet tests to support latest version of Python

* Empty commit to trigger CI
2020-04-21 16:42:56 -05:00
Casey ea350a6694 Bugfix: Caching on subsequent redeploys (#948)
* Don't clear the cache on first app deploy

* Add output for debugging cache behavior

* Debug output of changes, clean up whitespace

* Update hatchet to use latest getting started guide

* Clean up caching output logs

This output was confusing and unhelptul to most users

* Changelog

* Test if we need these lines

* dang fi

* Remove unnecessary code

* Remove confusing output of change

* Update log output

* Update test to match new expected log output

* Update changelog
2020-04-21 15:41:57 -05:00
Casey 027d49eb58 Merge pull request #946 from heroku/releaseprep/168
Release prep: changelog update
2020-04-06 15:22:48 -04:00
Casey 49597f22ca Merge branch 'master' into releaseprep/168 2020-04-06 15:03:32 -04:00
Casey Faist 4bb8f59f2c Prep release changelog update 2020-04-06 13:58:51 -04:00
Casey d4b6b0190d Merge pull request #930 from heroku/kgrinberg/master
Fix old Django version detection
2020-04-06 13:47:51 -04:00
Casey 2c2cbc4653 Merge branch 'master' into kgrinberg/master 2020-04-06 13:23:29 -04:00
Casey d0629cd6ef Merge pull request #895 from heroku/geos-deprecation
Geos deprecation
2020-04-06 13:19:31 -04:00
Casey 398a0fb202 Merge branch 'master' into kgrinberg/master 2020-04-02 15:48:21 -04:00
Casey 5bf80a2270 Merge branch 'master' into geos-deprecation 2020-04-02 15:47:01 -04:00
Casey 61609930c1 Merge pull request #945 from heroku/changelog/bump
More recent changelog update
2020-04-02 15:45:56 -04:00
Casey Faist 0fa27b7b0d More recent changelog update 2020-04-02 13:22:55 -04:00
Casey cc247753e5 Merge branch 'master' into kgrinberg/master 2020-04-02 12:55:25 -04:00
Casey 4da1ca71b5 Merge pull request #940 from heroku/barbeque/patch-1
Barbeque/patch 1
2020-04-02 12:54:34 -04:00
Casey 3d70b2e9ff Merge branch 'master' into barbeque/patch-1 2020-04-02 12:10:22 -04:00
Casey 87e9fb2ccc Merge pull request #944 from heroku/buildlog/fix-cache-output
Remove confusing diff output for cache check
2020-04-02 12:08:49 -04:00
Casey Faist 0d61f83269 Update changelog 2020-04-02 12:08:11 -04:00
Casey Faist e12ad47397 Add missing dev/null for diff output 2020-04-02 11:01:44 -04:00
Casey 307cb13159 Merge branch 'master' into geos-deprecation 2020-03-30 10:08:56 -04:00
Casey 156da405e0 Merge branch 'master' into barbeque/patch-1 2020-03-27 14:55:50 -04:00
Casey ea90db6d13 Add Buildpack-Maintainers as code owners (#938) 2020-03-27 14:47:52 -04:00
Casey Faist 56f7ccc511 Changelog update 2020-03-27 12:50:45 -04:00
Casey a2c72f77f9 Merge branch 'master' into patch-1 2020-03-27 12:49:08 -04:00
Casey 93a5144033 Merge branch 'master' into kgrinberg/master 2020-03-26 19:10:52 -04:00
Casey ac76968c90 Merge branch 'master' into geos-deprecation 2020-03-26 18:44:45 -04:00
Casey 446410f883 Merge pull request #925 from heroku/reproduce/cache-busting
Fix cache clear on redeploy
2020-03-26 18:25:17 -04:00
Casey Faist abd9ffdbff Missed bash linting check 2020-03-26 17:46:54 -04:00
Casey Faist 408a081a08 Remove faulty test, use Hatchet instead 2020-03-26 16:48:37 -04:00
Casey Faist 01b0c1b0db no longer reference unused build var on travis 2020-03-26 12:40:53 -04:00
Casey Faist 2e5fe9f286 Clean up white space 2020-03-26 11:35:26 -04:00
Casey Faist 6b9ffb92d9 Don't update to use pip cache, yet
Also fix whitespace
2020-03-26 11:34:32 -04:00
Casey Faist bf1563eaa0 clean up commented code 2020-03-26 11:32:18 -04:00
Casey Faist dcb04b96c3 clean up todos and commented code 2020-03-26 11:26:03 -04:00
Casey Faist ab79d077da gitignore the scratch shunit test 2020-03-26 11:24:42 -04:00
mike 2b3a90ec0c PR feedback 2020-03-25 20:20:27 -06:00
Casey Faist 48a368ac71 Add test for expected behavior 2020-03-24 14:48:17 -04:00
Casey Faist 3d31167511 Clear test out of helper test stub 2020-03-24 13:43:18 -04:00
Casey Faist 0c2b954a6d Update Changelog 2020-03-24 13:43:18 -04:00
Casey Faist b65f0cfce3 Add Readme to document install steps 2020-03-24 13:43:18 -04:00
Casey Faist a1ef075b53 Add Hatchet test 2020-03-24 13:43:18 -04:00
Casey Faist dee86babe1 Don't skip install if clearing cache 2020-03-24 13:43:18 -04:00
Casey Faist 6a02499140 Update caching logic so new apps don't get logs
actually add changes

Missing fi
2020-03-24 13:43:18 -04:00
Casey Faist b8fd617d9c Bash conditional operaters needed for brackets
Removing brackets also works

Wrong diff check - inverted

Remove uninstall step

Whitespace is hard
2020-03-24 13:43:18 -04:00
Casey Faist f7c422e07d test clear cache and cache requirements.txt 2020-03-24 13:43:18 -04:00
Casey Faist cc6a03aa54 Test result of using pip cache on Heroku 2020-03-24 13:43:18 -04:00
Casey Faist 56ecd1aef7 add quick test case 2020-03-24 13:43:18 -04:00
Casey 4d2e74b411 Merge branch 'master' into patch-1 2020-03-18 10:39:50 -04:00
Casey d8b37dcaf8 Merge branch 'master' into geos-deprecation 2020-03-18 10:29:39 -04:00
Casey Faist a98a87e1bc Remove the lines that bust the cache when we detect that sqlite has changed 2020-03-12 14:20:49 -07:00
Casey Faist 8c9521d806 Create failcase for deploying the same code twice 2020-03-12 13:47:29 -07:00
Kevin Grinberg 312b9ca6de Fix old Django version detection 2020-03-09 11:43:59 -04:00
Casey 4e8831a3a3 Merge branch 'master' into geos-deprecation 2019-12-06 10:11:47 -05:00
Mike c402d37451 Update README python versions to match docs 2019-12-02 10:06:54 -07:00
Casey 563a9c9187 Merge branch 'master' into geos-deprecation 2019-10-24 12:06:08 -07:00
Casey b1e3256128 Merge branch 'master' into geos-deprecation 2019-10-23 14:24:04 -07:00
Casey ac93a57492 Merge branch 'master' into geos-deprecation 2019-10-23 11:42:41 -07:00
Casey Faist 5828fbfe7d check for whole deprecation message 2019-10-23 11:42:01 -07:00
Casey Faist b7d8aa4d7d update changelog 2019-10-22 12:59:18 -07:00
Kevin Brolly a6510f0f77 Added a deprecation warning when using BUILD_WITH_GEO_LIBRARIES or installing pygdal 2019-10-22 12:38:43 -07:00
53 changed files with 647 additions and 430 deletions
+1 -1
View File
@@ -1 +1 @@
* @heroku/languages * @heroku/languages
+13 -8
View File
@@ -1,12 +1,17 @@
name: Check Changelog name: Check Changelog
on: [pull_request] on:
pull_request:
types: [opened, reopened, edited, synchronize]
jobs: jobs:
build: check:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: if: |
- uses: actions/checkout@v1 !contains(github.event.pull_request.body, '[skip changelog]') &&
- name: Check that CHANGELOG is touched !contains(github.event.pull_request.body, '[changelog skip]') &&
run: | !contains(github.event.pull_request.body, '[skip ci]')
cat $GITHUB_EVENT_PATH | jq .pull_request.title | grep -i '\[\(\(changelog skip\)\|\(ci skip\)\)\]' || git diff remotes/origin/${{ github.base_ref }} --name-only | grep CHANGELOG.md steps:
- uses: actions/checkout@v1
- name: Check that CHANGELOG is touched
run: git diff remotes/origin/${{ github.base_ref }} --name-only | grep CHANGELOG.md
+2
View File
@@ -10,3 +10,5 @@ buildpack/*
builds/dockerenv.staging* builds/dockerenv.staging*
builds/dockerenv.production builds/dockerenv.production
test/scratch
+31 -26
View File
@@ -1,39 +1,44 @@
language: ruby language: minimal
dist: trusty dist: bionic
sudo: required branches:
only:
rvm: - main
- 2.4.4
before_script:
- gem install bundler -v 1.16.2
- bundle exec hatchet ci:setup
script: script:
- docker build --pull --tag travis-build-cedar-14 --file $(pwd)/builds/cedar-14.Dockerfile . - make test STACK="${STACK}" TEST_CMD="${TEST_CMD}"
- docker run --rm -e "STACK=cedar-14" -e "USE_STAGING_BINARIES=$USE_STAGING_BINARIES" travis-build-cedar-14 bash $TESTFOLDER
- docker build --pull --tag travis-build-heroku-16 --file $(pwd)/builds/heroku-16.Dockerfile .
- docker run --rm -e "STACK=heroku-16" -e "USE_STAGING_BINARIES=$USE_STAGING_BINARIES" travis-build-heroku-16 bash $TESTFOLDER
- docker build --pull --tag travis-build-heroku-18 --file $(pwd)/builds/heroku-18.Dockerfile .
- docker run --rm -e "STACK=heroku-18" -e "USE_STAGING_BINARIES=$USE_STAGING_BINARIES" travis-build-heroku-18 bash $TESTFOLDER
jobs: jobs:
include: include:
- stage: Bash linting (shellcheck) - name: Bash linting (shellcheck)
sudo: false
script: make check script: make check
- stage: Hatchet Integration - name: Hatchet integration tests
if: branch = master if: env(TRAVIS_PULL_REQUEST_SLUG) = env(TRAVIS_REPO_SLUG)
name: Run Hatchet language: ruby
script: "bundle exec rspec" rvm:
- 2.6.6
before_script:
- gem install bundler -v 1.16.2
script:
- bundle exec hatchet ci:setup
- PARALLEL_SPLIT_TEST_PROCESSES=11 bundle exec parallel_split_test spec/hatchet/
env: env:
matrix: jobs:
- TESTFOLDER=test/run-deps - STACK=cedar-14 TEST_CMD=test/run-deps
- TESTFOLDER=test/run-versions - STACK=cedar-14 TEST_CMD=test/run-versions
- TESTFOLDER=test/run-features - STACK=cedar-14 TEST_CMD=test/run-features
- STACK=heroku-16 TEST_CMD=test/run-deps
- STACK=heroku-16 TEST_CMD=test/run-versions
- STACK=heroku-16 TEST_CMD=test/run-features
- STACK=heroku-18 TEST_CMD=test/run-deps
- STACK=heroku-18 TEST_CMD=test/run-versions
- STACK=heroku-18 TEST_CMD=test/run-features
global: global:
- HATCHET_RETRIES=3 - HATCHET_RETRIES=3
- IS_RUNNING_ON_CI=true - IS_RUNNING_ON_CI=true
- HATCHET_APP_LIMIT=5 - HATCHET_APP_LIMIT=80
- HATCHET_DEPLOY_STRATEGY=git - HATCHET_DEPLOY_STRATEGY=git
- secure: yjtlPE5FbVxTKnjUy/tZUBgSEf4qADD3QOxtgziuid73S0U/1IEXlMGFULsQzIjtlHKmHeywZqpVVEpthIH4RuT7uoX1Pb7SSM/g0T8fT3VoEFbFK1uYl0oZQbUS4Klxv9tPiumj8if3m6ULEGIz1X0wZcMOC0tMLwVCnwmap0E= - secure: yjtlPE5FbVxTKnjUy/tZUBgSEf4qADD3QOxtgziuid73S0U/1IEXlMGFULsQzIjtlHKmHeywZqpVVEpthIH4RuT7uoX1Pb7SSM/g0T8fT3VoEFbFK1uYl0oZQbUS4Klxv9tPiumj8if3m6ULEGIz1X0wZcMOC0tMLwVCnwmap0E=
- secure: ZeFTHWwnpIKE9nAqs88ocmiQh7bKce84lilGm5J23nf3N6V4wNyLwqlkvsM008WGBCaOg9AUx7ZunasT0ANsR5gLP3eV2UUg7ILdRgV2Gy13eNRFheC4PHdN92RqQ3aKoqlIv2K999xlhVjod0NzhkQQXB6PddfQINbuU7ks6As= - secure: ZeFTHWwnpIKE9nAqs88ocmiQh7bKce84lilGm5J23nf3N6V4wNyLwqlkvsM008WGBCaOg9AUx7ZunasT0ANsR5gLP3eV2UUg7ILdRgV2Gy13eNRFheC4PHdN92RqQ3aKoqlIv2K999xlhVjod0NzhkQQXB6PddfQINbuU7ks6As=
+142 -82
View File
@@ -1,44 +1,105 @@
# Python Buildpack Changelog # Python Buildpack Changelog
# Master ## Unreleased
## v175 (2020-08-05)
- Update pip from 20.0.2 to 20.1.1 for Python 2.7 and Python 3.5+ (#1030).
- Update setuptools from 39.0.1 to: (#1024)
- 44.1.1 for Python 2.7
- 43.0.0 for Python 3.4
- 47.1.1 for Python 3.5+
- Switch the `heroku-buildpack-python` repository default branch from `master` to `main` (#1029).
## v174 (2020-07-30)
- For repeat builds, also manage the installed versions of setuptools/wheel, rather than just that of pip (#1007).
- Install an explicit version of wheel rather than the latest release at the time (#1007).
- Output the installed version of pip, setuptools and wheel in the build log (#1007).
- Errors installing pip/setuptools/wheel are now displayed in the build output and fail the build early (#1007).
- Install pip using itself rather than `get-pip.py` (#1007).
- Disable pip's version check + cache when installing pip/setuptools/wheel (#1007).
- Install setuptools from PyPI rather than a vendored copy (#1007).
- Reduce the number of environment variables exposed to `bin/{pre,post}_compile` and other subprocesses (#1011).
## v173 (2020-07-21)
- Python 3.8.5 is now available (CPython).
## v172 (2020-07-17)
- Python 3.8.4 is now available (CPython).
## v171 (2020-07-07)
- Python 3.6.11 and 3.7.8 are now available (CPython).
## v170 (2020-05-19)
- Python 2.7.18, 3.5.9, 3.7.7 and 3.8.3 are now available (CPython).
- PyPy 2.7 and 3.6, version 7.3.1 are now available (Note: PyPy support is in beta).
- Docs: Fix explanation of runtime.txt generation when using pipenv.
- Bugfix: Correctly detect Python version when using a `python_version` of `3.8` in `Pipfile.lock`.
## v169 (2020-04-22)
- Add a Hatchet test for python 3.8.2
- Set Code Owners to @heroku/langauges
- Bugfix: Caching on subsequent redeploys
- Update tests to support latest version of Python
## v168 (2020-04-06)
- Doc: Update Readme with version numbers
- update Code Owners to include the Heroku Buildpack Maintainers team
- Deprecation warning: `BUILD_WITH_GEO_LIBRARIES` is now deprecated. See warning for details.
- Clean up build log output
- Update Python versions in README to match docs
- Django version detection fixed, link updated
## v167 (2020-03-26)
- Add failcase for cache busting
- Bugfix: Clearing pip dependencies
## v166 (2020-03-05)
- Correct ftp to https in vendored file - Correct ftp to https in vendored file
- Warn for Django 1.11 approaching EOL, provide link to roadmap - Warn for Django 1.11 approaching EOL, provide link to roadmap
-------------------------------------------------------------------------------- ## v165 (2020-02-27)
# 165 (2020-02-27)
- Python 3.8.2 now available. - Python 3.8.2 now available.
# 164 (2020-02-20) ## v164 (2020-02-20)
- Update requirements.txt builds to use Pip 20.0.2 - Update requirements.txt builds to use Pip 20.0.2
- Download get-pip.py to tmpdir instead of root dir - Download get-pip.py to tmpdir instead of root dir
# 163 (2019-12-23) ## v163 (2019-12-23)
- New pythons released: - New pythons released:
Python 3.8.1, 3.7.6, 3.6.10 (CPython) Python 3.8.1, 3.7.6, 3.6.10 (CPython)
Beta Release: Pypy 2.7 and 3.6, version 7.2.0 Beta Release: Pypy 2.7 and 3.6, version 7.2.0
# 162 (2019-12-06) ## v162 (2019-12-06)
- Bug fix: fragile sqlite3 install - Bug fix: fragile sqlite3 install
# 161 (2019-12-2) ## v161 (2019-12-2)
- Bug fix: Sqlite3 version bump - Bug fix: Sqlite3 version bump
# 160 (2019-10-23) ## v160 (2019-10-23)
- Bugfix: Pipenv no longer installs twice in CI - Bugfix: Pipenv no longer installs twice in CI
# 159 (2019-10-22) ## v159 (2019-10-22)
- Python 2.7.17 now available on Heroku 18 and 16. - Python 2.7.17 now available on Heroku 18 and 16.
# 158 (2019-10-21) ## v158 (2019-10-21)
- Python 3.7.5 and 3.8.0 now available on Heroku 18 and 16. - Python 3.7.5 and 3.8.0 now available on Heroku 18 and 16.
- Add support for Python 3.8 branch - Add support for Python 3.8 branch
@@ -46,11 +107,11 @@
- Test Improvements - Test Improvements
- Add support for staging binary testing - Add support for staging binary testing
# 157 (2019-09-18) ## v157 (2019-09-18)
- Typo fixes - Typo fixes
# 156 (2019-09-12) ## v156 (2019-09-12)
- Python 3.6.9 and 3.7.4 now available. - Python 3.6.9 and 3.7.4 now available.
@@ -58,125 +119,125 @@
- Build utility and documentation updates - Build utility and documentation updates
- Bump Hatchet tests to point at new default python version. - Bump Hatchet tests to point at new default python version.
# 155 (2019-08-22) ## v155 (2019-08-22)
add docs and make target for heroku-18 bob builds add docs and make target for heroku-18 bob builds
# 154 (2019-07-17) ## v154 (2019-07-17)
Fix python 3.5.7 formula actually building 3.7.2 Fix python 3.5.7 formula actually building 3.7.2
# 153 (2019-06-21) ## v153 (2019-06-21)
Hotfix for broken heroku-16 deploys Hotfix for broken heroku-16 deploys
# 152 (2019-04-04) ## v152 (2019-04-04)
Python 3.7.3 now available. Python 3.7.3 now available.
# 151 (2019-03-21) ## v151 (2019-03-21)
Python 3.5.7 and 3.4.10 now available on all Heroku stacks. Python 3.5.7 and 3.4.10 now available on all Heroku stacks.
# 150 (2019-03-13) ## v150 (2019-03-13)
Python 2.7.16 now available on all Heroku stacks. Python 2.7.16 now available on all Heroku stacks.
# 149 (2019-03-04) ## v149 (2019-03-04)
Hotfix for broken Cedar 14 deploys Hotfix for broken Cedar 14 deploys
# 148 (2019-02-21) ## v148 (2019-02-21)
No user facing changes, improving internal metrics No user facing changes, improving internal metrics
# 147 (2019-02-07) ## v147 (2019-02-07)
Python 3.7.2 and 3.6.8 now available on all Heroku stacks. Python 3.7.2 and 3.6.8 now available on all Heroku stacks.
# 146 (2018-11-11) ## v146 (2018-11-11)
Python 3.7.1, 3.6.7, 3.5.6 and 3.4.9 now available on all Heroku stacks. Python 3.7.1, 3.6.7, 3.5.6 and 3.4.9 now available on all Heroku stacks.
# 145 (2018-11-08) ## v145 (2018-11-08)
Testing and tooling expanded to better support new runtimes Testing and tooling expanded to better support new runtimes
# 144 (2018-10-10) ## v144 (2018-10-10)
Switch to cautious upgrade for Pipenv install to ensure the pinned pip version Switch to cautious upgrade for Pipenv install to ensure the pinned pip version
is used with Pipenv is used with Pipenv
# 143 (2018-10-09) ## v143 (2018-10-09)
Add support for detecting SLUGIFY_USES_TEXT_UNIDECODE, which is required to Add support for detecting `SLUGIFY_USES_TEXT_UNIDECODE`, which is required to
install Apache Airflow version 1.10 or higher. install Apache Airflow version 1.10 or higher.
# 142 (2018-10-08) ## v142 (2018-10-08)
Improvements to Python install messaging Improvements to Python install messaging
# 139, 140, 141 ## v139, 140, 141
No user-facing changes, documenting for version clarity No user-facing changes, documenting for version clarity
# 138 (2018-08-01) ## v138 (2018-08-01)
Use stack image SQLite3 instead of vendoring Use stack image SQLite3 instead of vendoring
# 137 (2018-07-17) ## v137 (2018-07-17)
Prevent 3.7.0 from appearing as unsupported in buildpack messaging. Prevent 3.7.0 from appearing as unsupported in buildpack messaging.
# 136 (2018-06-28) ## v136 (2018-06-28)
Upgrade to 3.6.6 and support 3.7.0 on all runtimes. Upgrade to 3.6.6 and support 3.7.0 on all runtimes.
# 135 (2018-05-29) ## v135 (2018-05-29)
Upgrade Pipenv to v2018.5.18. Upgrade Pipenv to v2018.5.18.
# 134 (2018-05-02) ## v134 (2018-05-02)
Default to 3.6.5, bugfixes. Default to 3.6.5, bugfixes.
# 133 ## v133
Fixes for Pip 10 release. Fixes for Pip 10 release.
# 132 ## v132
Improve pip installation, with the release of v9.0.2. Improve pip installation, with the release of v9.0.2.
# 131 ## v131
Fix bug with pip. Fix bug with pip.
# 130 ## v130
Better upgrade strategy for pip. Better upgrade strategy for pip.
# 129 ## v129
Don't upgrade pip (from v128). Don't upgrade pip (from v128).
# 128 ## v128
Upgrade pip, pin to Pipenv v11.8.2. Upgrade pip, pin to Pipenv v11.8.2.
# 127 ## v127
Pin to Pipenv v11.7.1. Pin to Pipenv v11.7.1.
# 126 ## v126
Bugfixes. Bugfixes.
# 125 ## v125
Bugfixes. Bugfixes.
# 124 ## v124
Update buildpack to automatically install `[dev-packages]` during Heroku CI Pipenv builds. Update buildpack to automatically install `[dev-packages]` during Heroku CI Pipenv builds.
@@ -185,101 +246,101 @@ Update buildpack to automatically install `[dev-packages]` during Heroku CI Pipe
- No longer warn if there is no `Procfile`. - No longer warn if there is no `Procfile`.
- Update Pipenv's "3.6" runtime specifier to point to "3.6.4". - Update Pipenv's "3.6" runtime specifier to point to "3.6.4".
# 123 ## v123
Update gunicorn `init.d` script to allow overrides. Update gunicorn `init.d` script to allow overrides.
# 122 ## v122
Update default Python to v3.6.4. Update default Python to v3.6.4.
# 121 ## v121
Update default Python to v3.6.3. Update default Python to v3.6.3.
# 120 ## v120
Use `$ pipenv --deploy`. Use `$ pipenv --deploy`.
# 119 ## v119
Improvements to Pipenv support, warning on unsupported Python versions. Improvements to Pipenv support, warning on unsupported Python versions.
- We now warn when a user is not using latest 2.x or 3.x Python. - We now warn when a user is not using latest 2.x or 3.x Python.
- Heroku now supports `[requires]` `python_full_version` in addition to `python_version`. - Heroku now supports `[requires]` `python_full_version` in addition to `python_version`.
# 118 ## v118
Improvements to Pipenv support. Improvements to Pipenv support.
# 117 ## v117
Bug fix. Bug fix.
# 116 ## v116
Vendoring improvements. Vendoring improvements.
- Geos libraries should work on Heroku-16 now. - Geos libraries should work on Heroku-16 now.
- The libffi/libmemcached vendoring step is now skipped on Heroku-16 (since they are installed in the base image). - The libffi/libmemcached vendoring step is now skipped on Heroku-16 (since they are installed in the base image).
# 115 ## v115
Revert a pull request. Revert a pull request.
- No longer using `sub_env` for `pip install` step. - No longer using `sub_env` for `pip install` step.
# 114 ## v114
- Bugfixes. - Bugfixes.
Blacklisting `PYTHONHOME` and `PYTHONPATH` for older apps. Upgrades to nltk support. Blacklisting `PYTHONHOME` and `PYTHONPATH` for older apps. Upgrades to nltk support.
# 113 ## v113
Updates to Pipenv support. Updates to Pipenv support.
# 112 ## v112
Bugfix. Bugfix.
- Fixed grep output bug. - Fixed grep output bug.
# 111 ## v111
Linting, bugfixes. Linting, bugfixes.
# 110 ## v110
Update default Python to 3.6.2. Update default Python to 3.6.2.
# 109 ## v109
Update Default Python to 3.6.1, bugfixes. Update Default Python to 3.6.1, bugfixes.
- Fixed automatic pip uninstall of dependencies removed from requirements.txt. - Fixed automatic pip uninstall of dependencies removed from requirements.txt.
# 108 ## v108
Fix output for collectstatic step. Fix output for collectstatic step.
# 107 ## v107
Bugfix for C dependency installation. Bugfix for C dependency installation.
# 106 ## v106
Don't install packages that could mess up packaging. Don't install packages that could mess up packaging.
- The Python buildpack will automatically remove `six`, `pyparsing`, `appdirs`, - The Python buildpack will automatically remove `six`, `pyparsing`, `appdirs`,
`setuptools`, and `distribute` from a `requirements.txt` file now, as these `setuptools`, and `distribute` from a `requirements.txt` file now, as these
packages are provided by the Python buildpack. packages are provided by the Python buildpack.
# 105 ## v105
Improvements to output messaging. Improvements to output messaging.
# 104 ## v104
General improvements. General improvements.
@@ -289,52 +350,52 @@ General improvements.
[395]: https://github.com/heroku/heroku-buildpack-python/pull/395 [395]: https://github.com/heroku/heroku-buildpack-python/pull/395
## 103 ## v103
Bug fixes and improvements. Bug fixes and improvements.
- Fix for Pipenv. - Fix for Pipenv.
- Fix for Heroku CI. - Fix for Heroku CI.
- Improve handling of WEB_CONCURRENCY when using multiple buildpacks. - Improve handling of `WEB_CONCURRENCY` when using multiple buildpacks.
- Adjust environment variables set during the build to more closely match those in the dyno environment (DYNO is now available, STACK is not). - Adjust environment variables set during the build to more closely match those in the dyno environment (`DYNO` is now available, `STACK` is not).
- Restore the build cache prior to running bin/pre_compile. - Restore the build cache prior to running bin/pre_compile.
## 102 ## v102
Buildpack code cleanup. Buildpack code cleanup.
- Improved messaging around NLTK. - Improved messaging around NLTK.
## 101 ## v101
Updated setuptools installation method. Updated setuptools installation method.
- Improved pipenv support. - Improved pipenv support.
## 100 ## v100
Preliminary pipenv support. Preliminary pipenv support.
## 99 ## v99
Cleanup. Cleanup.
## 98 ## v98
Official NLTK support and other improvements. Official NLTK support and other improvements.
- Support for `nltk.txt` file for declaring corpora to be downloaded. - Support for `nltk.txt` file for declaring corpora to be downloaded.
- Leading zeros for auto-set WEB_CONCURRENCY. - Leading zeros for auto-set `WEB_CONCURRENCY`.
## 97 ## v97
Improved egg-link functionality. Improved egg-link functionality.
## 96 ## v96
Bugfix. Bugfix.
## 95 ## v95
Improved output support. Improved output support.
@@ -370,7 +431,7 @@ Fixed bug with editable pip installations.
Updated default Python 2.7.13. Updated default Python 2.7.13.
- Python 2.7.13 uses UCS-4 build, more compatibile with linux wheels. - Python 2.7.13 uses UCS-4 build, more compatible with linux wheels.
- Updated setuptools to v32.1.0. - Updated setuptools to v32.1.0.
## v86 ## v86
@@ -396,7 +457,7 @@ Support for Heroku CI.
## v82 (2016-08-22) ## v82 (2016-08-22)
Update to library detection mechnisms (pip-pop). Update to library detection mechanisms (pip-pop).
- Updated setuptools to v25.5.0 - Updated setuptools to v25.5.0
@@ -470,7 +531,7 @@ Revert to v66.
## v68 (2015-10-12) ## v68 (2015-10-12)
Fixed .heroku/venv error with modern apps. Fixed `.heroku/venv` error with modern apps.
## v67 (2015-10-12) ## v67 (2015-10-12)
@@ -495,7 +556,6 @@ Updated Pip and Setuptools.
- Setuptools updated to v18.3.2 - Setuptools updated to v18.3.2
- Pip updated to v7.1.2 - Pip updated to v7.1.2
## v62 (2015-08-07) ## v62 (2015-08-07)
Updated Pip and Setuptools. Updated Pip and Setuptools.
+2
View File
@@ -4,3 +4,5 @@ gem "rspec"
gem "heroku_hatchet" gem "heroku_hatchet"
gem "rspec-retry" gem "rspec-retry"
gem "rake" gem "rake"
gem "parallel_split_test"
+17 -10
View File
@@ -1,21 +1,22 @@
GEM GEM
remote: https://rubygems.org/ remote: https://rubygems.org/
specs: specs:
activesupport (5.2.1) activesupport (6.0.3.1)
concurrent-ruby (~> 1.0, >= 1.0.2) concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2) i18n (>= 0.7, < 2)
minitest (~> 5.1) minitest (~> 5.1)
tzinfo (~> 1.1) tzinfo (~> 1.1)
concurrent-ruby (1.1.3) zeitwerk (~> 2.2, >= 2.2.2)
concurrent-ruby (1.1.6)
diff-lcs (1.3) diff-lcs (1.3)
erubis (2.7.0) erubis (2.7.0)
excon (0.62.0) excon (0.73.0)
heroics (0.0.25) heroics (0.0.25)
erubis (~> 2.0) erubis (~> 2.0)
excon excon
moneta moneta
multi_json (>= 1.9.2) multi_json (>= 1.9.2)
heroku_hatchet (4.0.6) heroku_hatchet (5.0.3)
excon (~> 0) excon (~> 0)
minitest-retry (~> 0.1.9) minitest-retry (~> 0.1.9)
platform-api (~> 2) platform-api (~> 2)
@@ -23,17 +24,21 @@ GEM
rrrretry (~> 1) rrrretry (~> 1)
thor (~> 0) thor (~> 0)
threaded (~> 0) threaded (~> 0)
i18n (1.1.1) i18n (1.8.2)
concurrent-ruby (~> 1.0) concurrent-ruby (~> 1.0)
minitest (5.11.3) minitest (5.14.1)
minitest-retry (0.1.9) minitest-retry (0.1.9)
minitest (>= 5.0) minitest (>= 5.0)
moneta (1.0.0) moneta (1.0.0)
multi_json (1.13.1) multi_json (1.14.1)
parallel (1.19.1)
parallel_split_test (0.7.0)
parallel (>= 0.5.13)
rspec (>= 3.1.0)
platform-api (2.2.0) platform-api (2.2.0)
heroics (~> 0.0.25) heroics (~> 0.0.25)
moneta (~> 1.0.0) moneta (~> 1.0.0)
rake (12.3.1) rake (12.3.3)
repl_runner (0.0.3) repl_runner (0.0.3)
activesupport activesupport
rrrretry (1.0.0) rrrretry (1.0.0)
@@ -55,17 +60,19 @@ GEM
thor (0.20.3) thor (0.20.3)
thread_safe (0.3.6) thread_safe (0.3.6)
threaded (0.0.4) threaded (0.0.4)
tzinfo (1.2.5) tzinfo (1.2.7)
thread_safe (~> 0.1) thread_safe (~> 0.1)
zeitwerk (2.3.0)
PLATFORMS PLATFORMS
ruby ruby
DEPENDENCIES DEPENDENCIES
heroku_hatchet heroku_hatchet
parallel_split_test
rake rake
rspec rspec
rspec-retry rspec-retry
BUNDLED WITH BUNDLED WITH
1.16.3 2.1.4
+14 -14
View File
@@ -1,26 +1,26 @@
# These targets are not files # These targets are not files
.PHONY: tests .PHONY: check test buildenv-heroku-16 buildenv-heroku-18 tools
test: test-heroku-18 test-heroku-16 test-cedar-14 STACK ?= heroku-18
TEST_CMD ?= test/run-versions && test/run-features && test/run-deps
ifeq ($(STACK),cedar-14)
# Cedar-14 doesn't have a build image varient.
IMAGE_TAG := heroku/cedar:14
else
# Converts a stack name of `heroku-NN` to its build Docker image tag of `heroku/heroku:NN-build`.
IMAGE_TAG := heroku/$(subst -,:,$(STACK))-build
endif
check: check:
@shellcheck -x bin/compile bin/detect bin/release bin/test-compile bin/utils bin/warnings bin/default_pythons @shellcheck -x bin/compile bin/detect bin/release bin/test-compile bin/utils bin/warnings bin/default_pythons
@shellcheck -x bin/steps/collectstatic bin/steps/eggpath-fix bin/steps/eggpath-fix2 bin/steps/gdal bin/steps/geo-libs bin/steps/mercurial bin/steps/nltk bin/steps/pip-install bin/steps/pip-uninstall bin/steps/pipenv bin/steps/pipenv-python-version bin/steps/pylibmc bin/steps/python @shellcheck -x bin/steps/collectstatic bin/steps/eggpath-fix bin/steps/eggpath-fix2 bin/steps/gdal bin/steps/geo-libs bin/steps/mercurial bin/steps/nltk bin/steps/pip-install bin/steps/pip-uninstall bin/steps/pipenv bin/steps/pipenv-python-version bin/steps/pylibmc bin/steps/python
@shellcheck -x bin/steps/hooks/* @shellcheck -x bin/steps/hooks/*
test-cedar-14: test:
@echo "Running tests in docker (cedar-14)..." @echo "Running tests using: STACK=$(STACK) TEST_CMD='$(TEST_CMD)'"
@docker run -v $(shell pwd):/buildpack:ro --rm -it -e "STACK=cedar-14" heroku/cedar:14 bash -c 'cp -r /buildpack /buildpack_test; cd /buildpack_test/; test/run-deps; test/run-features; test/run-versions;'
@echo "" @echo ""
@docker run --rm -it -v $(PWD):/buildpack:ro -e "STACK=$(STACK)" "$(IMAGE_TAG)" bash -c 'cp -r /buildpack /buildpack_test && cd /buildpack_test && $(TEST_CMD)'
test-heroku-16:
@echo "Running tests in docker (heroku-16)..."
@docker run -v $(shell pwd):/buildpack:ro --rm -it -e "STACK=heroku-16" heroku/heroku:16-build bash -c 'cp -r /buildpack /buildpack_test; cd /buildpack_test/; test/run-deps; test/run-features; test/run-versions;'
@echo ""
test-heroku-18:
@echo "Running tests in docker (heroku-18)..."
@docker run -v $(shell pwd):/buildpack:ro --rm -it -e "STACK=heroku-18" heroku/heroku:18-build bash -c 'cp -r /buildpack /buildpack_test; cd /buildpack_test/; test/run-deps; test/run-features; test/run-versions;'
@echo "" @echo ""
buildenv-heroku-16: buildenv-heroku-16:
+1 -26
View File
@@ -86,31 +86,6 @@ Each version is given a distinguishing version number. If the Library as you rec
If the Library as you received it specifies that a proxy can decide whether future versions of the GNU Lesser General Public License shall apply, that proxy's public statement of acceptance of any version is permanent authorization for you to choose that version for the Library. If the Library as you received it specifies that a proxy can decide whether future versions of the GNU Lesser General Public License shall apply, that proxy's public statement of acceptance of any version is permanent authorization for you to choose that version for the Library.
get-pip.py license
------------------
Copyright (c) 2008-2016 The pip developers (see AUTHORS.txt file)
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
pip-pop license pip-pop license
--------------- ---------------
@@ -134,4 +109,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE. THE SOFTWARE.
-9
View File
@@ -1,9 +0,0 @@
[[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"
[dev-packages]
[packages]
"bob-builder" = "==0.0.13"
Generated
-52
View File
@@ -1,52 +0,0 @@
{
"_meta": {
"hash": {
"sha256": "36d17c46a8b1b844b3cae475f6f42d6c0a9e59b2a9685cbcdc0985656a7a129f"
},
"host-environment-markers": {
"implementation_name": "cpython",
"implementation_version": "3.6.3",
"os_name": "posix",
"platform_machine": "x86_64",
"platform_python_implementation": "CPython",
"platform_release": "16.7.0",
"platform_system": "Darwin",
"platform_version": "Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64",
"python_full_version": "3.6.3",
"python_version": "3.6",
"sys_platform": "darwin"
},
"pipfile-spec": 6,
"requires": {},
"sources": [
{
"name": "pypi",
"url": "https://pypi.python.org/simple",
"verify_ssl": true
}
]
},
"default": {
"bob-builder": {
"hashes": [
"sha256:b4de49a8e436fcaf82236ea43f78413b4a4c92100726e382ab57b6bdfb38fe64",
"sha256:288e3e765c4890fe9a63ae52ac6b4a963c13fe508482c70ff701a5ae21b9a673"
],
"version": "==0.0.13"
},
"boto": {
"hashes": [
"sha256:13be844158d1bd80a94c972c806ec8381b9ea72035aa06123c5db6bc6a6f3ead",
"sha256:deb8925b734b109679e3de65856018996338758f4b916ff4fe7bb62b6d7000d1"
],
"version": "==2.48.0"
},
"docopt": {
"hashes": [
"sha256:49b3a825280bd66b3aa83585ef59c4a8c82f2c8a522dbe754a8bc8d08c85c491"
],
"version": "==0.6.2"
}
},
"develop": {}
}
+17 -10
View File
@@ -2,7 +2,7 @@
# Heroku Buildpack: Python # Heroku Buildpack: Python
[![Build Status](https://travis-ci.org/heroku/heroku-buildpack-python.svg?branch=master)](https://travis-ci.org/heroku/heroku-buildpack-python) [![Build Status](https://travis-ci.com/heroku/heroku-buildpack-python.svg?branch=main)](https://travis-ci.com/heroku/heroku-buildpack-python)
This is the official [Heroku buildpack](https://devcenter.heroku.com/articles/buildpacks) for Python apps. This is the official [Heroku buildpack](https://devcenter.heroku.com/articles/buildpacks) for Python apps.
@@ -16,7 +16,7 @@ See it in Action
$ ls $ ls
my-application requirements.txt runtime.txt my-application requirements.txt runtime.txt
$ git push heroku master $ git push heroku main
Counting objects: 4, done. Counting objects: 4, done.
Delta compression using up to 8 threads. Delta compression using up to 8 threads.
Compressing objects: 100% (2/2), done. Compressing objects: 100% (2/2), done.
@@ -46,7 +46,8 @@ To specify your python version, you also need a `runtime.txt` file - unless you
Current default Python Runtime: Python 3.6.9 Current default Python Runtime: Python 3.6.9
Alternatively, you can provide a `setup.py` file, or a `Pipfile`. Using `Pipenv` will generate `runtime.txt` based on `python-version` at build time. Alternatively, you can provide a `setup.py` file, or a `Pipfile`.
Using `pipenv` will generate `runtime.txt` at build time if one of the field `python_version` or `python_full_version` is specified in the `requires` section of your `Pipfile`.
Specify a Buildpack Version Specify a Buildpack Version
--------------------------- ---------------------------
@@ -61,26 +62,32 @@ Specify a Python Runtime
Supported runtime options include: Supported runtime options include:
- `python-3.7.4` - `python-3.8.5`
- `python-3.6.9` - `python-3.7.8`
- `python-2.7.17` - `python-3.6.11`
- `python-2.7.18`
## Tests ## Tests
The buildpack tests use [Docker](https://www.docker.com/) to simulate The buildpack tests use [Docker](https://www.docker.com/) to simulate
Heroku's [stack images.](https://devcenter.heroku.com/articles/stack) Heroku's [stack images.](https://devcenter.heroku.com/articles/stack)
To run the test suite: To run the test suite against the default stack:
``` ```
make test make test
``` ```
Or to test in a particular stack: Or to test against a particular stack:
``` ```
make test-heroku-18 make test STACK=heroku-16
make test-heroku-16 ```
To run only a subset of the tests:
```
make test TEST_CMD=tests/versions
``` ```
The tests are run via the vendored The tests are run via the vendored
+9 -38
View File
@@ -16,7 +16,9 @@
set -eo pipefail set -eo pipefail
# Boostrap the Buildpack Standard Library. # Boostrap the Buildpack Standard Library.
export BPLOG_PREFIX="buildpack.python" # Disable unused env var warning since shellcheck doesn't know about the stdlib.
# shellcheck disable=2034
BPLOG_PREFIX="buildpack.python"
export BUILDPACK_LOG_FILE=${BUILDPACK_LOG_FILE:-/dev/null} export BUILDPACK_LOG_FILE=${BUILDPACK_LOG_FILE:-/dev/null}
[ "$BUILDPACK_XTRACE" ] && set -o xtrace [ "$BUILDPACK_XTRACE" ] && set -o xtrace
@@ -63,37 +65,13 @@ PYPY36="pypy3.6"
# Which stack is used (for binary downloading), if none is provided (e.g. outside of Heroku)? # Which stack is used (for binary downloading), if none is provided (e.g. outside of Heroku)?
DEFAULT_PYTHON_STACK="cedar-14" DEFAULT_PYTHON_STACK="cedar-14"
# If pip doesn't match this version (the version we install), run the installer.
PIP_UPDATE="20.0.2"
for file in "$BUILD_DIR/runtime.txt" "$CACHE_DIR/.heroku/python-version" ; do
[ -f "$file" ] || continue
version=$(tr -d '[:space:]' < "$file")
case "$version" in "$PY34"*)
# Python 3.4 support was dropped in pip >= 19.2.
PIP_UPDATE="19.1.1"
break
;;
esac
done
if [[ -f "$BUILD_DIR/Pipfile" ]]; then
# Do not force pipenv users to re-install pipenv locally.
PIP_UPDATE="9.0.2"
fi
export DEFAULT_PYTHON_STACK PIP_UPDATE
export PY37 PY36 PY35 PY27 PY34
# Common Problem Warnings: # Common Problem Warnings:
# This section creates a temporary file in which to stick the output of `pip install`. # This section creates a temporary file in which to stick the output of `pip install`.
# The `warnings` subscript then greps through this for common problems and guides # The `warnings` subscript then greps through this for common problems and guides
# the user towards resolution of known issues. # the user towards resolution of known issues.
WARNINGS_LOG=$(mktemp) WARNINGS_LOG=$(mktemp)
export WARNINGS_LOG RECOMMENDED_PYTHON_VERSION=$DEFAULT_PYTHON_VERSION
export RECOMMENDED_PYTHON_VERSION=$DEFAULT_PYTHON_VERSION
# The buildpack ships with a few executable tools (e.g. pip-grep, etc). # The buildpack ships with a few executable tools (e.g. pip-grep, etc).
# This installs them into the path, so we can execute them directly. # This installs them into the path, so we can execute them directly.
@@ -159,6 +137,10 @@ export LIBRARY_PATH=/app/.heroku/vendor/lib:/app/.heroku/python/lib:$LIBRARY_PAT
export LD_LIBRARY_PATH=/app/.heroku/vendor/lib:/app/.heroku/python/lib:$LD_LIBRARY_PATH export LD_LIBRARY_PATH=/app/.heroku/vendor/lib:/app/.heroku/python/lib:$LD_LIBRARY_PATH
export PKG_CONFIG_PATH=/app/.heroku/vendor/lib/pkg-config:/app/.heroku/python/lib/pkg-config:$PKG_CONFIG_PATH export PKG_CONFIG_PATH=/app/.heroku/vendor/lib/pkg-config:/app/.heroku/python/lib/pkg-config:$PKG_CONFIG_PATH
# Global pip options (https://pip.pypa.io/en/stable/user_guide/#environment-variables).
# Disable pip's warnings about EOL Python since we show our own.
export PIP_NO_PYTHON_VERSION_WARNING=1
# The Application Code # The Application Code
# -------------------- # --------------------
@@ -175,7 +157,7 @@ cd "$BUILD_DIR"
# - Once the build is complete, `~/.heroku/{known-paths}` is copied back into the cache. # - Once the build is complete, `~/.heroku/{known-paths}` is copied back into the cache.
# Create the cache directory, if it doesn't exist. # Create the cache directory, if it doesn't exist.
mkdir -p "$CACHE_DIR" mkdir -p "$CACHE_DIR/.heroku"
# Restore old artifacts from the cache. # Restore old artifacts from the cache.
mkdir -p .heroku mkdir -p .heroku
@@ -217,8 +199,6 @@ else
CACHED_PYTHON_STACK=$STACK CACHED_PYTHON_STACK=$STACK
fi fi
export CACHED_PYTHON_STACK
# Pipenv Python version support. # Pipenv Python version support.
# Detect the version of Python requested from a Pipfile (e.g. python_version or python_full_version). # Detect the version of Python requested from a Pipfile (e.g. python_version or python_full_version).
# Convert it to a runtime.txt file. # Convert it to a runtime.txt file.
@@ -259,17 +239,8 @@ mtime "python.install.time" "${start}"
# shellcheck source=bin/steps/pipenv # shellcheck source=bin/steps/pipenv
source "$BIN_DIR/steps/pipenv" source "$BIN_DIR/steps/pipenv"
# Uninstall removed dependencies with Pip.
# The buildpack will automatically remove any declared dependencies (in requirements.txt)
# that were explicitly removed. This machinery is a bit complex, but it is not complicated.
(( start=$(nowms) ))
# shellcheck source=bin/steps/pip-uninstall
source "$BIN_DIR/steps/pip-uninstall"
mtime "pip.uninstall.time" "${start}"
# If no requirements.txt file given, assume `setup.py develop` is intended. # If no requirements.txt file given, assume `setup.py develop` is intended.
# This allows for people to ship a setup.py application to Heroku # This allows for people to ship a setup.py application to Heroku
# (which is rare, but I vouch that it should work!)
if [ ! -f requirements.txt ] && [ ! -f Pipfile ]; then if [ ! -f requirements.txt ] && [ ! -f Pipfile ]; then
echo "-e ." > requirements.txt echo "-e ." > requirements.txt
+13 -18
View File
@@ -1,21 +1,16 @@
#!/usr/bin/env bash #!/usr/bin/env bash
DEFAULT_PYTHON_VERSION="python-3.6.10" # Disable unused env var warning, since shellcheck doesn't take into account
LATEST_38="python-3.8.2" # that this file is sourced. We don't want to use export since it exposes
LATEST_37="python-3.7.6" # the env vars to subprocesses.
LATEST_36="python-3.6.10" # shellcheck disable=2034
LATEST_35="python-3.5.7"
LATEST_34="python-3.4.10"
LATEST_27="python-2.7.17"
PYPY_36="pypy3.6-7.2.0"
PYPY_27="pypy2.7-7.2.0"
export DEFAULT_PYTHON_VERSION \ DEFAULT_PYTHON_VERSION="python-3.6.11"
LATEST_38 \ LATEST_38="python-3.8.5"
LATEST_37 \ LATEST_37="python-3.7.8"
LATEST_36 \ LATEST_36="python-3.6.11"
LATEST_35 \ LATEST_35="python-3.5.9"
LATEST_34 \ LATEST_34="python-3.4.10"
LATEST_27 \ LATEST_27="python-2.7.18"
PYPY_36 \ PYPY_36="pypy3.6-7.3.1"
PYPY_27 PYPY_27="pypy2.7-7.3.1"
+21
View File
@@ -0,0 +1,21 @@
# Python Buildpack Install Steps
TODO: Add context on Python install steps, such as why symlinking vs copying
## Installing Python packages using Pip
### Convention: Use `python` process to invoke Pip
We don't use this convention (yet) but this is an upcoming change being considered.
This is a bigger concern on Windows than it is in Linux environments, but an
emerging convention in the Python community is to invoke pip using:
```
python3 -m pip [options]
```
Invoking pip this way ensures correct location - python knows where these
packages are stored because it put them there (defaults to Python's pathing info).
All normal command line options are available using this method.
+4
View File
@@ -22,6 +22,10 @@ source "$BIN_DIR/utils"
if (pip-grep -s requirements.txt GDAL gdal pygdal &> /dev/null) then if (pip-grep -s requirements.txt GDAL gdal pygdal &> /dev/null) then
if [ ! -f ".heroku/vendor/bin/gdalserver" ]; then if [ ! -f ".heroku/vendor/bin/gdalserver" ]; then
puts-warn "The vendored GDAL package in the Heroku Python Buildpack now deprecated."
puts-warn "To enable GDAL use an alternative buildpack is available here - https://github.com/heroku/heroku-geo-buildpack"
echo "-----> Noticed GDAL. Bootstrapping gdal." echo "-----> Noticed GDAL. Bootstrapping gdal."
mkdir -p .heroku/vendor mkdir -p .heroku/vendor
# Download and extract cryptography into target vendor directory. # Download and extract cryptography into target vendor directory.
+3
View File
@@ -24,6 +24,9 @@ source "$BIN_DIR/utils"
if [[ "$BUILD_WITH_GEO_LIBRARIES" ]]; then if [[ "$BUILD_WITH_GEO_LIBRARIES" ]]; then
mcount "buildvar.BUILD_WITH_GEO_LIBRARIES" mcount "buildvar.BUILD_WITH_GEO_LIBRARIES"
puts-warn "The GDAL, GEOS and PROJ binaries and BUILD_WITH_GEO_LIBRARIES functonality are now deprecated."
puts-warn "An alternative buildpack to enable GDAL, GEOS and PROJ use is available here - https://github.com/heroku/heroku-geo-buildpack"
if [ ! -f ".heroku/vendor/bin/proj" ]; then if [ ! -f ".heroku/vendor/bin/proj" ]; then
echo "-----> Bootstrapping gdal, geos, proj." echo "-----> Bootstrapping gdal, geos, proj."
mkdir -p .heroku/vendor mkdir -p .heroku/vendor
+3 -5
View File
@@ -38,15 +38,16 @@ if [ ! "$SKIP_PIP_INSTALL" ]; then
mcount "failure.none-version" mcount "failure.none-version"
fi fi
if grep -q 'django==1.*' requirements.txt; then if grep -qi '^django==1.*' requirements.txt; then
puts-warn "Your Django version is nearing the end of its community support." puts-warn "Your Django version is nearing the end of its community support."
puts-warn "Upgrade to continue to receive security updates and for the best experience with Django." puts-warn "Upgrade to continue to receive security updates and for the best experience with Django."
puts-warn "For more information, check out https://www.djangoproject.com/weblog/2015/jun/25/roadmap/" puts-warn "For more information, check out https://www.djangoproject.com/download/#supported-versions"
fi fi
if [ ! -f "$BUILD_DIR/.heroku/python/bin/pip" ]; then if [ ! -f "$BUILD_DIR/.heroku/python/bin/pip" ]; then
exit 1 exit 1
fi fi
/app/.heroku/python/bin/pip install -r "$BUILD_DIR/requirements.txt" --exists-action=w --src=/app/.heroku/src --disable-pip-version-check --no-cache-dir 2>&1 | tee "$WARNINGS_LOG" | cleanup | indent /app/.heroku/python/bin/pip install -r "$BUILD_DIR/requirements.txt" --exists-action=w --src=/app/.heroku/src --disable-pip-version-check --no-cache-dir 2>&1 | tee "$WARNINGS_LOG" | cleanup | indent
PIP_STATUS="${PIPESTATUS[0]}" PIP_STATUS="${PIPESTATUS[0]}"
set -e set -e
@@ -58,12 +59,9 @@ if [ ! "$SKIP_PIP_INSTALL" ]; then
exit 1 exit 1
fi fi
# Smart Requirements handling
cp requirements.txt .heroku/python/requirements-declared.txt cp requirements.txt .heroku/python/requirements-declared.txt
/app/.heroku/python/bin/pip freeze --disable-pip-version-check > .heroku/python/requirements-installed.txt /app/.heroku/python/bin/pip freeze --disable-pip-version-check > .heroku/python/requirements-installed.txt
echo
# Install test dependencies, for CI. # Install test dependencies, for CI.
if [ "$INSTALL_TEST" ]; then if [ "$INSTALL_TEST" ]; then
if [[ -f "$1/requirements-test.txt" ]]; then if [[ -f "$1/requirements-test.txt" ]]; then
+3
View File
@@ -27,6 +27,9 @@ if [[ -f $BUILD_DIR/Pipfile ]]; then
if [ "$PYTHON" = 3.7 ]; then if [ "$PYTHON" = 3.7 ]; then
echo "$LATEST_37" > "$BUILD_DIR/runtime.txt" echo "$LATEST_37" > "$BUILD_DIR/runtime.txt"
fi fi
if [ "$PYTHON" = 3.8 ]; then
echo "$LATEST_38" > "$BUILD_DIR/runtime.txt"
fi
fi fi
+67 -33
View File
@@ -86,14 +86,6 @@ if [[ "$STACK" != "$CACHED_PYTHON_STACK" ]]; then
rm -fr .heroku/python-stack .heroku/python-version .heroku/python .heroku/vendor .heroku/python .heroku/python-sqlite3-version rm -fr .heroku/python-stack .heroku/python-version .heroku/python .heroku/vendor .heroku/python .heroku/python-sqlite3-version
fi fi
# need to clear the cache for first time installing SQLite3,
# since the version is changing and could lead to runtime errors
# with compiled extensions.
if [ -d .heroku/python ] && [ ! -f .heroku/python-sqlite3-version ] && python_sqlite3_check "$PYTHON_VERSION"; then
puts-step "Need to update SQLite3, clearing cache"
rm -fr .heroku/python-stack .heroku/python-version .heroku/python .heroku/vendor
fi
if [ -f .heroku/python-version ]; then if [ -f .heroku/python-version ]; then
if [ ! "$(cat .heroku/python-version)" = "$PYTHON_VERSION" ]; then if [ ! "$(cat .heroku/python-version)" = "$PYTHON_VERSION" ]; then
puts-step "Found $(cat .heroku/python-version), removing" puts-step "Found $(cat .heroku/python-version), removing"
@@ -103,6 +95,24 @@ if [ -f .heroku/python-version ]; then
fi fi
fi fi
# Check if we should reinstall python dependencies
if [[ ! -f "$CACHE_DIR/.heroku/requirements.txt" ]]; then
# IF there's no cached dependencies, update cached version of requirements.txt
# This should only run for new apps and first deploys after this update
cp -R "$BUILD_DIR/requirements.txt" "$CACHE_DIR/.heroku/requirements.txt"
else
# IF there IS a cached directory, check for differences with the new one
if ! diff "$BUILD_DIR/requirements.txt" "$CACHE_DIR/.heroku/requirements.txt" &> /dev/null; then
puts-step "Requirements file has been changed, clearing cached dependencies"
# if there are any differences, clear the Python cache
# Installing Python over again does not take noticably more time
cp -R "$BUILD_DIR/requirements.txt" "$CACHE_DIR/.heroku/requirements.txt"
rm -rf .heroku/python
unset SKIP_INSTALL
else
puts-step "No change in requirements detected, installing from cache"
fi
fi
if [ ! "$SKIP_INSTALL" ]; then if [ ! "$SKIP_INSTALL" ]; then
puts-step "Installing $PYTHON_VERSION" puts-step "Installing $PYTHON_VERSION"
@@ -121,34 +131,58 @@ if [ ! "$SKIP_INSTALL" ]; then
# Record for future reference. # Record for future reference.
echo "$PYTHON_VERSION" > .heroku/python-version echo "$PYTHON_VERSION" > .heroku/python-version
echo "$STACK" > .heroku/python-stack echo "$STACK" > .heroku/python-stack
FRESH_PYTHON=true
hash -r hash -r
fi fi
# Heroku uses the get-pip utility maintained by the Python community to vendor Pip.
# https://github.com/pypa/get-pip
GETPIP_URL="https://lang-python.s3.amazonaws.com/etc/get-pip.py"
GETPIP_PY="${TMPDIR:-/tmp}/get-pip.py"
if ! curl -s "${GETPIP_URL}" -o "$GETPIP_PY" &> /dev/null; then
mcount "failure.python.get-pip"
echo "Failed to pull down get-pip"
exit 1
fi
# If Pip isn't up to date:
if [ "$FRESH_PYTHON" ] || [[ ! $(pip --version) == *$PIP_UPDATE* ]]; then
puts-step "Installing pip"
# Remove old installations.
rm -fr /app/.heroku/python/lib/python*/site-packages/pip-*
rm -fr /app/.heroku/python/lib/python*/site-packages/setuptools-*
/app/.heroku/python/bin/python "$GETPIP_PY" pip=="$PIP_UPDATE" &> /dev/null
/app/.heroku/python/bin/pip install "$ROOT_DIR/vendor/setuptools-39.0.1-py2.py3-none-any.whl" &> /dev/null
fi
set -e set -e
PIP_VERSION='20.1.1'
# Must use setuptools <47.2.0 until we fix:
# https://github.com/heroku/heroku-buildpack-python/issues/1006
SETUPTOOLS_VERSION='47.1.1'
WHEEL_VERSION='0.34.2'
if [[ "${PYTHON_VERSION}" == ${PY34}* ]]; then
# Python 3.4 support was dropped in pip 19.2+, setuptools 44+ and wheel 0.34+.
PIP_VERSION='19.1.1'
SETUPTOOLS_VERSION='43.0.0'
WHEEL_VERSION='0.33.6'
elif [[ "${PYTHON_VERSION}" == ${PY27}* || "${PYTHON_VERSION}" == ${PYPY27}* ]]; then
# Python 2.7 support was dropped in setuptools 45+.
SETUPTOOLS_VERSION='44.1.1'
fi
# We don't use get-pip.py, since:
# - it uses `--force-reinstall`, which is unnecessary here and slows down repeat builds
# - it means downloading pip twice (once embedded in get-pip.py, and again during
# the install, since get-pip.py can't install the embedded version directly)
# - we would still have to manage several versions of get-pip.py, to support older Pythons.
# Instead, we use the pip wheel to install itself, using the method described here:
# https://github.com/pypa/pip/issues/2351#issuecomment-69994524
PIP_WHEEL_FILENAME="pip-${PIP_VERSION}-py2.py3-none-any.whl"
PIP_WHEEL_URL="https://lang-python.s3.amazonaws.com/common/${PIP_WHEEL_FILENAME}"
PIP_WHEEL="${TMPDIR:-/tmp}/${PIP_WHEEL_FILENAME}"
if ! curl -sSf "${PIP_WHEEL_URL}" -o "$PIP_WHEEL"; then
mcount "failure.python.download-pip"
puts-warn "Failed to download pip"
exit 1
fi
if [[ -f "$BUILD_DIR/Pipfile" ]]; then
# The buildpack is pinned to old pipenv, which requires older pip.
# Pip 9.0.2 doesn't support installing itself from a wheel, so we have to use split
# versions here (ie: installer pip version different from target pip version).
PIP_VERSION='9.0.2'
PIP_TO_INSTALL="pip==${PIP_VERSION}"
else
PIP_TO_INSTALL="${PIP_WHEEL}"
fi
puts-step "Installing pip ${PIP_VERSION}, setuptools ${SETUPTOOLS_VERSION} and wheel ${WHEEL_VERSION}"
/app/.heroku/python/bin/python "${PIP_WHEEL}/pip" install --quiet --disable-pip-version-check --no-cache \
"${PIP_TO_INSTALL}" "setuptools==${SETUPTOOLS_VERSION}" "wheel==${WHEEL_VERSION}"
hash -r hash -r
-1
View File
@@ -67,7 +67,6 @@ buildpack_sqlite3_install() {
puts-step "Installing SQLite3" puts-step "Installing SQLite3"
if sqlite3_install "$BUILD_DIR/.heroku/python" ; then if sqlite3_install "$BUILD_DIR/.heroku/python" ; then
echo "Sqlite3 successfully installed."
mcount "success.python.sqlite3" mcount "success.python.sqlite3"
else else
echo "Sqlite3 failed to install." echo "Sqlite3 failed to install."
+1 -1
View File
@@ -1,4 +1,4 @@
FROM heroku/heroku:18-build.v16 FROM heroku/heroku:18-build
WORKDIR /app WORKDIR /app
ENV WORKSPACE_DIR="/app/builds" \ ENV WORKSPACE_DIR="/app/builds" \
-28
View File
@@ -1,28 +0,0 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/vendor/
OUT_PREFIX=$1
# Skip the build for heroku-16.
if [[ $S3_PREFIX == "heroku-16" ]]; then
exit 0
fi
# Use new path, containing autoconf.
export PATH="/app/.heroku/python/bin/:$PATH"
hash -r
echo "Building libffi…"
SOURCE_TARBALL='https://github.com/libffi/libffi/archive/v3.1.tar.gz'
curl -L $SOURCE_TARBALL | tar x
cd v3.1
./configure --prefix=$OUT_PREFIX --disable-static &&
make
make install
# Cleanup
cd ..
+3 -3
View File
@@ -3,9 +3,9 @@
OUT_PREFIX=$1 OUT_PREFIX=$1
# Skip the build for heroku-16. if [[ $S3_PREFIX != "cedar-14" ]]; then
if [[ $S3_PREFIX == "heroku-16" ]]; then echo "libmemcached only needs to be built for cedar-14, since newer stacks include it in the base image"
exit 0 exit 1
fi fi
# fail hard # fail hard
+4
View File
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
source $(dirname $0)/pypy2.7
+4
View File
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
source $(dirname $0)/pypy3.6
+27
View File
@@ -0,0 +1,27 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
OUT_PREFIX=$1
BIN_DIR="$(cd "$(dirname "$0")"/../.. || exit; pwd)/bin"
export BIN_DIR
# shellcheck source=bin/utils
source "$BIN_DIR/steps/sqlite3"
sqlite3_version
echo "Setting up SQLite3 Headers for $SQLITE3_VERSION"
sqlite3_install "$OUT_PREFIX" "$SQLITE3_VERSION" 1
echo "Building Python…"
SOURCE_TARBALL='https://python.org/ftp/python/2.7.18/Python-2.7.18.tgz'
curl -L $SOURCE_TARBALL | tar xz
mv Python-2.7.18 src
cd src
./configure --prefix=$OUT_PREFIX --enable-unicode=ucs4 --with-ensurepip=no
make
make install
# Remove unneeded test directories, similar to the official Docker Python images:
# https://github.com/docker-library/python
find "${OUT_PREFIX}" \( -type d -a \( -name test -o -name tests \) \) -exec rm -rf '{}' +
+4
View File
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
source $(dirname $0)/python3
+4
View File
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
source $(dirname $0)/python3
+4
View File
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
source $(dirname $0)/python3
+4
View File
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
source $(dirname $0)/python3
+4
View File
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
source $(dirname $0)/python3
+4
View File
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
# Build Path: /app/.heroku/python/
source $(dirname $0)/python3
Regular → Executable
View File
+4 -4
View File
@@ -14,9 +14,9 @@ case "$choice" in
* ) exit 1;; * ) exit 1;;
esac esac
originMaster=$(git rev-parse origin/master) originMain=$(git rev-parse origin/main)
echo "Tagging commit $originMaster with $newVersion... " echo "Tagging commit $originMain with $newVersion... "
git tag "$newVersion" "${originMaster:?}" git tag "$newVersion" "${originMain:?}"
git push origin refs/tags/$newVersion git push origin refs/tags/$newVersion
heroku buildpacks:publish "$BP_NAME" "$newVersion" heroku buildpacks:publish "$BP_NAME" "$newVersion"
@@ -31,7 +31,7 @@ if [ $(git tag | grep -q latest-version) ]; then
echo "Updating latest-version tag" echo "Updating latest-version tag"
git tag -d latest-version git tag -d latest-version
git push origin :latest-version git push origin :latest-version
git tag latest-version "${originMaster:?}" git tag latest-version "${originMain:?}"
git push --tags git push --tags
fi fi
+2 -1
View File
@@ -1,5 +1,6 @@
{ {
"python": [ "python": [
"heroku/python-getting-started" "heroku/python-getting-started",
"sharpstone/python_default"
] ]
} }
+3 -1
View File
@@ -1,3 +1,5 @@
--- ---
- - "./repos/python/python-getting-started" - - "./repos/python/python-getting-started"
- f56b90499ec11e1c9576da2f8c7331300e189db3 - master
- - "./repos/python/python_default"
- ca947f69027b2a30be5d26f9a42f25e54f4d7a1a
+33
View File
@@ -0,0 +1,33 @@
require_relative '../spec_helper'
describe "Heroku CI" do
it "works" do
before_deploy = Proc.new do
File.open("app.json", "w+") do |f|
f.puts <<~EOM
{
"environments": {
"test": {
"scripts": {
"test": "nosetests"
}
}
}
}
EOM
end
run!("echo nose >> requirements.txt")
end
Hatchet::Runner.new("python_default", before_deploy: before_deploy).run_ci do |test_run|
expect(test_run.output).to match("Downloading nose")
expect(test_run.output).to match("OK")
test_run.run_again
expect(test_run.output).to match("installing from cache")
expect(test_run.output).to_not match("Downloading nose")
end
end
end
+67 -5
View File
@@ -1,10 +1,72 @@
require_relative '../spec_helper' require_relative '../spec_helper'
describe "Python!!!!!!!!!!!" do describe "Python" do
it "🐍" do describe "cache" do
Hatchet::Runner.new('python-getting-started', stack: DEFAULT_STACK).deploy do |app| it "functions correctly" do
expect(app.output).to match(/Installing pip/) Hatchet::Runner.new("python_default").deploy do |app|
expect(app.run('python -V')).to match(/3.6.10/) expect(app.output).to match(/Installing pip/)
expect(app.output).to_not match("Requirements file has been changed, clearing cached dependencies")
expect(app.output).to_not match("No change in requirements detected, installing from cache")
expect(app.output).to_not match("No such file or directory")
expect(app.output).to_not match("cp: cannot create regular file")
# Redeploy with changed requirements file
run!(%Q{echo "" >> requirements.txt})
run!(%Q{echo "pygments" >> requirements.txt})
run!(%Q{git add . ; git commit --allow-empty -m next})
app.push!
# Check the cache to have cleared
expect(app.output).to match("Requirements file has been changed, clearing cached dependencies")
expect(app.output).to_not match("No dependencies found, preparing to install")
expect(app.output).to_not match("No change in requirements detected, installing from cache")
# With no changes on redeploy, the cache should be present
run!(%Q{git commit --allow-empty -m next})
app.push!
expect(app.output).to match("No change in requirements detected, installing from cache")
expect(app.output).to_not match("Requirements file has been changed, clearing cached dependencies")
expect(app.output).to_not match("No dependencies found, preparing to install")
end
end
end
describe "python versions" do
let(:stack) { ENV["HEROKU_TEST_STACK"] || DEFAULT_STACK }
it "works with 3.7.6" do
version = "3.7.6"
before_deploy = -> { run!(%Q{echo "python-#{version}" >> runtime.txt}) }
Hatchet::Runner.new("python_default", before_deploy: before_deploy, stack: stack).deploy do |app|
expect(app.run('python -V')).to match(version)
end
end
it "works with 3.8.2" do
version = "3.8.2"
before_deploy = -> { run!(%Q{echo "python-#{version}" >> runtime.txt}) }
Hatchet::Runner.new("python_default", before_deploy: before_deploy, stack: stack).deploy do |app|
expect(app.run('python -V')).to match(version)
end
end
it "fails with a bad version" do
version = "3.8.2.lol"
before_deploy = -> { run!(%Q{echo "python-#{version}" >> runtime.txt}) }
Hatchet::Runner.new("python_default", before_deploy: before_deploy, stack: stack, allow_failure: true).deploy do |app|
expect(app.output).to match("not available for this stack")
end
end
end
it "getting started app has no relative paths" do
buildpacks = [
:default,
"https://github.com/sharpstone/force_absolute_paths_buildpack"
]
Hatchet::Runner.new("python-getting-started", buildpacks: buildpacks).deploy do |app|
# Deploy works
end end
end end
end end
+7 -6
View File
@@ -1,4 +1,4 @@
ENV['HATCHET_BUILDPACK_BASE'] = 'https://github.com/' + ENV['TRAVIS_REPO_SLUG'] + '.git' ENV['HATCHET_BUILDPACK_BASE'] = 'https://github.com/heroku/heroku-buildpack-python.git'
require 'rspec/core' require 'rspec/core'
require 'rspec/retry' require 'rspec/retry'
@@ -15,9 +15,10 @@ RSpec.configure do |config|
end end
end end
if ENV['TRAVIS'] DEFAULT_STACK = 'heroku-18'
# Don't execute tests against "merge" commits
exit 0 if ENV['TRAVIS_PULL_REQUEST'] != 'false' && ENV['TRAVIS_BRANCH'] == 'master'
end
DEFAULT_STACK = 'heroku-16' def run!(cmd)
out = `#{cmd}`
raise "Error running command #{cmd} with output: #{out}" unless $?.success?
return out
end
+4
View File
@@ -0,0 +1,4 @@
set -euo pipefail
echo "post_compile ran!"
echo "post_compile env: $(printenv | cut -d '=' -f 1 | sort | xargs)."
+4
View File
@@ -0,0 +1,4 @@
set -euo pipefail
echo "pre_compile ran!"
echo "pre_compile env: $(printenv | cut -d '=' -f 1 | sort | xargs)."
View File
+2
View File
@@ -0,0 +1,2 @@
pwned-passwords-django==1.4
Django==2.1
+1
View File
@@ -0,0 +1 @@
Django==1.11
+1 -1
View File
@@ -1 +1 @@
python-2.7.17 python-2.7.18
+1 -1
View File
@@ -1 +1 @@
python-3.5.7 python-3.5.9
+18 -7
View File
@@ -5,8 +5,9 @@
source "bin/default_pythons" source "bin/default_pythons"
testAirflow() { testAirflow() {
export SLUGIFY_USES_TEXT_UNIDECODE="yes" local env_dir="$(mktmpdir)"
compile "airflow" echo 'yes' > "${env_dir}/SLUGIFY_USES_TEXT_UNIDECODE"
compile 'airflow' '' "${env_dir}"
assertCaptured "apache-airflow==1.10.2" assertCaptured "apache-airflow==1.10.2"
assertCapturedSuccess assertCapturedSuccess
} }
@@ -17,19 +18,30 @@ testCollectstatic() {
} }
testGEOS() { testGEOS() {
export BUILD_WITH_GEO_LIBRARIES=1 local env_dir="$(mktmpdir)"
compile "geos" echo '1' > "${env_dir}/BUILD_WITH_GEO_LIBRARIES"
compile 'geos' '' "${env_dir}"
assertCaptured "geos" assertCaptured "geos"
assertCapturedSuccess assertCapturedSuccess
} }
testGEOSDeprecation() {
local env_dir="$(mktmpdir)"
echo '1' > "${env_dir}/BUILD_WITH_GEO_LIBRARIES"
compile 'geos' '' "${env_dir}"
assertCaptured " ! The GDAL, GEOS and PROJ binaries and BUILD_WITH_GEO_LIBRARIES functonality are now deprecated.
! An alternative buildpack to enable GDAL, GEOS and PROJ use is available here - https://github.com/heroku/heroku-geo-buildpack"
assertCapturedSuccess
}
testNLTK() { testNLTK() {
local env_dir="$(mktmpdir)"
# NOTE: This is a RuntimeWarning emitted by Python 3's runpy.py script # NOTE: This is a RuntimeWarning emitted by Python 3's runpy.py script
# which is what is used when you call `python -m <module>`. This is due to # which is what is used when you call `python -m <module>`. This is due to
# how nltk imports things. It's not actually an error, but it would probably # how nltk imports things. It's not actually an error, but it would probably
# be bad to silence in Production. # be bad to silence in Production.
export PYTHONWARNINGS="ignore::RuntimeWarning" echo 'ignore::RuntimeWarning' > "${env_dir}/PYTHONWARNINGS"
compile "nltk" compile 'nltk' '' "${env_dir}"
assertCaptured "[nltk_data] Downloading package city_database" "STD_ERR" assertCaptured "[nltk_data] Downloading package city_database" "STD_ERR"
assertCapturedSuccess assertCapturedSuccess
} }
@@ -48,7 +60,6 @@ testPysqlite() {
testSqliteInstall() { testSqliteInstall() {
compile "pythonDefault" compile "pythonDefault"
assertCaptured "Sqlite3 successfully installed."
assertNotCaptured "Sqlite3 failed to install." assertNotCaptured "Sqlite3 failed to install."
assertCapturedSuccess assertCapturedSuccess
} }
+57
View File
@@ -44,6 +44,7 @@ testStandardRequirements() {
testPipenv() { testPipenv() {
compile "pipenv" compile "pipenv"
assertCaptured "Installing pip 9.0.2, setuptools 47.1.1 and wheel 0.34.2"
assertCapturedSuccess assertCapturedSuccess
} }
@@ -74,6 +75,62 @@ testNoRequirements() {
assertCapturedError assertCapturedError
} }
testWarnOldDjango() {
compile "old-django"
assertCaptured "Your Django version is nearing the end of its community support."
assertCapturedSuccess
}
testDontWarnOldDjango() {
compile "not-old-django"
assertNotCaptured "Your Django version is nearing the end of its community support."
assertCapturedSuccess
}
testHooks() {
# Test that the hooks are called correctly, and that the environment contains
# the app's config vars but no unexpected env vars from the buildpack.
local env_dir="$(mktmpdir)"
echo 'test' > "${env_dir}/SOME_APP_CONFIG_VAR"
local expected_env_vars=(
_
BIN_DIR
BUILD_DIR
BUILDPACK_LOG_FILE
CACHE_DIR
C_INCLUDE_PATH
CPLUS_INCLUDE_PATH
ENV_DIR
EXPORT_PATH
HOME
LANG
LD_LIBRARY_PATH
LIBRARY_PATH
OLDPWD
PATH
PIP_NO_PYTHON_VERSION_WARNING
PKG_CONFIG_PATH
PROFILE_PATH
PWD
PYTHONUNBUFFERED
SHLVL
SOME_APP_CONFIG_VAR
STACK
VENDOR_URL
)
if [[ "${STACK}" == "cedar-14" || "${STACK}" == "heroku-16" ]]; then
# Remove "OLDPWD" from expected_env_vars since for bash <4.4 it's not exported to subshells:
# https://github.com/heroku/heroku-buildpack-python/pull/1011#issuecomment-665117835
read -ra expected_env_vars <<< "${expected_env_vars[@]/OLDPWD/}"
fi
compile 'hooks' '' "${env_dir}"
assertCaptured "pre_compile ran!"
assertCaptured "pre_compile env: ${expected_env_vars[*]}."
assertCaptured "post_compile ran!"
assertCaptured "post_compile env: ${expected_env_vars[*]}."
assertCapturedSuccess
}
pushd $(dirname 0) >/dev/null pushd $(dirname 0) >/dev/null
popd >/dev/null popd >/dev/null
+9
View File
@@ -9,6 +9,7 @@ testPythonDefault() {
compile "pythonDefault" compile "pythonDefault"
assertCaptured $DEFAULT_PYTHON_VERSION assertCaptured $DEFAULT_PYTHON_VERSION
assertNotCaptured "security update" assertNotCaptured "security update"
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
assertCaptured "Installing SQLite3" assertCaptured "Installing SQLite3"
assertCapturedSuccess assertCapturedSuccess
} }
@@ -24,6 +25,7 @@ testPython2() {
assertNotCaptured "python-2-7-eol-faq"; assertNotCaptured "python-2-7-eol-faq";
fi fi
assertNotCaptured "security update" assertNotCaptured "security update"
assertCaptured "Installing pip 20.1.1, setuptools 44.1.1 and wheel 0.34.2"
assertCaptured "Installing SQLite3" assertCaptured "Installing SQLite3"
assertCapturedSuccess assertCapturedSuccess
} }
@@ -51,6 +53,7 @@ testPython3_4() {
compile "python3_4" compile "python3_4"
assertCaptured $LATEST_34 assertCaptured $LATEST_34
assertNotCaptured "security update" assertNotCaptured "security update"
assertCaptured "Installing pip 19.1.1, setuptools 43.0.0 and wheel 0.33.6"
# if cedar 14 and legacy binaries, fail. if cedar 14 and staging, succeed. # if cedar 14 and legacy binaries, fail. if cedar 14 and staging, succeed.
if [[ ! -n $USE_STAGING_BINARIES ]] && [[ $STACK == "cedar-14" ]]; then if [[ ! -n $USE_STAGING_BINARIES ]] && [[ $STACK == "cedar-14" ]]; then
assertCapturedError assertCapturedError
@@ -86,6 +89,7 @@ testPython3_5() {
compile "python3_5" compile "python3_5"
assertCaptured $LATEST_35 assertCaptured $LATEST_35
assertNotCaptured "security update" assertNotCaptured "security update"
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
assertCaptured "Installing SQLite3" assertCaptured "Installing SQLite3"
assertCapturedSuccess assertCapturedSuccess
} }
@@ -108,6 +112,7 @@ testPython3_6() {
compile "python3_6" compile "python3_6"
assertCaptured $LATEST_36 assertCaptured $LATEST_36
assertNotCaptured "security update" assertNotCaptured "security update"
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
assertCaptured "Installing SQLite3" assertCaptured "Installing SQLite3"
assertCapturedSuccess assertCapturedSuccess
} }
@@ -134,6 +139,7 @@ testPython3_7() {
else else
assertNotCaptured "security update" assertNotCaptured "security update"
assertCaptured $LATEST_37 assertCaptured $LATEST_37
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
assertCaptured "Installing SQLite3" assertCaptured "Installing SQLite3"
assertCapturedSuccess assertCapturedSuccess
fi fi
@@ -177,6 +183,7 @@ testPython3_8() {
else else
assertNotCaptured "security update" assertNotCaptured "security update"
assertCaptured $LATEST_38 assertCaptured $LATEST_38
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
assertCaptured "Installing SQLite3" assertCaptured "Installing SQLite3"
assertCapturedSuccess assertCapturedSuccess
fi fi
@@ -195,6 +202,7 @@ testPypy3_6() {
else else
assertCaptured "Installing pypy" assertCaptured "Installing pypy"
assertCaptured "$PYPY_36" assertCaptured "$PYPY_36"
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
assertCapturedSuccess assertCapturedSuccess
fi fi
} }
@@ -206,6 +214,7 @@ testPypy2_7() {
else else
assertCaptured "Installing pypy" assertCaptured "Installing pypy"
assertCaptured "$PYPY_27" assertCaptured "$PYPY_27"
assertCaptured "Installing pip 20.1.1, setuptools 44.1.1 and wheel 0.34.2"
assertCapturedSuccess assertCapturedSuccess
fi fi
} }
+8 -18
View File
@@ -56,21 +56,6 @@ resetCapture()
unset rtrn # deprecated unset rtrn # deprecated
} }
detect()
{
capture ${BUILDPACK_HOME}/bin/detect ${BUILD_DIR}
}
compile()
{
capture ${BUILDPACK_HOME}/bin/compile ${BUILD_DIR} ${CACHE_DIR}
}
release()
{
capture ${BUILDPACK_HOME}/bin/release ${BUILD_DIR}
}
updateVersion() updateVersion()
{ {
echo "$2" > "test/fixtures/${1}/runtime.txt" echo "$2" > "test/fixtures/${1}/runtime.txt"
@@ -234,13 +219,18 @@ default_process_types_cleanup() {
fi fi
} }
run_in_clean_env() {
# Prevent stray environment variables from outside the test runner being exposed to tests.
env -i HOME="${HOME}" LANG="${LANG}" PATH="${PATH}" STACK="${STACK}" "$@"
}
compile() { compile() {
default_process_types_cleanup default_process_types_cleanup
bp_dir=$(mktmpdir) bp_dir=$(mktmpdir)
compile_dir=$(mktmpdir) compile_dir=$(mktmpdir)
cp -a $(pwd)/* ${bp_dir} cp -a $(pwd)/* ${bp_dir}
cp -a ${bp_dir}/test/fixtures/$1/. ${compile_dir} cp -a ${bp_dir}/test/fixtures/$1/. ${compile_dir}
capture ${bp_dir}/bin/compile ${compile_dir} ${2:-$(mktmpdir)} $3 capture run_in_clean_env ${bp_dir}/bin/compile ${compile_dir} ${2:-$(mktmpdir)} $3
} }
compileDir() { compileDir() {
@@ -252,13 +242,13 @@ compileDir() {
local env_dir=$3 local env_dir=$3
cp -a $(pwd)/* ${bp_dir} cp -a $(pwd)/* ${bp_dir}
capture ${bp_dir}/bin/compile ${compile_dir} ${cache_dir} ${env_dir} capture run_in_clean_env ${bp_dir}/bin/compile ${compile_dir} ${cache_dir} ${env_dir}
} }
release() { release() {
bp_dir=$(mktmpdir) bp_dir=$(mktmpdir)
cp -a $(pwd)/* ${bp_dir} cp -a $(pwd)/* ${bp_dir}
capture ${bp_dir}/bin/release ${bp_dir}/test/fixtures/$1 capture run_in_clean_env ${bp_dir}/bin/release ${bp_dir}/test/fixtures/$1
} }
assertFile() { assertFile() {
-21
View File
@@ -1,21 +0,0 @@
#!/usr/bin/env bash
if [[ ! "$STACK" ]]; then
echo '$STACK must be set! (heroku-16 | cedar-14)'
exit 1
fi
if [[ "$STACK" == "cedar-14" ]]; then
make test-cedar-14
exit $?
fi
if [[ "$STACK" == "heroku-16" ]]; then
make test-heroku-16
exit $?
fi
if [[ "$STACK" == "heroku-18" ]]; then
make test-heroku-18
exit $?
fi
Binary file not shown.