mirror of
https://github.com/kennethreitz/heroku-buildpack-python.git
synced 2026-06-05 23:10:16 +00:00
Ed Morley
df7f8f3507
* Add a test for the cryptography (cffi) compile step Since it's currently untested. * Skip vendoring libffi/libmemcached on Heroku-16 Unlike for Cedar-14, Heroku-16 comes with these packages pre-installed: https://github.com/heroku/stack-images/blob/5a341970cfc1f201014262ad64c3b3e47514f663/heroku-16/installed-packages.txt#L111 https://github.com/heroku/stack-images/blob/5a341970cfc1f201014262ad64c3b3e47514f663/heroku-16/installed-packages.txt#L172 As such the build scripts had already been made a no-op on Heroku-16: https://github.com/heroku/heroku-buildpack-python/blob/fedae5ceda5a42f594012f911c3808dd5dc6fd9e/builds/libraries/vendor/libffi#L6-L9 https://github.com/heroku/heroku-buildpack-python/blob/fedae5ceda5a42f594012f911c3808dd5dc6fd9e/builds/libraries/vendor/libmemcache#L6-L9 ...meaning the Heroku-16 archives for them on S3 contain zero files. However until now, the buildpack was still unnecessarily downloading and extracting these empty archives - and not just on the first compile (like on cedar-14), but every compile since the directory check will never succeed.
39 lines
1.3 KiB
Bash
Executable File
39 lines
1.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# This script serves as the cffi build step of the
|
|
# [**Python Buildpack**](https://github.com/heroku/heroku-buildpack-python)
|
|
# compiler.
|
|
#
|
|
# A [buildpack](https://devcenter.heroku.com/articles/buildpacks) is an
|
|
# adapter between a Python application and Heroku's runtime.
|
|
#
|
|
# This script is invoked by [`bin/compile`](/).
|
|
|
|
if [[ "$STACK" == "heroku-16" ]]; then
|
|
# libffi is pre-installed in the stack image so there is no need to vendor it.
|
|
return 0
|
|
fi
|
|
|
|
# The location of the pre-compiled libffi binary.
|
|
VENDORED_LIBFFI="https://lang-python.s3.amazonaws.com/$STACK/libraries/vendor/libffi.tar.gz"
|
|
|
|
PKG_CONFIG_PATH="/app/.heroku/vendor/lib/pkgconfig:$PKG_CONFIG_PATH"
|
|
|
|
# Syntax sugar.
|
|
# shellcheck source=bin/utils
|
|
source "$BIN_DIR/utils"
|
|
|
|
# If a package using cffi exists within requirements, use vendored libffi.
|
|
if (pip-grep -s requirements.txt argon2-cffi bcrypt cffi cryptography django[argon2] Django[argon2] django[bcrypt] Django[bcrypt] PyNaCl pyOpenSSL PyOpenSSL requests[security] misaka &> /dev/null) then
|
|
|
|
if [ ! -d ".heroku/vendor/lib/libffi-3.1" ]; then
|
|
echo "-----> Noticed cffi. Bootstrapping libffi."
|
|
mkdir -p .heroku/vendor
|
|
# Download and extract libffi into target vendor directory.
|
|
curl "$VENDORED_LIBFFI" -s | tar zxv -C .heroku/vendor &> /dev/null
|
|
fi
|
|
|
|
LIBFFI=$(pwd)/vendor
|
|
export LIBFFI
|
|
fi
|