kennethreitz/pipenv
1
0
Fork 0
mirror of https://github.com/kennethreitz/pipenv.git synced 2026-06-05 22:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2808 from BoboTiG/fix-resource-warnings-tests

Browse Source 
Fix 2 ResourceWarning: unclosed file, in tests
This commit is contained in:
Tzu-ping Chung
2018-09-02 00:29:01 +08:00
committed by GitHub
parent 6687967fbf db104f0e4b
commit 0e47b1c8a5
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
news/2808.trivial
+1
View File
@@ -0,0 +1 @@
Fix 2 ResourceWarning: unclosed file, in tests.
tests/integration/test_install_twists.py
+4 -3
View File
@@ -210,9 +210,10 @@ Requests = "==2.14.0" # Inline comment
c = p.pipenv("install python_DateUtil")
assert c.return_code == 0
assert "python-dateutil" in p.pipfile["packages"]
contents = open(p.pipfile_path).read()
assert "# Pre comment" in contents
assert "# Inline comment" in contents
with open(p.pipfile_path) as f:
contents = f.read()
assert "# Pre comment" in contents
assert "# Inline comment" in contents
@pytest.mark.files
tests/integration/test_uninstall.py
+4 -3
View File
@@ -148,6 +148,7 @@ python_DateUtil = "*" # Inline comment
c = p.pipenv("uninstall python_dateutil")
assert "Requests" in p.pipfile["packages"]
assert "python_DateUtil" not in p.pipfile["packages"]
contents = open(p.pipfile_path).read()
assert "# Pre comment" in contents
assert "# Inline comment" in contents
with open(p.pipfile_path) as f:
contents = f.read()
assert "# Pre comment" in contents
assert "# Inline comment" in contents