diff --git a/news/2808.trivial b/news/2808.trivial new file mode 100644 index 00000000..04c2f48b --- /dev/null +++ b/news/2808.trivial @@ -0,0 +1 @@ +Fix 2 ResourceWarning: unclosed file, in tests. diff --git a/tests/integration/test_install_twists.py b/tests/integration/test_install_twists.py index 8653e2c0..c9dded43 100644 --- a/tests/integration/test_install_twists.py +++ b/tests/integration/test_install_twists.py @@ -210,9 +210,10 @@ Requests = "==2.14.0" # Inline comment c = p.pipenv("install python_DateUtil") assert c.return_code == 0 assert "python-dateutil" in p.pipfile["packages"] - contents = open(p.pipfile_path).read() - assert "# Pre comment" in contents - assert "# Inline comment" in contents + with open(p.pipfile_path) as f: + contents = f.read() + assert "# Pre comment" in contents + assert "# Inline comment" in contents @pytest.mark.files diff --git a/tests/integration/test_uninstall.py b/tests/integration/test_uninstall.py index d1d08eb0..e19a1400 100644 --- a/tests/integration/test_uninstall.py +++ b/tests/integration/test_uninstall.py @@ -148,6 +148,7 @@ python_DateUtil = "*" # Inline comment c = p.pipenv("uninstall python_dateutil") assert "Requests" in p.pipfile["packages"] assert "python_DateUtil" not in p.pipfile["packages"] - contents = open(p.pipfile_path).read() - assert "# Pre comment" in contents - assert "# Inline comment" in contents + with open(p.pipfile_path) as f: + contents = f.read() + assert "# Pre comment" in contents + assert "# Inline comment" in contents