From 4514c0cab3abdfad901a1fd5dfe26a8682957ded Mon Sep 17 00:00:00 2001 From: David Beitey Date: Mon, 11 Feb 2019 06:54:40 +0000 Subject: [PATCH 1/5] Docs: clarify quoting in version specs note Previously it was confusing as to what `" "` meant exactly -- I read it as a whitespace character was needed somewhere when it's referring to the double quote characters. --- docs/basics.rst | 2 +- news/3522.doc.rst | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 news/3522.doc.rst diff --git a/docs/basics.rst b/docs/basics.rst index 00f4c7d9..7dddcfc3 100644 --- a/docs/basics.rst +++ b/docs/basics.rst @@ -203,7 +203,7 @@ To make inclusive or exclusive version comparisons you can use: :: $ pipenv install "requests<=2.13" # will install a version equal or lower than 2.13.0 $ pipenv install "requests>2.19" # will install 2.19.1 but not 2.19.0 -.. note:: The use of ``" "`` around the package and version specification is highly recommended +.. note:: The use of double quotes around the package and version specification (i.e. ``"requests>2.19"``) is highly recommended to avoid issues with `Input and output redirection `_ in Unix-based operating systems. diff --git a/news/3522.doc.rst b/news/3522.doc.rst new file mode 100644 index 00000000..3d71061f --- /dev/null +++ b/news/3522.doc.rst @@ -0,0 +1 @@ +Clarify wording in Basic Usage example on using double quotes to escape shell redirection From 1ead1a86016e3df206b0d36ac0a6ea7ef6d62c0d Mon Sep 17 00:00:00 2001 From: James Stidard Date: Tue, 12 Feb 2019 12:23:25 +0000 Subject: [PATCH 2/5] shiney new code option comment --- pipenv/cli/options.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pipenv/cli/options.py b/pipenv/cli/options.py index 745275dd..76511d94 100644 --- a/pipenv/cli/options.py +++ b/pipenv/cli/options.py @@ -293,8 +293,9 @@ def code_option(f): if value: state.installstate.code = value return value - return option("--code", "-c", nargs=1, default=False, help="Import from codebase.", - callback=callback, expose_value=False)(f) + return option("--code", "-c", nargs=1, default=False, help="Install discovered" + "packages automatically from import statements.", callback=callback, + expose_value=False)(f) def deploy_option(f): From 451ddaedf39062ef302e370a57a00ad6fe50c78b Mon Sep 17 00:00:00 2001 From: James Stidard Date: Tue, 12 Feb 2019 12:30:39 +0000 Subject: [PATCH 3/5] second-guessed myself --- pipenv/cli/options.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pipenv/cli/options.py b/pipenv/cli/options.py index 76511d94..c83d7c95 100644 --- a/pipenv/cli/options.py +++ b/pipenv/cli/options.py @@ -293,8 +293,8 @@ def code_option(f): if value: state.installstate.code = value return value - return option("--code", "-c", nargs=1, default=False, help="Install discovered" - "packages automatically from import statements.", callback=callback, + return option("--code", "-c", nargs=1, default=False, help="Install packages " + "automatically discovered from import statements.", callback=callback, expose_value=False)(f) From 8f0b2cda6182fb1fa0bbd186df693b516d220d2c Mon Sep 17 00:00:00 2001 From: Kenneth Reitz Date: Sun, 10 Mar 2019 10:00:31 -0400 Subject: [PATCH 4/5] Create PEEP --- peeps/PEEP | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 peeps/PEEP diff --git a/peeps/PEEP b/peeps/PEEP new file mode 100644 index 00000000..aea8d00a --- /dev/null +++ b/peeps/PEEP @@ -0,0 +1,9 @@ +## PEEP-003: Subcommands + +NOT YET ACCEPTED + +Pipenv will automatically run commands like "pipenv deploy" if the "pipenv-deploy" binary is available on the path. + +These subcommands cannot overwrite built-in commands. + +These subcommands will receive environment variables with contextual information. From 11a555b0932f07f8b68c6e4eab4e61a7325a1094 Mon Sep 17 00:00:00 2001 From: Kenneth Reitz Date: Sun, 10 Mar 2019 10:01:14 -0400 Subject: [PATCH 5/5] Rename PEEP to PEEP-0004.md --- peeps/{PEEP => PEEP-0004.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename peeps/{PEEP => PEEP-0004.md} (100%) diff --git a/peeps/PEEP b/peeps/PEEP-0004.md similarity index 100% rename from peeps/PEEP rename to peeps/PEEP-0004.md