From 37b39330bfa02db03aba3c96fa7effef6711a69d Mon Sep 17 00:00:00 2001 From: Aron Bierbaum Date: Thu, 4 Aug 2022 09:13:07 -0500 Subject: [PATCH] Remove else clause that would always be triggered The else clause of a for loop is executed unless a break statement is executed to terminate the for loop. https://docs.python.org/3/reference/compound_stmts.html#the-for-statement --- pipenv/utils/indexes.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pipenv/utils/indexes.py b/pipenv/utils/indexes.py index b84e3b6f..f2770adf 100644 --- a/pipenv/utils/indexes.py +++ b/pipenv/utils/indexes.py @@ -78,14 +78,16 @@ def get_source_list( if extra_indexes: if isinstance(extra_indexes, str): extra_indexes = [extra_indexes] + for source in extra_indexes: extra_src = get_project_index(project, source) if not sources or extra_src["url"] != sources[0]["url"]: sources.append(extra_src) - else: - for source in project.pipfile_sources: - if not sources or source["url"] != sources[0]["url"]: - sources.append(source) + + for source in project.pipfile_sources: + if not sources or source["url"] != sources[0]["url"]: + sources.append(source) + if not sources: sources = project.pipfile_sources[:] if pypi_mirror: