kennethreitz/pipenv
1
0
Fork 0
mirror of https://github.com/kennethreitz/pipenv.git synced 2026-06-05 22:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #849 from auscompgeek/use-max-not-sorted

Browse Source 
cli: Use max() to determine latest version
This commit is contained in:
Kenneth Reitz
2017-10-07 09:45:49 -04:00
committed by GitHub
parent a15fa58de0 61290abbb3
commit a4551e6eb7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pipenv/cli.py
+2 -2
View File
@@ -141,7 +141,7 @@ def check_for_updates():
"""Background thread -- beautiful, isn't it?"""
try:
r = requests.get('https://pypi.python.org/pypi/pipenv/json', timeout=0.5)
latest = sorted([semver.parse_version_info(v) for v in list(r.json()['releases'].keys())])[-1]
latest = max(map(semver.parse_version_info, r.json()['releases'].keys()))
current = semver.parse_version_info(__version__)
if latest > current:
@@ -161,7 +161,7 @@ def ensure_latest_self(user=False):
except requests.RequestException as e:
click.echo(crayons.red(e))
sys.exit(1)
latest = sorted([semver.parse_version_info(v) for v in list(r.json()['releases'].keys())])[-1]
latest = max(map(semver.parse_version_info, r.json()['releases'].keys()))
current = semver.parse_version_info(__version__)
if current < latest: