Commit Graph

24 Commits

Author SHA1 Message Date
Jeremy Fleischman f42fcaa2b8 Misc doc updates (mostly around running tests)
This adds and documents a workaround for
https://github.com/pypa/pipenv/issues/4909. It feels a bit weird to
pretend to be CI just to run the test suite, though. Maybe we can do
something about that later.

I ran into a lot of trouble trying to get the tests to run when working
on https://github.com/pypa/pipenv/pull/4908, and that was largely
because the instructions in this CONTRIBUTING.md file seem to have
rotted.

1. The bit about "can be run very simply" is bogus. It's
   unfortunately not that simple right now.

2. `make test` (the docker approach) fails for me with this error:

    ```bash
    $ make test
    docker-compose up
    [+] Running 1/0
     ⠿ Container pipenv-pipenv-tests-1  Recreated                                                                  0.1s
    Attaching to pipenv-pipenv-tests-1
    pipenv-pipenv-tests-1  | Collecting certifi
    pipenv-pipenv-tests-1  |   Downloading https://files.pythonhosted.org/packages/37/45/946c02767aabb873146011e665728b680884cd8fe70dde973c640e45b775/certifi-2021.10.8-py2.py3-none-any.whl (149kB)
    pipenv-pipenv-tests-1  | Installing collected packages: certifi
    pipenv-pipenv-tests-1  | Successfully installed certifi-2021.10.8
    pipenv-pipenv-tests-1  | Path: /root/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    pipenv-pipenv-tests-1  | Installing Pipenv...
    pipenv-pipenv-tests-1  | Obtaining file:///pipenv
    pipenv-pipenv-tests-1  |     Complete output from command python setup.py egg_info:
    pipenv-pipenv-tests-1  |     Traceback (most recent call last):
    pipenv-pipenv-tests-1  |       File "<string>", line 1, in <module>
    pipenv-pipenv-tests-1  |       File "/pipenv/setup.py", line 55
    pipenv-pipenv-tests-1  |         print(f"\033[1m{s}\033[0m")
    pipenv-pipenv-tests-1  |                                  ^
    pipenv-pipenv-tests-1  |     SyntaxError: invalid syntax
    pipenv-pipenv-tests-1  |
    pipenv-pipenv-tests-1  |     ----------------------------------------
    pipenv-pipenv-tests-1  | Command "python setup.py egg_info" failed with error code 1 in /pipenv/
    pipenv-pipenv-tests-1 exited with code 1
    ```

    The docker image it relies upon
    (https://hub.docker.com/r/kennethreitz/pipenv-tests) hasn't been
    updated in 4 years, so I assume it's just not something people use
    anymore?

3. Relatedly, there was a `Dockerfile` at the root of this repo that
   appears to be unused. Let me know if it's used somewhere I'm not
   realizing, I can add it back!

4. https://kennethreitz.org/essays/be-cordial-or-be-on-your-way seems to
   be a broken link now. I found
   https://kennethreitz.org/essays/2013/01/27/be-cordial-or-be-on-your-way
   on Google.

5. `./run-tests.sh` doesn't work for me. It's failing for the same
   reason described by @ncoghlan here:
   https://github.com/pypa/pip/issues/7953#issuecomment-611928262. He
   said something about a `PIPENV_BOOTSTRAP` environment variable, but I
   can't find any information about that.
2022-01-07 00:01:33 -08:00
Dan Ryan e065e3c740 Update makefile with repatching scripts
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
2020-06-01 18:22:43 -04:00
Dan Ryan 8cc00622cc Update makefile to build docs
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
2020-05-20 15:58:49 -04:00
Dan Ryan 76eee5fff7 Update makefile rules and manifest
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
2020-04-28 23:13:40 -04:00
Dan Ryan d03d3ca0cb Overhaul makefile and allow universal wheels
- Add makefile tasks for building, checking builds, and simple version
  updates

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
2020-04-24 03:26:38 -04:00
Dan Ryan 83868c8f1a Cut over to devpi for tests and improve logging
- Verbose logs will now write gracefully to the terminal even while the
  spinner is running (i.e. during locking)
- This PR also cuts over to Devpi for a backing cache rather than a
  hacked httpbin instance
- Inclues a refactor of `pip_install` to deduplicate logic
- Attempts to switch back to relying on native editable installs in pip
  as the current implementation is broken on master (i.e. nothing is
  installed in the virtualenv)
- Fixes #3809

Signed-off-by: Dan Ryan <dan@danryan.co>
2019-06-25 01:26:49 -04:00
kennethreitz 6314586c9f black 2018-07-03 09:54:46 -04:00
kennethreitz c2495dcd99 update makefile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org>
2018-05-20 10:33:54 -04:00
kennethreitz 1f495db509 docker-compose based tests
Signed-off-by: Kenneth Reitz <me@kennethreitz.org>
2018-05-20 09:54:27 -04:00
kennethreitz 62740e2d02 changes
Signed-off-by: Kenneth Reitz <me@kennethreitz.org>
2018-03-06 12:32:13 -05:00
Jeff Tratner 40c7ce7dc1 install as editable with init 2018-02-17 09:19:28 -08:00
Derek Schaller 0676c65e06 add documentation to makefile 2018-02-17 08:47:10 -08:00
kennethreitz 281386b93b make man
Signed-off-by: Kenneth Reitz <me@kennethreitz.org>
2017-09-24 20:05:31 -04:00
kennethreitz 66a0bc8558 makefile
Signed-off-by: Kenneth Reitz <me@kennethreitz.org>
2017-09-23 10:43:08 -04:00
Nate Prewitt b72f2e56b0 We no longer need to lock for every build 2017-05-16 18:38:36 -06:00
Nate Prewitt d2bebd65c8 setup appveyor for pipenv 2017-04-25 14:19:59 -06:00
Nate Prewitt 32d9d88c05 updating run-tests in Makefile 2017-02-11 14:58:38 -07:00
Nate Prewitt 4d75bba0cb adding advanced doc section 2017-01-30 19:09:48 -07:00
kennethreitz 083872e9de fix tests 2017-01-23 14:31:52 -05:00
kennethreitz 40f7b479ad Update Makefile 2017-01-23 02:37:00 -05:00
Rene Dudfield 1cd72ed374 Using python -m pipenv inside the test. 2017-01-23 18:31:20 +11:00
kennethreitz 725f8567c9 fix travis tests 2017-01-22 14:07:41 -05:00
kennethreitz fd1ad2ca25 travis 2017-01-22 14:05:48 -05:00
kennethreitz f240862625 basics 2017-01-20 12:33:23 -05:00