From 09a5e28fc7605576d2409d42bf8f942ff6ec8d4d Mon Sep 17 00:00:00 2001 From: Eric Jolibois Date: Thu, 17 Dec 2020 23:09:19 +0100 Subject: [PATCH] ci: fix it by pinning importlib-metadata (#2202) `importlib-metadata` now requires python3.8+ or `typing-extensions` since [3.2.0](https://github.com/python/importlib_metadata/commit/530f5da8dd3a255f1198f29ea0126b8b25e644d8#diff-cc51f8e0c17159a1860664f70a89eba0d48c641f4deafe74912a7274dff91a34R15) And `pytest` doesn't pin the version of `importlib-metadata`. So on the CI when we uninstall `typing-extensions` **after** installing `pytest`, it crashes! Let's pin `importlib-metadata` to 3.1.0 for now --- tests/requirements-testing.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/requirements-testing.txt b/tests/requirements-testing.txt index 63e56b3..1a6b794 100644 --- a/tests/requirements-testing.txt +++ b/tests/requirements-testing.txt @@ -1,4 +1,6 @@ coverage==5.3 +# pin importlib-metadata as upper versions need typing-extensions to work if on python < 3.8 +importlib-metadata==3.1.0;python_version<"3.8" mypy==0.790 pytest==6.1.2 pytest-cov==2.10.1