From 853a6bbb76e1cf146d85bc4ed1acbfffd67dea13 Mon Sep 17 00:00:00 2001 From: Samuel Colvin Date: Sat, 11 Jul 2020 11:24:24 +0100 Subject: [PATCH] fix coverage for 'conset()' (#1704) --- pydantic/types.py | 3 --- tests/test_types.py | 8 ++++++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/pydantic/types.py b/pydantic/types.py index 4681f79..dd24711 100644 --- a/pydantic/types.py +++ b/pydantic/types.py @@ -190,9 +190,6 @@ class ConstrainedSet(set): # type: ignore @classmethod def set_length_validator(cls, v: 'Optional[Set[T]]', field: 'ModelField') -> 'Optional[Set[T]]': - if v is None and not field.required: - return None - v = set_validator(v) v_len = len(v) diff --git a/tests/test_types.py b/tests/test_types.py index 125d8fa..084b9d0 100644 --- a/tests/test_types.py +++ b/tests/test_types.py @@ -405,6 +405,14 @@ def test_conset(): assert exc_info.value.errors() == [{'loc': ('foo',), 'msg': 'value is not a valid set', 'type': 'type_error.set'}] +def test_conset_not_required(): + class Model(BaseModel): + foo: Set[int] = None + + assert Model(foo=None).foo is None + assert Model().foo is None + + class ConStringModel(BaseModel): v: constr(max_length=10) = 'foobar'