kennethreitz dc70eab069 Fix live export crash + cabinet dropped in two render paths; release 0.57.8 ...

- LiveEngine.export_recording() referenced an undefined NOTE_NAMES and
  crashed with NameError on every call. Define NOTE_NAMES in live.py.
- The cabinet (amp-sim) effect was applied for plain melodic parts but
  silently skipped for (a) parts with automation points and (b) drum
  parts — both effect-presence checks omitted it. Add cabinet to both.

Both are the same "a code path handles only part of the structure" class
as the recent MIDI/render/notation fixes.

New tests: export_recording roundtrip, cabinet-on-drums, cabinet-with-automation.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-22 09:44:13 -04:00

68 B

Raw Permalink History