From 4e87dc2c2d5b1626513e159f8b70a9241462324c Mon Sep 17 00:00:00 2001 From: qiyuan Date: Wed, 28 Feb 2018 11:13:57 +0800 Subject: [PATCH 1/2] fix issue 45 --- requests_html.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requests_html.py b/requests_html.py index d5890a2..979d1fb 100644 --- a/requests_html.py +++ b/requests_html.py @@ -154,7 +154,7 @@ class BaseParser: try: href = link.attrs['href'].strip() - if not href.startswith('#') and self.skip_anchors and href not in ['javascript:;']: + if not(href.startswith('#') and self.skip_anchors) and href not in ['javascript:;']: if href: yield href except KeyError: From 887a78bf23a3cfbc920345eb5497ccf2318e340e Mon Sep 17 00:00:00 2001 From: qiyuan Date: Wed, 28 Feb 2018 11:22:00 +0800 Subject: [PATCH 2/2] for is needless --- requests_html.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/requests_html.py b/requests_html.py index 979d1fb..c07aff3 100644 --- a/requests_html.py +++ b/requests_html.py @@ -160,7 +160,7 @@ class BaseParser: except KeyError: pass - return set(g for g in gen()) + return set(gen()) @property def absolute_links(self) -> Set[str]: @@ -184,7 +184,7 @@ class BaseParser: yield href - return set(g for g in gen()) + return set(gen()) @property def base_url(self) -> str: