Add ability to pass response to HTTPError()

Just a little refactoring, but it seems nicer to me to be able to pass
the response when constructing the `HTTPError` instance instead of
constructing it and then changing the member variable.
This commit is contained in:
Dmitry Medvinsky
2013-03-01 12:43:39 +04:00
parent d372a5b10b
commit c4f9340fb4
4 changed files with 18 additions and 5 deletions
+11 -1
View File
@@ -385,7 +385,17 @@ class RequestsTestCase(unittest.TestCase):
# undo monkey patch
HTTPConnectionPool.urlopen = old_urlopen
def test_http_error(self):
error = requests.exceptions.HTTPError()
self.assertEqual(error.response, None)
response = requests.Response()
error = requests.exceptions.HTTPError(response=response)
self.assertEqual(error.response, response)
error = requests.exceptions.HTTPError('message', response=response)
self.assertEqual(str(error), 'message')
self.assertEqual(error.response, response)
if __name__ == '__main__':
unittest.main()