requests

mirror of https://github.com/kennethreitz/requests.git synced 2026-06-05 22:50:18 +00:00

Files

T

Kevin Burke ae1ac2d4e0 Flip conditional in session.send()

Previously we checked that the `request` being sent was an instance of a
PreparedRequest. If a user somehow created a PreparedRequest using a different
Requests library instance, this check makes the request un-sendable.

(This happened recently - unbeknownst to me, my server was running an outdated
version of pip, vulnerable to this issue - pypa/pip#1489, which creates
multiple subdirectories (src/requests, src/requests/requests) when you rerun
pip install --target. So the PreparedRequest was being created in one version
of the library and compared against the other version of the library, and
throwing this exception, even though they were both PreparedRequest instances!)

It would probably be preferable to check the object's behavior (instead of
its type), but a PreparedRequest has a lot of behavior, and it wouldn't be
really feasible or allow us to provide a helpful error message to check all
of it here. Instead flip the conditional to guard against the user sending an
unprepared Request, which should still give us most of the benefits of the
better error message.

Fixes #3102

2016-04-21 08:12:05 -07:00

testserver

Fixed indenting issues

2016-04-11 20:03:23 +02:00

__init__.py

Added tests module.

2016-02-05 13:21:57 +01:00

compat.py

Added tests module.

2016-02-05 13:21:57 +01:00

conftest.py

Added tests module.