kennethreitz
b8128d6b1e
Merge pull request #1962 from sigmavirus24/fix-history-type
...
Fix #1960 : A Response's history should be a list
2014-03-24 11:45:06 -04:00
kennethreitz
5f48e4a120
Merge pull request #1963 from sigmavirus24/fix-redirect-methods
...
Fix #1955 : Do not use original request in redirect
2014-03-24 11:44:14 -04:00
Cory Benfield
90f7337858
Style changes thanks to @sigmavirus24.
2014-03-22 21:11:33 +00:00
Ian Cordasco
8fc6a65be8
Actually assign history
2014-03-15 12:48:29 -05:00
Ian Cordasco
8d693a2a27
Fix #1955 : Do not use original request in redirect
...
The original request was never being properly overriden in resolve_redirects.
As such being having a POST request respond with a 303 would generate a GET
request. If the GET request encountered another redirect to something like a
307, then it would use the original request and generate another POST request.
There are two parts to this fix:
- The fix itself
- The test infrastructure to ensure it does not regress because HTTPBin is
insufficient
2014-03-15 11:38:13 -05:00
Ian Cordasco
daf56b3f62
Fix #1960 : A Response's history should be a list
2014-03-15 10:33:00 -05:00
Cory Benfield
4f6dca42ea
Remove some extraneous comments to please KR.
2014-03-12 21:21:14 +00:00
Cory Benfield
4d8cb3244e
Add method for rebuilding proxy configuration.
...
This includes auth.
2014-03-12 19:22:40 +00:00
Cory Benfield
97cf16e958
Move auth rebuild to its own method.
2014-03-12 19:22:11 +00:00
kennethreitz
3c4b3747e4
Merge pull request #1921 from sigmavirus24/fix-session-header-none
...
Do not set headers with None value
2014-03-03 13:13:13 -05:00
Cory Benfield
81e88b70bd
The timeout is in seconds.
2014-02-16 19:00:22 +00:00
Ian Cordasco
d2f647cee4
Do not set headers with None value
...
- Regardless of whether they are on the session or not
- Fixes #1920
2014-02-14 16:15:21 -06:00
Zack Weinberg
0caa243212
New Response property, .is_redirect.
2014-02-13 14:27:42 -05:00
Kenneth Reitz
c042c08179
who did this
2014-01-31 12:29:56 -05:00
Kenneth Reitz
f74f5e3ebf
cleanup shitty code
2014-01-31 12:27:05 -05:00
Cory Benfield
d9f34c6848
Respect trust_env on redirect.
2014-01-31 07:36:44 +00:00
Cory Benfield
326a22e888
Better layout for checking.
2014-01-30 15:11:24 +00:00
Cory Benfield
7ba5a534ae
Repopulate ~/.netrc auth.
2014-01-29 19:13:46 +00:00
Konstantinos Koukopoulos
8b792be81b
on redirect pass URL as bytes. Fixes : #1887
2014-01-28 09:11:23 -08:00
Kevin Burke
a0e7706440
Fix warnings when building the docs
...
It may be nice to make builds fail if new documentation generates warnings, to
avoid these sorts of problems slipping in in the future.
2013-12-28 00:09:29 -08:00
Ian Cordasco
642bbf6060
Fixes #1805
...
Sure cookies are persisted to the session, but those new cookies are not added
to the next prepared request. We need to update that new request's CookieJar
with the new cookies.
2013-12-17 22:55:50 -06:00
Ian Cordasco
e8bdcdb0a7
Address feedback from #1729
...
- Make the PreparedRequest's cookie jar an implementation detail
2013-12-04 06:45:18 -06:00
Chase Sterling
8bfe0d873f
Store the request cookiejar in PreparedRequest.cookies fix #1728
...
Conflicts:
requests/sessions.py
2013-12-04 06:38:58 -06:00
kennethreitz
5c915451e7
Merge pull request #1657 from sigmavirus24/fix-session-hooks
...
Honor session hooks
2013-12-03 17:33:42 -08:00
daftshady
c26a6c310c
remove unused import
2013-11-26 15:38:48 +09:00
daftshady
1adba3c9e9
modified 'merge_cookies' and update tests.
...
made sessions.py to use that method when merging cookies.
2013-11-26 15:28:59 +09:00
daftshady
e40c1637c9
added new method 'merge_cookies' and use it when merging session cookies with param cookies.
2013-11-26 15:28:59 +09:00
daftshady
2bbd7ba1c2
Fixed #1711
2013-11-26 15:22:46 +09:00
Cory Benfield
3369d87da9
Cleanup the redirect if blocks.
2013-11-24 11:13:49 +00:00
Cory Benfield
470af31f4a
Handle 301s 'properly'.
2013-11-24 11:09:00 +00:00
daftshady
4972133a9b
use geturl to lower scheme
2013-11-19 19:54:46 +09:00
daftshady
8c8938e8cb
issue #1746 : Don't lowercase the whole URL!
2013-11-19 18:59:22 +09:00
daftshady
1511dfa637
moved logic to Session object and added test case
2013-11-04 22:32:17 +09:00
Can Ibanoglu
0cd6959f19
Removed extra extra parentheses in SessionRedirectMixin.resolve_redirects
2013-10-22 23:48:04 +03:00
Ian Cordasco
a4605fe324
Fix failing test to preserve behaviour
2013-10-07 21:17:59 -05:00
kennethreitz
318ca102cd
Merge pull request #1635 from daftshady/dev
...
Fixed #1630 and added test case.
2013-10-07 16:22:49 -07:00
Ian Cordasco
5bf396d5d1
Honor session hooks
2013-10-07 12:23:16 -05:00
daftshady
012f0334ce
added param to cookiejar_from_dict instead of creating new method.
2013-09-29 01:08:58 +09:00
Cory Benfield
0051837af4
Correctly lowercase a redirect scheme.
2013-09-28 17:01:32 +01:00
daftshady
d22eaf96e2
Fixed #1630
2013-09-28 23:44:27 +09:00
daftshady
39fe0068aa
Fixed #1630 , added test case for cookie persistence.
2013-09-28 16:33:05 +09:00
Kenneth Reitz
54ad646067
merge 2.0 insto master
2013-09-24 14:13:28 -04:00
Kenneth Reitz
58376489af
Merge pull request #1585 from rvoicilas/master
...
Use values() when the keys are not being used
2013-09-24 10:45:46 -07:00
kracekumar
a829ef9b46
Fixed persistence spelling
2013-09-10 17:52:29 +05:30
Radu Voicilas
056da86f6d
Use values() when the keys are not being used
2013-09-09 15:21:36 +03:00
Kenneth Reitz
bd1f1404a0
Merge branch 'fix_401_cookies' of git://github.com/sigmavirus24/requests into 2.0
2013-07-31 21:33:24 -04:00
Robert Estelle
0ab7a52f7c
Merge settings when creating PreparedRequest, don't copy Request.
2013-07-31 13:42:02 -07:00
Robert Estelle
9edba838b3
Skip unneccessary Request.copy in Session.request
2013-07-30 22:59:11 -07:00
Robert Estelle
b5c136152f
Prepare requests with session settings separately from sending.
2013-07-30 21:39:36 -07:00
Ian Cordasco
286ddb672d
Take advantage of the new copy method
2013-07-27 23:08:46 -04:00