c69e3eed31
Close and then release the connection
...
urllib3 closes the underlying connection when we call
urllib3.Response.close but does not release it back to the connection
pool. This can cause issues when users have a blocking connection pool
configured and connections are not readily returned to the pool.
Since the underlying connection is closed, we should be able to safely
return the connection to the connection pool, so to fix this issue we
merely need to not return after closing the response.
Closes gh-3461
2016-07-30 07:16:18 -05:00
5453b88f8f
Spelling fixes
2016-07-26 15:24:29 +03:00
kennethreitz
fb01456061
Merge pull request #3429 from nateprewitt/docstring_cleanup
...
Docstring cleanup
2016-07-20 18:38:38 -04:00
b7809acb47
making class and function docstrings consistent
2016-07-20 11:43:47 -06:00
2d4a89f5dc
adding in pep8 fixes
2016-07-20 10:30:08 -06:00
7700ecae14
Support responses like HTTP/1.1 404 Unicode chars ( #3385 )
2016-07-05 09:01:19 -05:00
bd9e8f2271
Merge pull request #3366 from nateprewitt/2947-no-returns-in-header
...
check for headers containing return characters
2016-07-02 20:32:17 +01:00
2669ab797c
check and test for headers containing return characters or leading whitespace
2016-07-02 13:10:47 -06:00
0c08ca7154
updating docstring to match functionality
2016-07-02 08:43:23 -06:00
0bcf634135
Allow None value for chunk_size again ( #3368 )
2016-06-30 19:11:01 -05:00
cf3c99890d
added in type check for chunk_size
2016-06-27 19:58:15 -06:00
49b69c4751
Merge pull request #3178 from haikuginger/master
...
Encoding JSON requests to bytes for urllib3 to handle
2016-05-22 17:02:09 +01:00
cb4c2c0b65
Fix TypeError when get json-encoded content of a response
...
``self.content`` could be ``None``, so ``len(self.content)`` may raise ``TypeError: object of type 'NoneType' has no len()``
2016-05-06 09:53:14 +08:00
52c0daff5f
Cleaning up comment on JSON encoding to be more strictly relevant.
2016-05-05 12:12:49 -04:00
9ff2e43cd6
Removing charset from JSON content type; tightening requirements on .encode()
2016-05-05 06:27:12 -04:00
386382b18c
Encoding JSON requests to bytes for urllib3 to handle; ensuring same with testing.
2016-05-04 20:09:07 -04:00
fb230709a8
Fix for the test ?
2016-04-08 22:23:35 +03:00
b8a577050d
Update docstring and API doc to document ability to add per-file headers in multipart POST
...
* Docstring only change - for the function itself cf. requests Issue #1640
2016-03-29 11:57:47 +01:00
fc8fa1aa26
Fix regression from #2844 regarding binary bodies.
2015-12-16 14:56:13 +00:00
40ce36671c
Merge pull request #2896 from BraulioVM/master
...
[WIP] Set 'Transfer-Encoding: chunked' if data is a file with length 0
2015-12-02 08:35:41 -06:00
23d9b077d8
Fix typos
2015-12-01 12:24:56 +01:00
4c82dbab6f
Fix 'Transfer-Encoding: chunked' change
2015-11-24 13:42:13 +01:00
6f6b2fd1d5
Set 'Transfer-Encoding: chunked' if data file length equals 0
2015-11-23 20:52:06 +01:00
edc68a0ac8
fix issue #2844
2015-10-23 15:22:36 +03:00
2df3c7c75d
Move to_native_string for methods to prepare()
2015-10-12 10:50:37 +01:00
3948a9562d
Use general null check for JSON
2015-10-08 14:53:35 +01:00
f6afa71281
Merge pull request #2763 from ravipra/json_supersedes
...
Fixed issue #2756
2015-10-05 15:27:53 +01:00
bf38d5bf52
Update models.py
...
Updated Documentation:
```data``` as well as ```files``` supersedes json
2015-10-02 13:50:52 +05:30
7a0cd16c1a
changed the null check for 'data' parameter to be more explicit.
...
removed the superfluous encode from the testcase.
2015-09-09 13:04:24 +05:30
37037607b5
Fixed issue #2756
...
Now 'json' parameter will be used to prepare body only if the 'data'
parameter is not present
2015-09-08 14:45:46 +05:30
e3bdec5934
Display URL as part of HTTP error messages
...
It seems convenient to include the URL in the error message in case you
get an unexpected error.
E.g.:
In [1]: import requests
In [2]: resp = requests.get('http://www.google.com/eofdfdfdfdfd ')
In [3]: resp
Out[3]: <Response [404]>
In [4]: resp.raise_for_status()
---------------------------------------------------------------------------
HTTPError Traceback (most recent call last)
<ipython-input-4-00e7077cfb5b> in <module>()
----> 1 resp.raise_for_status()
/Users/marca/dev/git-repos/requests/requests/models.py in raise_for_status(self)
835
836 if http_error_msg:
--> 837 raise HTTPError(http_error_msg, response=self)
838
839 def close(self):
HTTPError: 404 Client Error: Not Found for url: http://www.google.com/eofdfdfdfdfd
2015-06-22 13:22:59 -07:00
1da62a65d9
fix contextlib.closing bug for sessions where content is not consumed (issue #2593 )
2015-05-24 15:01:34 -04:00
639f8347a3
Merge pull request #2598 from Lukasa/not-poor
...
Partially revert ab84f9be57
2015-05-14 17:32:19 -05:00
553907aa6b
Use complexjson everywhere
2015-05-14 22:30:24 +01:00
fb6dade63d
Partially revert ab84f9be57
2015-05-14 20:58:20 +01:00
c6c8d649af
do not blindly catch all AttributeErrors
...
see shazow/urllib3#618
2015-05-12 23:21:03 +00:00
kennethreitz
868625532d
Merge remote-tracking branch 'origin/master'
2015-05-06 12:42:47 -07:00
kennethreitz
74609c5c8f
cleanup styles a bit
2015-05-06 12:42:43 -07:00
kennethreitz
ab84f9be57
removed poor code
2015-05-06 12:36:26 -07:00
35045e851a
Simplify PreparedRequest.prepare API
...
Do not require that hooks be passed as an empty list to
PreparedRequest.prepare. In the event hooks is None in prepare or
prepare_hooks, use an empty list as a default.
Related to #2552
2015-04-20 20:13:58 -05:00
a0632d8df0
Minor formatting change
2015-04-10 22:03:26 -05:00
599f834351
fix bug 2540
2015-04-11 03:29:21 +03:00
f02d0f9e79
Fix bug 2540
2015-04-11 01:41:02 +03:00
f89b5a5d90
fix bug 2540
2015-04-11 00:23:07 +03:00
e3c7b43fc9
#2532 : Documented strange behaviour in "PreparedRequest.prepare_cookies", caused by cookielib. Also documented a workaround if absolutely necessary.
2015-04-06 21:00:51 +03:00
36093e69c7
Copy a PreparedRequest's CookieJar reliably
...
When a PreparedRequests's cookie jar is not a RequestsCookieJar instance, it
will not have a "copy" method. By adding _copy_cookie_jar we can reliably copy
cookie jars so that we have an actual copy instead of the same instance on
different prepared requests.
This also updates the RequestsCookieJar.update logic to create copies of
cookies from the other jar.
Closes #2527
2015-04-05 21:49:52 -05:00
54791d1970
Expand on what 'elapsed' means.
2015-03-21 16:27:21 +00:00
bbbd9de6fd
Merge pull request #2472 from scholer/master
...
Avoid data duplication when creating a Request with str/bytes/bytearray input
2015-03-14 07:43:17 -05:00
4497a26c37
Document Response.iter_lines() reentrancy issues
2015-03-07 12:00:41 +02:00
ec700a9a13
Avoid duplicating files data when creating a Request with str/bytes/bytearray in the files argument. 30-40% performance improvement.
2015-03-04 10:21:38 -05:00
Ian Cordasco
kennethreitz