messense
cb4c2c0b65
Fix TypeError when get json-encoded content of a response
...
``self.content`` could be ``None``, so ``len(self.content)`` may raise ``TypeError: object of type 'NoneType' has no len()``
2016-05-06 09:53:14 +08:00
tzickel
fb230709a8
Fix for the test ?
2016-04-08 22:23:35 +03:00
Alexander Hermes
b8a577050d
Update docstring and API doc to document ability to add per-file headers in multipart POST
...
* Docstring only change - for the function itself cf. requests Issue #1640
2016-03-29 11:57:47 +01:00
Cory Benfield
fc8fa1aa26
Fix regression from #2844 regarding binary bodies.
2015-12-16 14:56:13 +00:00
Ian Cordasco
40ce36671c
Merge pull request #2896 from BraulioVM/master
...
[WIP] Set 'Transfer-Encoding: chunked' if data is a file with length 0
2015-12-02 08:35:41 -06:00
Jakub Wilk
23d9b077d8
Fix typos
2015-12-01 12:24:56 +01:00
Braulio Valdivielso Martínez
4c82dbab6f
Fix 'Transfer-Encoding: chunked' change
2015-11-24 13:42:13 +01:00
Braulio Valdivielso Martínez
6f6b2fd1d5
Set 'Transfer-Encoding: chunked' if data file length equals 0
2015-11-23 20:52:06 +01:00
Alex Khomchenko
edc68a0ac8
fix issue #2844
2015-10-23 15:22:36 +03:00
Cory Benfield
2df3c7c75d
Move to_native_string for methods to prepare()
2015-10-12 10:50:37 +01:00
Cory Benfield
3948a9562d
Use general null check for JSON
2015-10-08 14:53:35 +01:00
Cory Benfield
f6afa71281
Merge pull request #2763 from ravipra/json_supersedes
...
Fixed issue #2756
2015-10-05 15:27:53 +01:00
sumitbinnani
bf38d5bf52
Update models.py
...
Updated Documentation:
```data``` as well as ```files``` supersedes json
2015-10-02 13:50:52 +05:30
Ravi Prakash Putchala
7a0cd16c1a
changed the null check for 'data' parameter to be more explicit.
...
removed the superfluous encode from the testcase.
2015-09-09 13:04:24 +05:30
Ravi Prakash Putchala
37037607b5
Fixed issue #2756
...
Now 'json' parameter will be used to prepare body only if the 'data'
parameter is not present
2015-09-08 14:45:46 +05:30
Marc Abramowitz
e3bdec5934
Display URL as part of HTTP error messages
...
It seems convenient to include the URL in the error message in case you
get an unexpected error.
E.g.:
In [1]: import requests
In [2]: resp = requests.get('http://www.google.com/eofdfdfdfdfd ')
In [3]: resp
Out[3]: <Response [404]>
In [4]: resp.raise_for_status()
---------------------------------------------------------------------------
HTTPError Traceback (most recent call last)
<ipython-input-4-00e7077cfb5b> in <module>()
----> 1 resp.raise_for_status()
/Users/marca/dev/git-repos/requests/requests/models.py in raise_for_status(self)
835
836 if http_error_msg:
--> 837 raise HTTPError(http_error_msg, response=self)
838
839 def close(self):
HTTPError: 404 Client Error: Not Found for url: http://www.google.com/eofdfdfdfdfd
2015-06-22 13:22:59 -07:00
colin
1da62a65d9
fix contextlib.closing bug for sessions where content is not consumed (issue #2593 )
2015-05-24 15:01:34 -04:00
Ian Cordasco
639f8347a3
Merge pull request #2598 from Lukasa/not-poor
...
Partially revert ab84f9be57
2015-05-14 17:32:19 -05:00
Cory Benfield
553907aa6b
Use complexjson everywhere
2015-05-14 22:30:24 +01:00
Cory Benfield
fb6dade63d
Partially revert ab84f9be57
2015-05-14 20:58:20 +01:00
Thomas Weißschuh
c6c8d649af
do not blindly catch all AttributeErrors
...
see shazow/urllib3#618
2015-05-12 23:21:03 +00:00
kennethreitz
868625532d
Merge remote-tracking branch 'origin/master'
2015-05-06 12:42:47 -07:00
kennethreitz
74609c5c8f
cleanup styles a bit
2015-05-06 12:42:43 -07:00
kennethreitz
ab84f9be57
removed poor code
2015-05-06 12:36:26 -07:00
Ian Cordasco
35045e851a
Simplify PreparedRequest.prepare API
...
Do not require that hooks be passed as an empty list to
PreparedRequest.prepare. In the event hooks is None in prepare or
prepare_hooks, use an empty list as a default.
Related to #2552
2015-04-20 20:13:58 -05:00
Ian Cordasco
a0632d8df0
Minor formatting change
2015-04-10 22:03:26 -05:00
sh1buy
599f834351
fix bug 2540
2015-04-11 03:29:21 +03:00
sh1buy
f02d0f9e79
Fix bug 2540
2015-04-11 01:41:02 +03:00
sh1buy
f89b5a5d90
fix bug 2540
2015-04-11 00:23:07 +03:00
Smiley Barry
e3c7b43fc9
#2532 : Documented strange behaviour in "PreparedRequest.prepare_cookies", caused by cookielib. Also documented a workaround if absolutely necessary.
2015-04-06 21:00:51 +03:00
Ian Cordasco
36093e69c7
Copy a PreparedRequest's CookieJar reliably
...
When a PreparedRequests's cookie jar is not a RequestsCookieJar instance, it
will not have a "copy" method. By adding _copy_cookie_jar we can reliably copy
cookie jars so that we have an actual copy instead of the same instance on
different prepared requests.
This also updates the RequestsCookieJar.update logic to create copies of
cookies from the other jar.
Closes #2527
2015-04-05 21:49:52 -05:00
Cory Benfield
54791d1970
Expand on what 'elapsed' means.
2015-03-21 16:27:21 +00:00
Ian Cordasco
bbbd9de6fd
Merge pull request #2472 from scholer/master
...
Avoid data duplication when creating a Request with str/bytes/bytearray input
2015-03-14 07:43:17 -05:00
Priit Laes
4497a26c37
Document Response.iter_lines() reentrancy issues
2015-03-07 12:00:41 +02:00
Rasmus Scholer (TimelineX)
ec700a9a13
Avoid duplicating files data when creating a Request with str/bytes/bytearray in the files argument. 30-40% performance improvement.
2015-03-04 10:21:38 -05:00
Rasmus Scholer (TimelineX)
11b12c3e07
models.RequestEncodingMixin._encode_files now takes bytearray as fp in addition to the currently supported bytes and str input.
2015-03-03 02:44:52 +01:00
Ian Cordasco
bd3cf95e34
Fix error handling on Python 3
2014-12-16 22:49:24 -06:00
Ian Cordasco
386c589ba0
Merge branch 'master' of https://github.com/ContinuousFunction/requests into pr/2344
2014-12-16 22:18:51 -06:00
daftshady
925e975295
catch exception more specifically in Response.ok
2014-12-16 16:55:13 +09:00
ContinuousFunction
3246b1fe17
Changed ConnectionError to InvalidURL
2014-11-17 20:06:24 -08:00
ContinuousFunction
087a27aba9
Partially addresses Issue #1572
...
Addresses the LocationParseError but not the DecodeError from
kennethreitz#1572. When running
test_requests.py, I got an error in test_session_pickling which resulted
in a TypeError. I'm not sure of the reason for the TypeError but I have
commented out that test.
2014-11-15 16:58:25 -08:00
Alexander Nelzin
ee50afef59
Fixed.
2014-11-12 15:35:27 +03:00
Val Tenyotkin
3602690886
Changing parameter name newline ==> delimiter.
2014-10-24 16:37:35 -07:00
Val Tenyotkin
f5ff05be1e
Adding a custom line delimiter to iter_lines()
2014-10-21 18:03:11 -07:00
kennethreitz
6da438dabd
Merge pull request #2268 from sigmavirus24/fix-params
...
Re-order params for backwards compat
2014-10-06 05:40:03 -04:00
Ian Cordasco
0e4efab270
Re-order params for backwards compat
2014-10-05 18:55:59 -05:00
MinRK
ca2ebc5b68
allow unicode URLs on Python 2
...
on Python 2 u'é'.decode('utf8') fails with UnicodeEncodeError,
but only AttributeError is caught.
This only calls decode on known bytes objects.
2014-10-05 16:30:11 -07:00
kennethreitz
65cdccb70f
Merge pull request #2241 from tijko/master
...
raise RuntimeError when a single streamed request calls *iter methods th...
2014-10-05 12:48:40 -04:00
kennethreitz
1e79cf6a47
Merge pull request #2258 from willingc/add-json
...
Add json parameter
2014-10-05 12:46:09 -04:00
Ian Cordasco
8ed941fa69
Fix a couple of issues I noticed
...
- Don't _ prefix json in prepare_body
- Don't initialize json to []
- Don't initialize json to {}
- Reorder parameters to PreparedRequest.prepare
- Remove extra parentheses
- Update docstring
2014-09-30 16:03:31 -05:00