kennethreitz
53d02381e2
Merge pull request #2349 from sigmavirus24/fix-pickling
...
Properly serialize RecentlyUsedContainers for cache
2014-11-30 14:12:43 -05:00
Matt Robenolt
2a5364cf72
url was already parsed, don't urlparse twice
2014-11-23 17:54:44 -08:00
Ian Cordasco
c8baf88125
Properly serialize RecentlyUsedContainers for cache
...
RecentlyUsedContainers are threadsafe so they require a lock and as such
cannot be serialized with pickle directly. To handle it, we need to
convert it to a dictionary first and then back when deserializing.
Fixes #2345
2014-11-17 22:16:32 -06:00
Ian Cordasco
431282e778
Merge pull request #2299 from mattrobenolt/master
...
Cap the redirect_cache size to prevent memory abuse
2014-11-07 14:18:41 -06:00
Ian Cordasco
29ef108158
Use to_native_string instead of builtin_str
...
Fixes #2316
2014-10-31 21:20:04 -05:00
Matt Robenolt
387c8f852c
Cap the redirect_cache size to prevent memory abuse
2014-10-27 09:20:06 -07:00
Ian Cordasco
0e4efab270
Re-order params for backwards compat
2014-10-05 18:55:59 -05:00
kennethreitz
1e79cf6a47
Merge pull request #2258 from willingc/add-json
...
Add json parameter
2014-10-05 12:46:09 -04:00
Ian Cordasco
b1f3a2dd66
Remove timeout from __attrs__
...
We do not allow the user to set the timeout value on the Session any longer so
this is extraneous
2014-10-04 23:04:36 -05:00
Ian Cordasco
8ed941fa69
Fix a couple of issues I noticed
...
- Don't _ prefix json in prepare_body
- Don't initialize json to []
- Don't initialize json to {}
- Reorder parameters to PreparedRequest.prepare
- Remove extra parentheses
- Update docstring
2014-09-30 16:03:31 -05:00
Ian Cordasco
ac44b48297
Avoid getting stuck in a loop
...
This prevents a case where we make a request to URL A, which 301s to B which
would then 301 back to A. Alternatively, for less simple schemes, this will
also prevent us from getting stuck in a loop, e.g., it will prevent the
following from causing an endless loop:
A -> B -> C -> D -> E -> F --
^ \
| /
---<------------<----------<-
2014-09-22 21:01:36 -05:00
Ian Cordasco
27c83f7177
Fix #2207
...
@Lukasa wrote the fix in #2207
2014-09-07 12:02:23 -05:00
Kevin Burke
dfa41afd43
Document Timeout behaviour
2014-08-29 11:50:11 -07:00
Carol Willing
8f17741849
Adds json parameter for POST requests
2014-08-28 12:53:19 -07:00
Ian Cordasco
596ca83f0c
Update verify check and doc-string
2014-08-26 14:20:19 -05:00
Ian Cordasco
b4a7906bca
Add Session method to merge environment settings with per-request settings
2014-08-26 14:20:19 -05:00
ContinuousFunction
c7e087cf56
Added space and sentence case
...
Added space and sentence case as requested by sigmavirus24.
https://github.com/kennethreitz/requests/pull/2168
2014-08-21 11:05:02 -07:00
ContinuousFunction
2fc6e8a894
Update on Tracking Previous Requests
...
Modified the comment in sessions.py and rewrote the test in
test_requests.py
2014-08-19 10:51:26 -07:00
ContinuousFunction
df641e74ff
Tracking Previous Requests
...
Addresses the issue brought up here:
https://github.com/kennethreitz/requests/issues/1929
2014-08-17 19:13:26 -07:00
Ian Cordasco
3957b0befb
Fix silly check
2014-07-02 10:42:00 -05:00
Ian Cordasco
84f67379c8
Update how we check verify when inspecting env variables
2014-07-02 10:26:15 -05:00
Eric L Frederich
c3444f8c7a
don't make duplicate requests for permanent redirects
2014-06-12 08:25:21 -04:00
Eric L Frederich
ec3a2e6f04
rename resume/resume_incomplete to permanent_redirect according to rfc7238
...
Use temporary_redirect intead of temporary_moved to make the words
line up nicely ;-)
2014-06-11 11:08:10 -04:00
Cory Benfield
22433163b3
Update trivial mentions to RFC 2616.
2014-06-07 09:53:12 +01:00
schlamar
59c8d81381
Read content in Session.send instead of Adapter.send.
2014-05-12 22:42:54 +02:00
schlamar
c2a1f28a2e
Catch possible exceptions while consuming content of redirect responses.
2014-05-12 22:42:53 +02:00
Cory Benfield
459f8dfccb
Don't repopulate proxies if we don't trust the env.
2014-04-26 13:05:01 +01:00
kennethreitz
b8128d6b1e
Merge pull request #1962 from sigmavirus24/fix-history-type
...
Fix #1960 : A Response's history should be a list
2014-03-24 11:45:06 -04:00
kennethreitz
5f48e4a120
Merge pull request #1963 from sigmavirus24/fix-redirect-methods
...
Fix #1955 : Do not use original request in redirect
2014-03-24 11:44:14 -04:00
Cory Benfield
90f7337858
Style changes thanks to @sigmavirus24.
2014-03-22 21:11:33 +00:00
Ian Cordasco
8fc6a65be8
Actually assign history
2014-03-15 12:48:29 -05:00
Ian Cordasco
8d693a2a27
Fix #1955 : Do not use original request in redirect
...
The original request was never being properly overriden in resolve_redirects.
As such being having a POST request respond with a 303 would generate a GET
request. If the GET request encountered another redirect to something like a
307, then it would use the original request and generate another POST request.
There are two parts to this fix:
- The fix itself
- The test infrastructure to ensure it does not regress because HTTPBin is
insufficient
2014-03-15 11:38:13 -05:00
Ian Cordasco
daf56b3f62
Fix #1960 : A Response's history should be a list
2014-03-15 10:33:00 -05:00
Cory Benfield
4f6dca42ea
Remove some extraneous comments to please KR.
2014-03-12 21:21:14 +00:00
Cory Benfield
4d8cb3244e
Add method for rebuilding proxy configuration.
...
This includes auth.
2014-03-12 19:22:40 +00:00
Cory Benfield
97cf16e958
Move auth rebuild to its own method.
2014-03-12 19:22:11 +00:00
kennethreitz
3c4b3747e4
Merge pull request #1921 from sigmavirus24/fix-session-header-none
...
Do not set headers with None value
2014-03-03 13:13:13 -05:00
Cory Benfield
81e88b70bd
The timeout is in seconds.
2014-02-16 19:00:22 +00:00
Ian Cordasco
d2f647cee4
Do not set headers with None value
...
- Regardless of whether they are on the session or not
- Fixes #1920
2014-02-14 16:15:21 -06:00
Zack Weinberg
0caa243212
New Response property, .is_redirect.
2014-02-13 14:27:42 -05:00
Kenneth Reitz
c042c08179
who did this
2014-01-31 12:29:56 -05:00
Kenneth Reitz
f74f5e3ebf
cleanup shitty code
2014-01-31 12:27:05 -05:00
Cory Benfield
d9f34c6848
Respect trust_env on redirect.
2014-01-31 07:36:44 +00:00
Cory Benfield
326a22e888
Better layout for checking.
2014-01-30 15:11:24 +00:00
Cory Benfield
7ba5a534ae
Repopulate ~/.netrc auth.
2014-01-29 19:13:46 +00:00
Konstantinos Koukopoulos
8b792be81b
on redirect pass URL as bytes. Fixes : #1887
2014-01-28 09:11:23 -08:00
Kevin Burke
a0e7706440
Fix warnings when building the docs
...
It may be nice to make builds fail if new documentation generates warnings, to
avoid these sorts of problems slipping in in the future.
2013-12-28 00:09:29 -08:00
Ian Cordasco
642bbf6060
Fixes #1805
...
Sure cookies are persisted to the session, but those new cookies are not added
to the next prepared request. We need to update that new request's CookieJar
with the new cookies.
2013-12-17 22:55:50 -06:00
Ian Cordasco
e8bdcdb0a7
Address feedback from #1729
...
- Make the PreparedRequest's cookie jar an implementation detail
2013-12-04 06:45:18 -06:00
Chase Sterling
8bfe0d873f
Store the request cookiejar in PreparedRequest.cookies fix #1728
...
Conflicts:
requests/sessions.py
2013-12-04 06:38:58 -06:00