From 106e5e90730ad49a7ddaffe1052da08da382796b Mon Sep 17 00:00:00 2001
From: Andreas Motl <andreas.motl@panodata.org>
Date: Fri, 25 Oct 2024 18:01:23 +0200
Subject: [PATCH] CI: Validate on Windows operating system

---
 .github/workflows/test.yaml |  1 +
 tests/test_responder.py     | 26 ++++++++++++++++----------
 2 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index f23b69f..20a1b84 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -22,6 +22,7 @@ jobs:
           "ubuntu-latest",
           "macos-12",
           "macos-latest",
+          "windows-latest",
         ]
         python-version: [
           "3.10",
diff --git a/tests/test_responder.py b/tests/test_responder.py
index b61c266..c3442e6 100644
--- a/tests/test_responder.py
+++ b/tests/test_responder.py
@@ -1,5 +1,7 @@
 import random
 import string
+import sys
+from pathlib import Path
 
 import pytest
 import yaml
@@ -811,7 +813,7 @@ def test_allowed_hosts(enable_hsts, cors):
     assert r.status_code == 200
 
 
-def create_asset(static_dir, name=None, parent_dir=None):
+def create_asset(static_dir: Path, name=None, parent_dir: str = None) -> Path:
     if name is None:
         name = random.choices(string.ascii_letters, k=6)  # noqa: S311
         # :3
@@ -821,16 +823,20 @@ def create_asset(static_dir, name=None, parent_dir=None):
     if parent_dir is None:
         parent_dir = static_dir
     else:
-        parent_dir = static_dir.mkdir(parent_dir)
+        parent_dir = static_dir / parent_dir
+        parent_dir.mkdir()
 
-    asset = parent_dir.join(name)
-    asset.write("body { color: blue; }")
-    return asset
+    asset = parent_dir / name
+    asset.write_text("body { color: blue; }", encoding="utf-8")
+    return Path(asset)
 
 
 @pytest.mark.parametrize("static_route", [None, "/static", "/custom/static/route"])
-def test_staticfiles(tmpdir, static_route):
-    static_dir = tmpdir.mkdir("static")
+def test_staticfiles(tmp_path, static_route):
+    if sys.platform == "win32" and static_route is None:
+        raise pytest.skip("Route 'None' currently does not work on Windows")
+    static_dir = tmp_path / "static"
+    static_dir.mkdir()
 
     asset1 = create_asset(static_dir)
     parent_dir = "css"
@@ -842,10 +848,10 @@ def test_staticfiles(tmpdir, static_route):
     static_route = api.static_route
 
     # ok
-    r = session.get(f"{static_route}/{asset1.basename}")
+    r = session.get(f"{static_route}/{asset1.name}")
     assert r.status_code == api.status_codes.HTTP_200
 
-    r = session.get(f"{static_route}/{parent_dir}/{asset2.basename}")
+    r = session.get(f"{static_route}/{parent_dir}/{asset2.name}")
     assert r.status_code == api.status_codes.HTTP_200
 
     # Asset not found
@@ -871,7 +877,7 @@ def test_staticfiles_none_dir(tmpdir):
     static_route = api.static_route
 
     # ok
-    r = session.get(f"{static_route}/{asset.basename}")
+    r = session.get(f"{static_route}/{asset.name}")
     assert r.status_code == api.status_codes.HTTP_404
 
     # dir listing