From a8caa3054b7bfb68ff09724db3e3692ef462d5f3 Mon Sep 17 00:00:00 2001 From: Kenneth Reitz Date: Sat, 30 Mar 2024 19:44:45 -0400 Subject: [PATCH] Update API requests from GET to POST --- tests/test_encodings.py | 4 ++-- tests/test_responder.py | 18 ++++++++++-------- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/tests/test_encodings.py b/tests/test_encodings.py index 48e9f2e..244cb83 100644 --- a/tests/test_encodings.py +++ b/tests/test_encodings.py @@ -9,7 +9,7 @@ def test_custom_encoding(api, session): req.encoding = "ascii" resp.text = await req.text - r = session.get(api.url_for(route), data=data) + r = session.post(api.url_for(route), data=data) assert r.text == data @@ -20,5 +20,5 @@ def test_bytes_encoding(api, session): async def route(req, resp): resp.text = (await req.content).decode("utf-8") - r = session.get(api.url_for(route), data=data) + r = session.post(api.url_for(route), data=data) assert r.content == data diff --git a/tests/test_responder.py b/tests/test_responder.py index 7f03918..394b7ce 100644 --- a/tests/test_responder.py +++ b/tests/test_responder.py @@ -198,12 +198,14 @@ def test_query_params(api, url): # Requires https://github.com/encode/starlette/pull/102 def test_form_data(api): + @api.route("/") async def route(req, resp): resp.media = {"form": await req.media("form")} dump = {"q": "q"} - r = api.requests.get(api.url_for(route), data=dump) + + r = api.requests.get(api.url_for(route), params=dump) assert r.json()["form"] == dump @@ -245,7 +247,7 @@ def test_background(api): api.text = "ok" r = api.requests.get(api.url_for(route)) - assert r.ok + assert r.status_code < 300 def test_multiple_routes(api): @@ -268,14 +270,14 @@ def test_graphql_schema_json_query(api, schema): api.add_route("/", responder.ext.GraphQLView(schema=schema, api=api)) r = api.requests.post("http://;/", json={"query": "{ hello }"}) - assert r.ok + assert r.status_code < 300 def test_graphiql(api, schema): api.add_route("/", responder.ext.GraphQLView(schema=schema, api=api)) r = api.requests.get("http://;/", headers={"Accept": "text/html"}) - assert r.ok + assert r.status_code < 300 assert "GraphiQL" in r.text @@ -521,7 +523,7 @@ def test_mount_wsgi_app(api, flask): api.mount("/flask", flask) r = api.requests.get("http://;/flask") - assert r.ok + assert r.status_code < 300 def test_async_class_based_views(api): @@ -626,10 +628,10 @@ def test_file_uploads(api): files = await req.media("files") result = {} result["hello"] = files["hello"]["content"].decode("utf-8") - result["not-a-file"] = files["not-a-file"].decode("utf-8") + # result["not-a-file"] = files["not-a-file"].decode("utf-8") resp.media = {"files": result} - world = io.StringIO("world") + world = io.BytesIO(b"world") data = {"hello": ("hello.txt", world, "text/plain"), "not-a-file": b"data only"} r = api.requests.post(api.url_for(upload), files=data) assert r.json() == {"files": {"hello": "world", "not-a-file": "data only"}} @@ -644,7 +646,7 @@ def test_500(api): api, base_url="http://;", raise_server_exceptions=False ) r = dumb_client.get(api.url_for(view)) - assert not r.ok + assert r.status_code >= 300 assert r.status_code == responder.status_codes.HTTP_500