kennethreitz-archive/gitx
1
0
Fork 0
mirror of https://github.com/kennethreitz-archive/gitx.git synced 2026-06-05 23:40:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove uses of dot notation for non properties of NSTask.

Browse Source
This commit is contained in:
Nathan Kinsinger
2010-06-20 09:05:43 -06:00
parent 83e7c42ab4
commit 1b3f4ea4da
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PBEasyPipe.m
+12 -12
View File
@@ -19,10 +19,10 @@
+ (NSTask *) taskForCommand:(NSString *)cmd withArgs:(NSArray *)args inDir:(NSString *)dir
{
NSTask* task = [[NSTask alloc] init];
task.launchPath = cmd;
task.arguments = args;
[task setLaunchPath:cmd];
[task setArguments:args];
if (dir)
task.currentDirectoryPath = dir;
[task setCurrentDirectoryPath:dir];
if ([[NSUserDefaults standardUserDefaults] boolForKey:@"Show Debug Messages"])
NSLog(@"Starting command `%@ %@` in dir %@", cmd, [args componentsJoinedByString:@" "], dir);
@@ -31,15 +31,15 @@
#endif
NSPipe* pipe = [NSPipe pipe];
task.standardOutput = pipe;
task.standardError = pipe;
[task setStandardOutput:pipe];
[task setStandardError:pipe];
return task;
}
+ (NSFileHandle*) handleForCommand: (NSString*) cmd withArgs: (NSArray*) args inDir: (NSString*) dir
{
NSTask *task = [self taskForCommand:cmd withArgs:args inDir:dir];
NSFileHandle* handle = [task.standardOutput fileHandleForReading];
NSFileHandle* handle = [[task standardOutput] fileHandleForReading];
[task launch];
return handle;
@@ -76,14 +76,14 @@
if (dict) {
NSMutableDictionary *env = [[[NSProcessInfo processInfo] environment] mutableCopy];
[env addEntriesFromDictionary:dict];
task.environment = env;
[task setEnvironment:env];
}
NSFileHandle* handle = [task.standardOutput fileHandleForReading];
NSFileHandle* handle = [[task standardOutput] fileHandleForReading];
if (input) {
task.standardInput = [NSPipe pipe];
NSFileHandle *inHandle = [task.standardInput fileHandleForWriting];
[task setStandardInput:[NSPipe pipe]];
NSFileHandle *inHandle = [[task standardInput] fileHandleForWriting];
[inHandle writeData:[input dataUsingEncoding:NSUTF8StringEncoding]];
[inHandle closeFile];
}
@@ -111,10 +111,10 @@
+ (NSString*) outputForCommand: (NSString*) cmd withArgs: (NSArray*) args inDir: (NSString*) dir
{
NSTask *task = [self taskForCommand:cmd withArgs:args inDir:dir];
NSFileHandle* handle = [task.standardOutput fileHandleForReading];
NSFileHandle* handle = [[task standardOutput] fileHandleForReading];
[task launch];
#warning This can cause a "Bad file descriptor"... when?
// This can cause a "Bad file descriptor"... when?
NSData *data;
@try {
data = [handle readDataToEndOfFile];