kennethreitz-archive/gitx
1
0
Fork 0
mirror of https://github.com/kennethreitz-archive/gitx.git synced 2026-06-05 23:40:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't crash with multiline gitconfig values.

Browse Source 
Use `git config -l -z` to get configs.
This commit is contained in:
Andrew Ryan
2011-05-10 13:23:26 -04:00
parent fb6abc7de7
commit 1f73579993
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PBGitConfig.m
+6 -5
View File
@@ -99,19 +99,20 @@
NSArray* arguments;
if (inDir == nil) {
arguments = [NSArray arrayWithObjects:@"config", @"--global", @"-l", nil];
arguments = [NSArray arrayWithObjects:@"config", @"--global", @"-l", @"-z", nil];
} else {
arguments = [NSArray arrayWithObjects:@"config", @"-l", nil];
arguments = [NSArray arrayWithObjects:@"config", @"-l", @"-z", nil];
}
int ret = 1;
NSString* output = [PBEasyPipe outputForCommand:[PBGitBinary path] withArgs:arguments inDir:inDir retValue:&ret];
NSMutableDictionary *result = [NSMutableDictionary dictionary];
if (ret==0) {
NSArray *lines = [output componentsSeparatedByString:@"\n"];
NSArray *lines = [output componentsSeparatedByString:@"\0"];
for (NSString* line in lines) {
NSRange equalsPos = [line rangeOfString:@"="];
if([line length] == 0) continue;
NSRange equalsPos = [line rangeOfString:@"\n"];
NSString* key = [line substringToIndex:equalsPos.location];
NSString* value = [line substringFromIndex:equalsPos.location+1];
[result setObject:value forKey:key];