kennethreitz-archive/gitx
1
0
Fork 0
mirror of https://github.com/kennethreitz-archive/gitx.git synced 2026-06-05 23:40:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reinstate the -finalize method to remove ourselves as observer.

Browse Source 
I was confusing KVO with Notifications earlier, as the GC Programming Guide 
explicitly says one should not unregister notifications in a finalize method 
when using GC.
This commit is contained in:
André Berg
2010-03-30 15:20:29 +02:00
parent 156d67f1fb
commit 25b47bb34b
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PBWebHistoryController.m
+6 -6
View File
@@ -158,15 +158,15 @@ contextMenuItemsForElement:(NSDictionary *)element
return [historyController valueForKeyPath:[@"repository.config." stringByAppendingString:config]];
}
// - (void) finalize
// {
// [historyController removeObserver:self forKeyPath:@"webCommit"];
// [super finalize];
// }
- (void) finalize
{
[historyController removeObserver:self forKeyPath:@"webCommit"];
[super finalize];
}
- (void) preferencesChanged
{
[[self script] callWebScriptMethod:@"enableFeatures" withArguments:nil];
[[self script] callWebScriptMethod:@"enableFeatures" withArguments:nil];
}
@end