kennethreitz-archive/gitx
1
0
Fork 0
mirror of https://github.com/kennethreitz-archive/gitx.git synced 2026-06-05 23:40:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix: crasher on 10.5 due to webkit and the <button> element

Browse Source 
Something in webkit doesn't like the button html element nor the -webkit-appearance: button css tag. Ends up crashing in one of various WebCore::ThemeMac::paint functions.

This would crash for anyone on 10.5 with the Gist it button enabled (which it is by default so that means anyone who ran it for the first time).

Changing the button back to the way it was before SHA:b557d6b5c6e675216d340d20833f39d0096b7ccc
This commit is contained in:
Nathan Kinsinger
2010-09-18 19:14:35 -06:00
parent 3933744ba9
commit 9a9de9577c
2 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
html/views/history/history.css
+15 -6
View File
@@ -26,12 +26,21 @@ body {
float: left;
}
#gist {
-webkit-appearance: button;
font: 13px bold 'Lucida Grande';
width: 80px;
height: 23px;
margin-right: 5px;
a.servicebutton {
display: block;
width: 80px;
padding: 2px;
margin-bottom: 4px;
border: 1px solid #3465a4;
background-color: #cce5ff;
color: #204a87;
font-size: 65%;
text-decoration: none;
text-align: center;
-webkit-border-radius: 2px;
}
.gravatar {
html/views/history/index.html
+3 -1
View File
@@ -14,7 +14,9 @@
<body style="padding: 0px; border: 0px">
<div id="rightcontent">
<div id="buttons">
<button id="gist" onClick="confirm_gist();return false" style="display:none">Gist&nbsp;it</button>
<a class="servicebutton" id="gist" onclick="confirm_gist();return false" href="#">
Gist it
</a>
</div>
</div>
<table id="commit_header">