Merge pull request #886 from heroku/we-are-the-walrus

We Are The Walrus (Python 3.8 Support)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 # Master
 
+- Add support for Python 3.8 branch
 - Sqlite3 Update:
   - Add Tests
   - Test for Pysqlite

bin/compile

@@ -52,6 +52,7 @@ export VENDOR_URL
 source "$BIN_DIR/default_pythons"
 
 # Supported Python Branches
+PY38="python-3.8"
 PY37="python-3.7"
 PY36="python-3.6"
 PY35="python-3.5"

bin/default_pythons

@@ -1,10 +1,11 @@
 #!/usr/bin/env bash
 
 DEFAULT_PYTHON_VERSION="python-3.6.9"
+LATEST_38="python-3.8.0"
+LATEST_37="python-3.7.5"
 LATEST_36="python-3.6.9"
-LATEST_37="python-3.7.4"
 LATEST_35="python-3.5.7"
 LATEST_34="python-3.4.10"
 LATEST_27="python-2.7.16"
 
-export DEFAULT_PYTHON_VERSION LATEST_37 LATEST_36 LATEST_35 LATEST_34 LATEST_27
+export DEFAULT_PYTHON_VERSION LATEST_38 LATEST_37 LATEST_36 LATEST_35 LATEST_34 LATEST_27

bin/steps/python

@@ -11,6 +11,13 @@ SECURITY_UPDATE="Python has released a security update! Please consider upgradin
 
 # check if runtime exists
 if curl --output /dev/null --silent --head --fail "$VENDORED_PYTHON"; then
+  if [[ "$PYTHON_VERSION" == $PY38* ]]; then
+    # do things to alert the user of security release available
+    if [ "$PYTHON_VERSION" != "$LATEST_38" ]; then
+      puts-warn "$SECURITY_UPDATE" "$LATEST_38"
+      echo "       Learn More: https://devcenter.heroku.com/articles/python-runtimes"
+    fi
+  fi
   if [[ "$PYTHON_VERSION" == $PY37* ]]; then
     # do things to alert the user of security release available
     if [ "$PYTHON_VERSION" != "$LATEST_37" ]; then

test/fixtures/python3_8/requirements.txt

@@ -0,0 +1 @@
+requests

test/fixtures/python3_8/runtime.txt

@@ -0,0 +1 @@
+python-3.8.0

test/fixtures/python3_8_fail/requirements.txt

@@ -0,0 +1 @@
+flask

test/fixtures/python3_8_fail/runtime.txt

@@ -0,0 +1 @@
+python-3.8.99

test/run-versions

@@ -146,6 +146,25 @@ testPython3_7_fail() {
   assertCapturedError
 }
 
+testPython3_8() {
+  updateVersion "python3_8" $LATEST_38
+  compile "python3_8"
+  if [[ $STACK = "cedar-14" ]]; then
+    assertCapturedError
+  else
+    assertNotCaptured "security update"
+    assertCaptured $LATEST_38
+    assertCaptured "Installing SQLite3"
+    assertCapturedSuccess
+  fi
+}
+
+testPython3_8_fail() {
+  compile "python3_8_fail"
+  assertCaptured "Aborting"
+  assertCapturedError
+}
+
 pushd $(dirname 0) >/dev/null
 popd >/dev/null