Raise ValueError instead of AssertionError

This commit is contained in:
Timo Furrer
2017-05-28 12:18:35 +02:00
parent 720617f062
commit 971ecec9cf
2 changed files with 12 additions and 6 deletions
+7 -2
View File
@@ -415,7 +415,9 @@ class MayaInterval(object):
# Convert seconds to timedelta, if appropriate.
duration = seconds_or_timedelta(duration)
assert duration > timedelta(seconds=0), 'cannot call split with a non-positive timedelta'
if duration <= timedelta(seconds=0):
raise ValueError('cannot call split with a non-positive timedelta')
start = self.start
while start < self.end:
if start + duration <= self.end:
@@ -431,7 +433,10 @@ class MayaInterval(object):
duration = seconds_or_timedelta(duration)
timezone = pytz.timezone(timezone)
assert duration > timedelta(seconds=0), 'cannot quantize by non-positive timedelta'
if duration <= timedelta(seconds=0):
raise ValueError('cannot quantize by non-positive timedelta')
epoch = timezone.localize(Datetime(1970, 1, 1))
seconds = int(duration.total_seconds())
+5 -4
View File
@@ -387,10 +387,10 @@ def test_interval_split_non_positive_delta():
end = start.add(days=1)
interval = maya.MayaInterval(start=start, end=end)
with pytest.raises(AssertionError):
with pytest.raises(ValueError):
list(interval.split(timedelta(seconds=0)))
with pytest.raises(AssertionError):
with pytest.raises(ValueError):
list(interval.split(timedelta(seconds=-10)))
@@ -442,9 +442,10 @@ def test_quantize_invalid_delta():
end = start.add(days=1)
interval = maya.MayaInterval(start=start, end=end)
with pytest.raises(AssertionError):
with pytest.raises(ValueError):
interval.quantize(timedelta(minutes=0))
with pytest.raises(AssertionError):
with pytest.raises(ValueError):
interval.quantize(timedelta(minutes=-1))