kennethreitz/pipenv
1
0
Fork 0
mirror of https://github.com/kennethreitz/pipenv.git synced 2026-06-05 06:46:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor changes to the PR template

Browse Source 
- Comment out the vendor directory section so it doesn't show up all the time in prs
- Minor grammar and spelling changes
- Warn users that we will close PRs with no issue or explanation about what they are solving
This commit is contained in:
Dan Ryan
2018-07-31 23:11:38 -04:00
committed by GitHub
parent 2db196dc26
commit a663f58663
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/PULL_REQUEST_TEMPLATE.md
+5 -4
View File
@@ -5,7 +5,7 @@ Thank you for contributing to Pipenv!
What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.
Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it.
Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.
##### The fix
@@ -16,13 +16,14 @@ How does this pull request fix your problem? Did you consider any alternatives?
##### The checklist
* [ ] Associated issue
* [ ] A news fragment in the `news/` directory to describe this fix (this will appear in the release changelog).
* [ ] A news fragment in the `news/` directory to describe this fix with the extension `.bugfix`, `.feature`, `.behavior`, `.doc`. `.vendor`. or `.trivial` (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.
<!--
##### If this is a patch to the `vendor` directory…
Please try to refrain from submitting patches directly to `vendor` or `patched`, but raise your issue to the upstream project instead, and inform Pipenv to upgrade when the upstream project accepts the fix.
A pull request to upgrade vendor packages is strongly discouraged, unless there is a very good reason (e.g. you need to test Pipenv’s integration to a new vendor feature). Pipenv audits and perform vendor upgrades regularly, generally before a new release is about to drop.
A pull request to upgrade vendor packages is strongly discouraged, unless there is a very good reason (e.g. you need to test Pipenv’s integration to a new vendor feature). Pipenv audits and performs vendor upgrades regularly, generally before a new release is about to drop.
If your patch is not or cannot be accepted by upstream, but is essential to Pipenv (make sure to discuss this with maintainers!), please remember to attach a patch file in `tasks/vendoring/patched`, so this divergence from upstream can be recorded and replayed afterwards.
-->