The default escape character for pexpect.spaw is ctrl-]
which conflicts with a vim binding. This isn't an escape
sequence that is mirrored in virtualenv, so there doesn't
seem to be a good reason to keep it. This will make `pipenv
shell` more inline with the standard `virtualenv workon` command.
We previously divided our dependencies into two separate lists.
This was to allow us to require hashes for pypi packages, but
ignore them for VCS dependencies since they won't exist. Now
that we're installing one package at a time, we can bundle dependencies
back together earlier and reduce the code duplication.
flake8 would have caught the regression in #371 and output:
`pipenv/cli.py:257:19: F821 undefined name 'hashed_deps_path'`
Whilst in an ideal world there would be 100% test coverage, linters help
fill in the gaps, plus spot potential unused variable/imports cleanup.
I'm happy to disable more of the style/whitespace pep8 rules if
needed - the priority is having the pyflakes subset run in CI.
pipenv/cli.py:264:1: W293 blank line contains whitespace
pipenv/cli.py:546:1: E302 expected 2 blank lines, found 1
pipenv/environments.py:31:25: W292 no newline at end of file
pipenv/progress.py:171:23: W292 no newline at end of file
pipenv/utils.py:20:1: E302 expected 2 blank lines, found 1
pipenv/utils.py:206:6: E114 indentation is not a multiple of four (comment)
tests/test_project.py:8:1: E302 expected 2 blank lines, found 1
tests/test_utils.py:7:1: E302 expected 2 blank lines, found 1
tests/test_utils.py:75:5: E303 too many blank lines (2)
tests/test_utils.py:113:5: E303 too many blank lines (2)
tests/test_utils.py:124:5: E303 too many blank lines (2)
tests/test_utils.py:135:5: E303 too many blank lines (2)
pipenv/cli.py:24:1: F401 '.utils.recase_file' imported but unused
pipenv/cli.py:466:5: F841 local variable 'p' is assigned to but never used
pipenv/utils.py:13:5: F401 'html.parser.HTMLParser' imported but unused
pipenv/utils.py:246:25: F841 local variable 'e' is assigned to but never used
tests/test_pipenv.py:9:1: F401 'pipenv.cli.which_pip' imported but unused
Nate Prewitt
kennethreitz