change CI to 3.8 (#902)

* change CI to 3.8

* fix linting

* travis jobs for 3.8

* redo noqa comments

* add 3.8 to azure

.travis.yml

@@ -7,7 +7,7 @@ cache: pip
 python:
 - '3.6'
 - '3.7'
-- '3.8-dev'
+- '3.8'
 
 install:
 - make install
@@ -32,9 +32,6 @@ after_success:
 - bash <(curl -s https://codecov.io/bash) -e CYTHON,DEPS
 
 jobs:
-  allow_failures:
-  - python: '3.8-dev'
-
   include:
   - stage: test
     python: 3.6
@@ -54,6 +51,15 @@ jobs:
     - make test
     env:
     - 'CYTHON=yes'
+  - stage: test
+    python: 3.8
+    name: 'Cython: 3.8'
+    script:
+    - make build-cython-trace
+    - python -c "import sys, pydantic; print('compiled:', pydantic.compiled); sys.exit(0 if pydantic.compiled else 1)"
+    - make test
+    env:
+    - 'CYTHON=yes'
 
   - stage: test
     python: 3.6
@@ -71,6 +77,14 @@ jobs:
     - make test
     env:
     - 'DEPS=no'
+  - stage: test
+    python: 3.8
+    name: 'Without Deps 3.8'
+    script:
+      - pip uninstall -y cython email-validator typing-extensions devtools
+      - make test
+    env:
+      - 'DEPS=no'
 
   - stage: test
     python: 3.7

azure-pipelines.yml

@@ -9,6 +9,9 @@ strategy:
       python.version: '3.6'
     Python37:
       python.version: '3.7'
+# not supported as of 2019-10-16 :-(
+#    Python38:
+#      python.version: '3.8'
 
 steps:
 - task: UsePythonVersion@0

pydantic/main.py

@@ -145,7 +145,7 @@ UNTOUCHED_TYPES = FunctionType, property, type, classmethod, staticmethod
 
 class ModelMetaclass(ABCMeta):
     @no_type_check  # noqa C901
-    def __new__(mcs, name, bases, namespace, **kwargs):
+    def __new__(mcs, name, bases, namespace, **kwargs):  # noqa C901
         fields: Dict[str, ModelField] = {}
         config = BaseConfig
         validators: 'ValidatorListDict' = {}

tests/test_validators.py

@@ -815,7 +815,7 @@ def test_root_validator_repeat():
                 return values
 
             @root_validator  # noqa: F811
-            def root_validator_repeated(cls, values):
+            def root_validator_repeated(cls, values):  # noqa: F811
                 return values
 
 
@@ -830,7 +830,7 @@ def test_root_validator_repeat2():
                 return v
 
             @root_validator(pre=True)  # noqa: F811
-            def repeat_validator(cls, values):
+            def repeat_validator(cls, values):  # noqa: F811
                 return values