kennethreitz/requests
1
0
Fork 0
mirror of https://github.com/kennethreitz/requests.git synced 2026-06-05 22:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handles request in event of HTTPError. Fixes Issue #2

Browse Source 
Building of internal request object refactor
This commit is contained in:
Kenneth Reitz
2011-02-14 11:31:06 -05:00
parent a82f4de38d
commit 10280c697d
1 changed files with 20 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
requests/core.py
+20 -21
View File
@@ -99,9 +99,17 @@ class Request(object):
else:
return urllib2.urlopen
def _build_response(self, resp):
"""Build internal Response object from given response."""
self.response.status_code = resp.code
self.response.headers = resp.info().dict
self.response.content = resp.read()
self.response.url = resp.url
def send(self, anyway=False):
"""Sends the request. Returns True of successfull, false if not.
"""Sends the request. Returns True of successful, false if not.
If there was an HTTPError during transmission,
self.response.status_code will contain the HTTPError code.
@@ -135,15 +143,12 @@ class Request(object):
try:
resp = opener(req)
self.response.status_code = resp.code
self.response.headers = resp.info().dict
if self.method == 'GET':
self.response.content = resp.read()
self.response.url = resp.url
self._build_response(resp)
success = True
except urllib2.HTTPError as why:
self.response.status_code = why.code
self._build_response(why)
success = False
elif self.method == 'PUT':
@@ -170,15 +175,12 @@ class Request(object):
opener = self._get_opener()
resp = opener(req)
self.response.status_code = resp.code
self.response.headers = resp.info().dict
self.response.content = resp.read()
self.response.url = resp.url
self._build_response(resp)
success = True
except urllib2.HTTPError as why:
self.response.status_code = why.code
self._build_response(why)
success = False
elif self.method == 'POST':
@@ -207,15 +209,12 @@ class Request(object):
opener = self._get_opener()
resp = opener(req)
self.response.status_code = resp.code
self.response.headers = resp.info().dict
self.response.content = resp.read()
self.response.url = resp.url
self._build_response(resp)
success = True
except urllib2.HTTPError as why:
self.response.status_code = why.code
sself._build_response(why)
success = False
self.sent = True if success else False