Merge pull request #5492 from dbaxa/avoid-calling-resolve_redirects-whe-not-following-redirects

Remove what appears to be an un-needed call to self.resolve_redirects when not following redirects as part of creating a request's history.
This commit is contained in:
Nate Prewitt
2020-06-15 07:44:38 -07:00
committed by GitHub
+6 -4
View File
@@ -658,11 +658,13 @@ class Session(SessionRedirectMixin):
extract_cookies_to_jar(self.cookies, request, r.raw)
# Redirect resolving generator.
gen = self.resolve_redirects(r, request, **kwargs)
# Resolve redirects if allowed.
history = [resp for resp in gen] if allow_redirects else []
if allow_redirects:
# Redirect resolving generator.
gen = self.resolve_redirects(r, request, **kwargs)
history = [resp for resp in gen]
else:
history = []
# Shuffle things around if there's history.
if history: