Merge pull request #4245 from remram44/fix-headers-links

Fix parse_header_links on empty header

HISTORY.rst

@@ -10,6 +10,8 @@ dev
 
 **Bugfixes**
 
+- Parsing empty ``Link`` headers with ``parse_header_links()`` no longer return one bogus entry
+
 2.18.4 (2017-08-15)
 +++++++++++++++++++
 

requests/utils.py

@@ -743,7 +743,7 @@ def default_headers():
 
 
 def parse_header_links(value):
-    """Return a dict of parsed link headers proxies.
+    """Return a list of parsed link headers proxies.
 
     i.e. Link: <http:/.../front.jpeg>; rel=front; type="image/jpeg",<http://.../back.jpeg>; rel=back;type="image/jpeg"
 
@@ -754,6 +754,10 @@ def parse_header_links(value):
 
     replace_chars = ' \'"'
 
+    value = value.strip(replace_chars)
+    if not value:
+        return links
+
     for val in re.split(', *<', value):
         try:
             url, params = val.split(';', 1)

tests/test_utils.py

@@ -498,6 +498,10 @@ def test_iter_slices(value, length):
                 {'url': 'http://.../back.jpeg'}
             ]
         ),
+        (
+            '',
+            []
+        ),
     ))
 def test_parse_header_links(value, expected):
     assert parse_header_links(value) == expected